Repository navigation
ci(next): drop feat-cmux-next's copy of the familiar-intent workflow, which never runs - #28459
Merged
Merged
Conversation
… which never runs GitHub runs a pull_request_target workflow from the default branch (main) whatever the pull request's base, so this copy of intent-familiar-review.yml never ran. #25295 and #25670 fixed this copy, while main's kept failing `warn` on the installation's rate limit, and next-autoland read that red as the PR's own (cmux#27923). #28447 fixed main's copy (50579c6), whose jobs block was identical to this one. - Delete .github/workflows/intent-familiar-review.yml here. Main's copy still checks out this branch's scripts/ci/intent_familiar_warning.py at the PR's base, so the checker stays here. - tests/test_intent_familiar_warning.py: FamiliarIntentWorkflowTests checked this dead copy's steps (which is how the bug hid). It now fails if a copy comes back here, naming main's file to edit. The detector tests are unchanged. - cmux-next.yml: drop the deleted file from the two paths filters (test_cmux_next_checks_workflow requires every named path to exist). A file that no longer exists triggers nothing, so this changes no trigger. Red, then green: tests/test_intent_familiar_warning.py fails with the copy present and passes once it is deleted. test_cmux_next_checks_workflow.py (165), test_ci_actionlint_covers_every_workflow.py, test_ci_runs_on_values.py, test_ci_guard_workflow_structure.py and test_ci_reusable_workflow_permissions.py pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e281136dd51f7f0cd599
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Collaborator
Author
|
Review (codex gpt-6.1-sol high, fast): SHIP at 4d3ecef Findings: none.
|
Contributor
|
Shipped in:
|
teamleaderleo
added a commit
that referenced
this pull request
Oct 30, 2026
…-only workflow edit is CI-only (#28490) The Mac fast tier (side-std) ran whenever swift test ran. It builds the CmuxNext and CmuxHomeRender packages with no web bundles and runs six suites, so now it runs when a package target's sources change, a file read by a test target that holds one of its suites changes (placed from fast-tier.json and the target graph), a package it builds or an action its job uses changes, or an every-tier input changes. Web bundle inputs alone (#28160, #28015) and cmux-app-ffi sources (a pinned binary target) keep swift test and skip it. A change to cmux-next.yml ran every tier. With --base-rev HEAD^1 the router now compares it per job: a change only to `on:`/`run-name` or to Linux-only jobs no Mac job needs (#28459, the checks job) is a CI-only file. Any changed Mac job, a job one needs, a top-level key or an unreadable base runs every tier. Agent-Session: https://cmux.com/deeplink/agent?id=aid-0b4091cd6a9b72e19edf Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes back #25295: its continue-on-error and (advisory) name went into the feat-cmux-next copy, which never runs (pull_request_target runs main's copy). #28447 ported them to main, so this copy and its shape test are dead; the new test fails if a copy returns.
GitHub runs a
pull_request_targetworkflow from the default branch (main) whatever the pull request's base, sofeat-cmux-next's copy of.github/workflows/intent-familiar-review.ymlnever runs. #25295 and #25670 fixed this copy, whilemain's kept failingwarnon the installation's rate limit. next-autoland then read that red as the PR's own (#27923). #28447 fixedmain's copy (50579c6); itsjobs:block was identical to this one.This PR removes the copy that never runs, so nobody fixes the wrong one again:
.github/workflows/intent-familiar-review.ymlfromfeat-cmux-next. Main's copy still checks out this branch'sscripts/ci/intent_familiar_warning.pyat the PR's base, so the checker stays here.tests/test_intent_familiar_warning.py:FamiliarIntentWorkflowTestschecked the steps of this dead copy, which is how the bug hid. It now fails if a copy comes back on this branch, and namesmain's file to edit. The detector tests are unchanged.cmux-next.yml: drops the deleted file from the twopathsfilters, becausetest_cmux_next_checks_workflow.pyrequires every named path to exist. A file that no longer exists triggers nothing, so no trigger changes. No permissions change.Testing
python3 tests/test_intent_familiar_warning.pyfails with the copy present and passes after the delete (5 tests).tests/test_cmux_next_checks_workflow.pypasses (165 tests). Before thepathsedit it failed only on the missing file.tests/test_ci_actionlint_covers_every_workflow.py,test_ci_runs_on_values.py,test_ci_guard_workflow_structure.py,test_ci_reusable_workflow_permissions.pyand the pre-push gate pass.Observed / Not run
warnjob came frommain's copy. Its job title had no "(advisory)", the name only this branch's copy carried.pull_request_targetevent after this lands. Nothing on this branch takes part in that event any more.Changelog
none
Proof
CI only.
Agent session: agent session
🤖 Generated with Claude Code