Skip to content

ci(next): drop feat-cmux-next's copy of the familiar-intent workflow, which never runs - #28459

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ao-familiar-intent-dead-copy
Oct 30, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/ao-familiar-intent-dead-copy

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Takes back #25295: its continue-on-error and (advisory) name went into the feat-cmux-next copy, which never runs (pull_request_target runs main's copy). #28447 ported them to main, so this copy and its shape test are dead; the new test fails if a copy returns.

GitHub runs a pull_request_target workflow from the default branch (main) whatever the pull request's base, so feat-cmux-next's copy of .github/workflows/intent-familiar-review.yml never runs. #25295 and #25670 fixed this copy, while main's kept failing warn on the installation's rate limit. next-autoland then read that red as the PR's own (#27923). #28447 fixed main's copy (50579c6); its jobs: block was identical to this one.

This PR removes the copy that never runs, so nobody fixes the wrong one again:

  • Deletes .github/workflows/intent-familiar-review.yml from feat-cmux-next. Main's copy still checks out this branch's scripts/ci/intent_familiar_warning.py at the PR's base, so the checker stays here.
  • tests/test_intent_familiar_warning.py: FamiliarIntentWorkflowTests checked the steps of this dead copy, which is how the bug hid. It now fails if a copy comes back on this branch, and names main's file to edit. The detector tests are unchanged.
  • cmux-next.yml: drops the deleted file from the two paths filters, because test_cmux_next_checks_workflow.py requires every named path to exist. A file that no longer exists triggers nothing, so no trigger changes. No permissions change.

Testing

  • python3 tests/test_intent_familiar_warning.py fails with the copy present and passes after the delete (5 tests).
  • tests/test_cmux_next_checks_workflow.py passes (165 tests). Before the paths edit it failed only on the missing file.
  • tests/test_ci_actionlint_covers_every_workflow.py, test_ci_runs_on_values.py, test_ci_guard_workflow_structure.py, test_ci_reusable_workflow_permissions.py and the pre-push gate pass.

Observed / Not run

Changelog

none

Proof

CI only.

Agent session: agent session

🤖 Generated with Claude Code

… which never runs

GitHub runs a pull_request_target workflow from the default branch (main)
whatever the pull request's base, so this copy of intent-familiar-review.yml
never ran. #25295 and #25670 fixed this copy, while main's kept failing `warn`
on the installation's rate limit, and next-autoland read that red as the PR's
own (cmux#27923). #28447 fixed main's copy (50579c6), whose jobs block
was identical to this one.

- Delete .github/workflows/intent-familiar-review.yml here. Main's copy still
  checks out this branch's scripts/ci/intent_familiar_warning.py at the PR's
  base, so the checker stays here.
- tests/test_intent_familiar_warning.py: FamiliarIntentWorkflowTests checked
  this dead copy's steps (which is how the bug hid). It now fails if a copy
  comes back here, naming main's file to edit. The detector tests are unchanged.
- cmux-next.yml: drop the deleted file from the two paths filters
  (test_cmux_next_checks_workflow requires every named path to exist). A file
  that no longer exists triggers nothing, so this changes no trigger.

Red, then green: tests/test_intent_familiar_warning.py fails with the copy
present and passes once it is deleted. test_cmux_next_checks_workflow.py (165),
test_ci_actionlint_covers_every_workflow.py, test_ci_runs_on_values.py,
test_ci_guard_workflow_structure.py and test_ci_reusable_workflow_permissions.py
pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-e281136dd51f7f0cd599
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 4d3ecef: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28459 -f ref=lane/ao-familiar-intent-dead-copy -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol high, fast): SHIP at 4d3ecef

Findings: none.

  • A full-tree grep finds nothing that still reads the workflow; the only mention left is the intentional absence check in tests/test_intent_familiar_warning.py.
  • Main's workflow checks out github.event.pull_request.base.sha, which has scripts/ci/intent_familiar_warning.py, so deleting this copy is safe.
  • The cmux-next.yml diff removes only the two path entries for the deleted file; triggers and permissions are otherwise unchanged.
  • tests/test_intent_familiar_warning.py (5) and tests/test_cmux_next_checks_workflow.py (165) pass. No check becomes red or skipped.

@cmux-bot cmux-bot Bot removed the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo
teamleaderleo merged commit 24b8b43 into feat-cmux-next Oct 30, 2026
213 of 236 checks passed
@teamleaderleo
teamleaderleo deleted the lane/ao-familiar-intent-dead-copy branch October 30, 2026 18:27
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

teamleaderleo added a commit that referenced this pull request Oct 30, 2026
…-only workflow edit is CI-only (#28490)

The Mac fast tier (side-std) ran whenever swift test ran. It builds the CmuxNext
and CmuxHomeRender packages with no web bundles and runs six suites, so now it
runs when a package target's sources change, a file read by a test target that
holds one of its suites changes (placed from fast-tier.json and the target
graph), a package it builds or an action its job uses changes, or an
every-tier input changes. Web bundle inputs alone (#28160, #28015) and
cmux-app-ffi sources (a pinned binary target) keep swift test and skip it.

A change to cmux-next.yml ran every tier. With --base-rev HEAD^1 the router now
compares it per job: a change only to `on:`/`run-name` or to Linux-only jobs
no Mac job needs (#28459, the checks job) is a CI-only file. Any changed Mac
job, a job one needs, a top-level key or an unreadable base runs every tier.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-0b4091cd6a9b72e19edf

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 4d3ecefe Deployed Oct 30, 2026 by teamleaderleo via cmux-tui tree preflight #84394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant