Skip to content

base red: release-notary: two highlights link the agents docs; trust glaeda hook e94edf9c (combines #28421) - #28441

Closed
lawrencecchen wants to merge 2 commits into
feat-cmux-nextfrom
base-red/whats-new-highlight
Closed

lawrencecchen wants to merge 2 commits into
feat-cmux-nextfrom
base-red/whats-new-highlight

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Combines #28421 (each red on the other's red): release-notary needs both fixes, and each PR alone stays red on the other's check.

Base red on feat-cmux-next: release-notary (nightly-guards / workflow-guard-tests / release-notary) fails python3 scripts/whats-new/test_digest.py, test_the_repository_highlights_validate, on every recent feat commit:

Fix

Both are Fixed entries about agent chats, with no action to try, so each gets the docs link 22 other highlights use: docs: https://cmux.com/docs/agents (release-notes/next/WRITING.md, "One file per change"). The test and the validator are unchanged.

Evidence (the check's own command, run on this branch's base and head)

python3 -I scripts/whats-new/test_digest.py
base 49cba34 FAILED (failures=1): both files named
head 6052afe OK (5 tests); scripts/whats-new/test_validate.py also OK

2. The glaeda signing hook (from #28421)

tests/test_ci_signing_owned_mac.py (test_every_listed_hook_is_one_glaeda_released_with_the_check) failed: glaeda's newest hook e94edf9c was not in scripts/ci/glaeda-signing-hooks.txt. HQ's sync PR #28421 (cmux-bot, d4eef12) adds its line. Its one commit is cherry-picked here with -x, author kept.

Both checks at the head b97cab9

command base 49cba34 head
python3 -I scripts/whats-new/test_digest.py FAILED (failures=1) OK (5 tests)
python3 -I tests/test_ci_signing_owned_mac.py FAILED (failures=1) (hook e94edf9c not listed) OK (15 tests)

R9: no new cap, limit or timeout.
R10: no code change.

Observed / Not run

  • Observed: the runs above, on this VM.
  • Not run: the full release-notary group (most of it needs the CI runner).

Changelog

  • none

No capture: release-note text only.

…t's New requires

chief-name-in-agent-chats.md (#27935) and shell-agent-identity.md (#26627)
had neither a tryIt action nor a docs link, so scripts/whats-new/test_digest.py
(release-notary guards) failed on every feat-cmux-next commit. Both now link
https://cmux.com/docs/agents, the docs page of the agent chat they describe.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b97cab9: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28441 -f ref=base-red/whats-new-highlight -f platform=macos -f backend_mode=local

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent review subagent, Claude Opus 5.5): SHIP at 6052afe
reviewer-session: rbr2-1bc01019
author-session: a1c85faf51fad876b
R9: pass. The PR adds no cap, limit or timeout. It adds two lines of release-note text.
perf claim: none

Scope

The diff adds docs: https://cmux.com/docs/agents to two highlight files:
release-notes/next/highlights/chief-name-in-agent-chats.md (#27935) and
release-notes/next/highlights/shell-agent-identity.md (#26627). It does not change the test,
the validator or a generated file.

Is docs: the right field?

Yes. scripts/whats-new/validate.py:183-196 requires each entry to have a tryIt
action/deeplink or a docs link. Both entries are category: fixed and have no action that a
person can start, so a tryIt action is not applicable. release-notes/next/WRITING.md
("One file per change") shows docs: as the optional link field. The test is not weaker:
the PR changes only the data.

Findings (non-blocking)

  1. The link target does not exist. https://cmux.com/docs/agents gives HTTP 404 today
    (curl, 2026-10-30). The repository has no /docs/agents route on feat-cmux-next or on
    main, and web/next.config.ts has no redirect for it. The cmux-next agents page is
    /docs/next/agents ("Agents and subagents", web/data/next-docs/pages.ts; the Chief page
    is /docs/next/home-and-chief). That page also gives 404 today, because the next docs are
    not on the deployed site yet.
    The PR follows the example in WRITING.md line 18, and 24 other highlights use the same
    URL. Thus this is a base defect, not a defect of this PR. Do not hold this base-red fix for
    it. Follow-up: change the WRITING.md example and all 26 highlights to
    https://cmux.com/docs/next/agents, or add a /docs/agents redirect in web/next.config.ts.

Observed

  • python3 -I scripts/whats-new/test_digest.py at base 49cba34: FAILED (failures=1).
    The failure names both files: "needs a tryIt action/deeplink or a docs link".
  • The same test at head 6052afe: OK (5 tests).
  • python3 -I scripts/whats-new/test_validate.py at base and head: OK (15 tests).
  • The same test at the current feat tip 783bc25: FAILED. With this commit applied: OK.
    No newer highlight file breaks it again.
  • CI on this head: test_digest.py passes in release-notary (job 124201242217).

Not run

  • The full release-notary group on this VM.

checks:

  • gh pr checks 28441: 43 pass, 53 skipping, 3 neutral, 2 fail.
  • nightly-guards / workflow-guard-tests / release-notary: fail. Base finding. The only failure
    is tests/test_ci_signing_owned_mac.py (glaeda hook e94edf9c is not listed); ci(signing): trust glaeda runner hook e94edf9c #28421 fixes it.
    test_digest.py passes on this head.
  • nightly-guards / Guard status: fail. This wrapper follows release-notary.

(cherry picked from commit d4eef12)

Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
@lawrencecchen lawrencecchen changed the title base red: release notes: two fixed highlights link the agents docs (whats-new digest) base red: release-notary: two highlights link the agents docs; trust glaeda hook e94edf9c (combines #28421) Oct 30, 2026
@lawrencecchen lawrencecchen added risk:high Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 30, 2026
@cursor

cursor Bot commented Oct 30, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent review subagent, Claude Opus 5.5): SHIP at b97cab9
reviewer-session: r28441c-7611a14a
author-session: a1c85faf51fad876b
R9: pass. The PR adds no cap, limit or timeout.
perf claim: none

Scope

The diff from the merge-base 49cba34 to the head has 2 commits, 3 files, 3 added lines and 0 removed lines:

  • 6052afece8e1 (already reviewed SHIP at this sha): docs: https://cmux.com/docs/agents in release-notes/next/highlights/chief-name-in-agent-chats.md and release-notes/next/highlights/shell-agent-identity.md. The commit sha did not change.
  • b97cab928b13: one line in scripts/ci/glaeda-signing-hooks.txt (hook e94edf9c, glaeda 444f239a, fix(keyboard): forward unbound Cmd+Shift combinations to terminal #1757).

There is no other file.

Cherry-pick

  • ci(signing): trust glaeda runner hook e94edf9c #28421 has one commit, d4eef129256c24bbee9c1bf7a44ebaa78b5674fa (its head).
  • git diff d4eef129256c^ d4eef129256c and git diff b97cab928b13^ b97cab928b13 are byte-equal (cmp). The patch-id is the same (bc17faee2843...).
  • The author is kept: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>. The message has (cherry picked from commit d4eef129...) and a Co-authored-by: cmux-bot[bot] trailer.

Body

The body starts "Combines #28421 (each red on the other's red)". It names both base reds, the commands, and base and head results. It has ### Observed / Not run, ## Changelog (none) and No capture:. CLAUDE.md tells agents to combine two such fixes in one PR.

Tests (run by this reviewer in clean worktrees)

command base 49cba34 head b97cab9
python3 -I scripts/whats-new/test_digest.py FAILED (failures=1): chief-name-in-agent-chats and shell-agent-identity "need a tryIt" OK (5 tests)
python3 -I scripts/whats-new/test_validate.py not run OK (15 tests)
python3 -I tests/test_ci_signing_owned_mac.py FAILED (failures=1): hook e94edf9c not in glaeda-signing-hooks.txt OK (15 tests)

Findings

  • No blocking finding.
  • Note (not this PR's defect): https://cmux.com/docs/agents gives 404 now. This is a known gap in the base docs site and is in the followups. 22 other highlights use the same link.

checks: on head b97cab9: 47 pass, 0 fail, 0 pending, 54 skipping. nightly-guards / workflow-guard-tests / release-notary passes (job 124211365335, conclusion success, head_sha b97cab9). cmux-next CI guard group passes. There is no red to classify.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Ready to land at b97cab9:

@teamleaderleo

Copy link
Copy Markdown
Collaborator

For awareness: the highlights tryIt base red these fix landed in #28458 (bba1983, same action as #28114), and the signing-hook part in #28421. Your call whether to close.

@lawrencecchen lawrencecchen removed the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 30, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Closing as redundant: feat-cmux-next already has both parts. The highlight links were fixed by #28458 (bba1983) and the glaeda hook trust by #28421 (fd5287b). A merge of feat into this branch leaves an empty diff. release-notary passes at fd5287b (run 41108287821).

This branch was previously deployed

1 inactive deployment
ci-routing-agent — b97cab92 Deployed Oct 30, 2026 by lawrencecchen via cmux-tui tree preflight #84342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants