Repository navigation
base red: release-notary: two highlights link the agents docs; trust glaeda hook e94edf9c (combines #28421) - #28441
lawrencecchen wants to merge 2 commits into
Conversation
…t's New requires chief-name-in-agent-chats.md (#27935) and shell-agent-identity.md (#26627) had neither a tryIt action nor a docs link, so scripts/whats-new/test_digest.py (release-notary guards) failed on every feat-cmux-next commit. Both now link https://cmux.com/docs/agents, the docs page of the agent chat they describe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Review (independent review subagent, Claude Opus 5.5): SHIP at 6052afe ScopeThe diff adds Is
|
(cherry picked from commit d4eef12) Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (independent review subagent, Claude Opus 5.5): SHIP at b97cab9 ScopeThe diff from the merge-base 49cba34 to the head has 2 commits, 3 files, 3 added lines and 0 removed lines:
There is no other file. Cherry-pick
BodyThe body starts "Combines #28421 (each red on the other's red)". It names both base reds, the commands, and base and head results. It has Tests (run by this reviewer in clean worktrees)
Findings
checks: on head b97cab9: 47 pass, 0 fail, 0 pending, 54 skipping. |
|
Ready to land at b97cab9:
|
Combines #28421 (each red on the other's red): release-notary needs both fixes, and each PR alone stays red on the other's check.
Base red on feat-cmux-next: release-notary (
nightly-guards / workflow-guard-tests / release-notary) failspython3 scripts/whats-new/test_digest.py,test_the_repository_highlights_validate, on every recent feat commit:chief-name-in-agent-chats.md(added by 2b01346, cmux NEXT agent chat: a Chief's message shows the Chief's name and avatar (#27914) #27935): "needs a tryIt action/deeplink or a docs link";shell-agent-identity.md(added by 567dcaf, cmux NEXT: keep ambiguous child starts in shell rows #26627): the same.Fix
Both are Fixed entries about agent chats, with no action to try, so each gets the docs link 22 other highlights use:
docs: https://cmux.com/docs/agents(release-notes/next/WRITING.md, "One file per change"). The test and the validator are unchanged.Evidence (the check's own command, run on this branch's base and head)
python3 -I scripts/whats-new/test_digest.pyFAILED (failures=1): both files namedOK(5 tests);scripts/whats-new/test_validate.pyalsoOK2. The glaeda signing hook (from #28421)
tests/test_ci_signing_owned_mac.py(test_every_listed_hook_is_one_glaeda_released_with_the_check) failed: glaeda's newest hooke94edf9cwas not inscripts/ci/glaeda-signing-hooks.txt. HQ's sync PR #28421 (cmux-bot, d4eef12) adds its line. Its one commit is cherry-picked here with-x, author kept.Both checks at the head b97cab9
python3 -I scripts/whats-new/test_digest.pyFAILED (failures=1)OK(5 tests)python3 -I tests/test_ci_signing_owned_mac.pyFAILED (failures=1)(hook e94edf9c not listed)OK(15 tests)R9: no new cap, limit or timeout.
R10: no code change.
Observed / Not run
Changelog
No capture: release-note text only.