fix(quit): state files have one owner each and no quit blocks the main thread on them by lawrencecchen · Pull Request #28275 · manaflow-ai/cmux

test(quit): a second quit signal arms its deadline before it waits on the agent panes' state files

lawrencecchen

committed

82d2f13

fix(quit): state files have one owner each and no quit blocks the main thread on them

lawrencecchen

committed

1869061

refactor(quit): the quit's steps and its engine stop are QuitCoordinator members

lawrencecchen

committed

b976b02

test(quit): a quit through QuitCoordinator waits for a queued draft before it goes on

lawrencecchen

committed

25a49ee

refactor(wakeups): QueueDrain races its queues and its limit through FirstOutcome

lawrencecchen

committed

07f1b95

test seam(quit): AgentPaneStateFiles tells when a drain begins

lawrencecchen

committed

0aaaccd

test(quit): only a drain of the state files lets a held save go; no clock decides the quit tests

lawrencecchen

committed

9355de1

test(quit): the quit tests' services have no key window (no app object in the test process)

lawrencecchen

committed

d77dbff

test(quit): DrainGate and its log are nonisolated (the drain calls them off the main actor)

lawrencecchen

committed

57dfaa1

test(quit): the quit tests make the app object first, and the non-blocking wait has a time limit

lawrencecchen

committed

5807c34

fix(quit): no bare drain limit; the last drain follows the engines' close; a lost draft is named and told

lawrencecchen

committed

c85dcca

fix(quit): a paired-phones save a quit deadline cuts off fails closed, is named and told

lawrencecchen

committed

fb8e185

fix(quit): the loss notice uses the shared toast center inside (its type is not public API here)

lawrencecchen

committed

96a1de8

fix(quit): the deadline's end never calls the Keychain; the next launch clears a cut-off paired seal

lawrencecchen

committed

67afa2c

fix(quit): a cut-off paired save fails closed even when its marker is not written; notices never wait on each other

lawrencecchen

committed

fc54bef

fix(quit): no public default names an internally imported symbol; the launch notice takes a closure

lawrencecchen

committed

e22c234

fix(quit): a launch told only by the record keeps the cut-off fact on disk until its seal clear ends

lawrencecchen

committed

d6f29ce

fix(quit): the record keeps naming a cut-off paired list until the fact is safe; no clock in the removal tests

lawrencecchen

committed

626d97e

Navigation Menu

Repository navigation

fix(quit): state files have one owner each and no quit blocks the main thread on them - #28275

fix(quit): state files have one owner each and no quit blocks the main thread on them#28275
lawrencecchen merged 23 commits into
feat-cmux-nextfrom
fix/arch-rise-quit-flush

Commits on Oct 30, 2026

test(quit): a second quit signal arms its deadline before it waits on the agent panes' state files

fix(quit): state files have one owner each and no quit blocks the main thread on them

refactor(quit): the quit's steps and its engine stop are QuitCoordinator members

test(quit): a quit through QuitCoordinator waits for a queued draft before it goes on

refactor(wakeups): QueueDrain races its queues and its limit through FirstOutcome

test seam(quit): AgentPaneStateFiles tells when a drain begins

test(quit): only a drain of the state files lets a held save go; no clock decides the quit tests

test(quit): the quit tests' services have no key window (no app object in the test process)

test(quit): DrainGate and its log are nonisolated (the drain calls them off the main actor)

test(quit): the quit tests make the app object first, and the non-blocking wait has a time limit

fix(quit): no bare drain limit; the last drain follows the engines' close; a lost draft is named and told

fix(quit): a paired-phones save a quit deadline cuts off fails closed, is named and told

fix(quit): the loss notice uses the shared toast center inside (its type is not public API here)

fix(quit): the deadline's end never calls the Keychain; the next launch clears a cut-off paired seal

fix(quit): a cut-off paired save fails closed even when its marker is not written; notices never wait on each other

fix(quit): no public default names an internally imported symbol; the launch notice takes a closure

fix(quit): a launch told only by the record keeps the cut-off fact on disk until its seal clear ends

fix(quit): the record keeps naming a cut-off paired list until the fact is safe; no clock in the removal tests

Commits on Nov 1, 2026

Merge remote-tracking branch 'origin/feat-cmux-next' into fix/arch-rise-quit-flush

fix(quit): quitSteps takes the quit's choice (endLocalSessions ends with it); PhoneAdmissionStoreTests need no forgetThisRun

test(quit): the test AppServices initializer takes the state files (feat's #28321 test init replaced the one QuitStateFilesTests called)

test(drafts): feat's UnsentDraftTests share one AgentPaneStateFiles per test (the per-app writer registry)

fix(quit): the state-file drain before the engines close is held to the time they do not need