Repository navigation
carry of #27499: repair pulled updater races - #28120
teamleaderleo wants to merge 14 commits into
Conversation
…led build is dropped, never offered
The install click re-reads the feed and the pulled list whether or not found
updates download by themselves (nightly asks before it downloads, so the click
installed whatever was staged first). A newer build or a pulled staged one gives
way and the newest downloads with no second click ("Getting the Newest Build…").
A pulled staged build is dropped quietly and the newest good build downloads; a
pulled running build updates to the newest good one with one line. The "This
Nightly Was Pulled" banner, Wait for the Fix and Roll Back are removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…nnot be cancelled or it is staged again; keep the rollback confirmation's Roll Back string Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…uild Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…ocess Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…uild card; a What's New highlight Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…side the Sendable fetch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
…ls show it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-72a66988b5244633adf9
Carry of #27499: preserve answered feed decisions, protect pulled staged builds when cancellation is unavailable, and hide pulled available builds. Agent-Session: https://cmux.com/deeplink/agent?id=aid-753db3fd73750c115b2d
Default changesThis pull request changes 4 defaults at
Needs a review. It passes with an independent review receipt on this commit: a comment or review whose first line is Regenerate the snapshot with |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Found 10 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Carry of #27499: cmux NEXT updater repair.
This carries the original purpose of #27499 and fixes all three P2 findings from its latest BLOCK review:
Original PR: #27499
No capture: no UI change; updater state behavior only.
Agent-Session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Carries #27499: the cmux NEXT updater installs the newest build and never offers a pulled one.
Restart to Update now re-reads the feed and pulled list on every install click, even when found updates wait for a click to download, so one click installs the newest build instead of whatever was staged first. A pulled build is never installed: a staged pulled build is dropped and the newest good build downloads, and a pulled running build updates to the newest good one. A "Getting the Newest Build…" card shows progress while the replacement downloads. The "This Nightly Was Pulled" banner with Wait for the Fix and Roll Back is removed.
Bug Fixes
No UI capture: updater state behavior only.
Written for commit 3220c6d. Summary will update on new commits.