Repository navigation
fix(next): ActionTrackedWork namespace-type lint red - #28084
Merged
Merged
Conversation
#27104 added `public enum ActionTrackedWork` with an all-static public surface, which the package-conventions namespace-type rule refuses, so the cmux-next convention lint has been red on feat-cmux-next since ae7c57b. Its only member took the registry as its first argument, so it becomes what the lint asks for: an extension on the receiver type. `ActionTrackedWork.effect(registry: r, ...)` is now `r.trackedWorkEffect(...)`, with the same body and the same strong capture of the registry. No behavior changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 07:05 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 07:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Review (codex gpt-6-astra high, router-review): SHIP at 467675b SHIP
|
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the base red in the cmux-next convention lint on feat-cmux-next:
It came in with ae7c57b (#27104), which added
public enum ActionTrackedWorkholding one staticeffect(registry:...). Every PR into feat-cmux-next has shown it since.Change
The lint asks for "an extension on the receiver type or an instantiated value". The function's first argument was the
ActionRegistry, so it becomes an extension onActionRegistry:ActionTrackedWork.effect(registry: r, cancellationFailure: ..., ...)is nowr.trackedWorkEffect(cancellationFailure: ..., ...).run(registry:...)is now the privaterunTrackedWork(...), andAnsweris a file-privateTrackedWorkAnswer.ActionRegistry+TrackedWork.swift, like the otherActionRegistry+*.swiftextensions.CloudHandlers.swift, one inActionEffectTests, three inCloudWorkspaceSetupLifecycleTests.The body is unchanged: the effect still captures the registry strongly, just as the old
registryparameter did, and it keeps the same run scope, refusal capture and cancellation handling. No behavior changes.Verification
scripts/lint-ios-package-conventions.shnow printsOK: no unjustified convention violations.ActionEffectTestsandCloudSignedOutCreationContinuationTestssuites (package-test-lane) run at this head.No capture: no UI changes; this is a rename of a non-visual action helper into an
ActionRegistryextension, and the CloudHandlers edit only updates two call sites.Risk: low. This is a mechanical rename inside one module plus its call sites.
Agent session: agent session
🤖 Generated with Claude Code