Repository navigation
fix(next): CmuxNextAccounts declares its CmuxNextWakeups dependency - #28082
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
a0ee135 made TeamInviteConsentWindow import CmuxNextWakeups without adding it to CmuxNextAccounts' dependencies, so check-package-dependency-lists.py fails on base (an incremental build keeps objects compiled against a stale interface). The check fails at origin/feat-cmux-next and passes with this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7aa94f16aeac121e03bf
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 06:58 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 07:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Review (codex gpt-6-astra high fast, independent review host): SHIP at 5795655 No correctness, regression, crash, data-loss, or test issues found. The change adds the required VERDICT: SHIP |
|
Found 22 test failures on Blacksmith runners: Failures
...and 12 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base red fix. a0ee135 (cmux team invite) made
CmuxNextAccounts/TeamInvite/TeamInviteConsentWindow.swiftimportCmuxNextWakeupswithout declaring it inCmuxNextAccounts' dependencies. So "Package dependency lists sorted", inside the cmux-next checks job, fails on base and on every PR's merge ref. An undeclared import also lets an incremental build keep objects compiled against a stale interface.This adds
CmuxNextWakeupstoCmuxNextAccounts' dependencies.CmuxNextWakeupsdepends only onCmuxNextCompatandCmuxNextSignposts, so there is no cycle.Changelog
none
Observed / Not run
python3 scripts/cmux-next/check-package-dependency-lists.py: exit 1 at origin/feat-cmux-next, exit 0 with this change. Its test script passes, and prepush-gate finds no new violations.risk:low
🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Declares
CmuxNextWakeupsinCmuxNextAccounts' dependencies so the package dependency list check passes on base. The import was added earlier without the dependency declaration, which also let incremental builds compile against stale interfaces. Adding the dependency introduces no cycle, sinceCmuxNextWakeupsdepends only onCmuxNextCompatandCmuxNextSignposts.Written for commit 5795655. Summary will update on new commits.