Skip to content

Home: add spacing above Chief memory pause footnote - #28078

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
lane/cdc-fix-chief-footnote-gap
Oct 30, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
lane/cdc-fix-chief-footnote-gap

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes the spacing above Home's Chief memory pause footnote by applying the existing Home 8-point spacing token to the conversation notice row. This leaves the footnote text, Switching card, colors, and defaults unchanged.

"The "Chief memory summaries are paused" footnote sits flush against the card above it. This is Chief-area code; the extra-care rules apply."

Dry-run runbook:

Home: the "Chief memory summaries are paused" footnote sits flush under the Switching card's bottom edge, clipped-looking.

Root cause

The shared Home transcript layout emitted the conversation notice row with gap: 0, so the paused-memory footnote started directly at the preceding Switching card's bottom edge.

Fix

The conversation notice row now uses gap: 8, matching the existing Home spacing token used by the status notice. The focused test asserts that the paused-memory footnote receives this gap.

Chief area: extra care

Changed paths are Home transcript layout and its Home status test. Lawrence Chen is the selected teammate owner: git history for the last 30 days shows 40 commits on the changed Home layout path and 16 on the focused test path, more than any other teammate. I will request Lawrence Chen as reviewer and add an awareness comment.

Risk

Low and localized: this changes only the vertical gap before the Home conversation footnote row. It does not change text, card layout, colors, behavior, or defaults.

Tests

  • Focused regression: HomeTurnStatusTests.theChiefFootnoteHasHomeSpacingUnderTheSwitchingCard asserts the paused-memory notice row gap is 8.
  • Expected red at base: the new regression assertion fails because the base row gap is 0.
  • Expected green at head: the same assertion passes with the 8-point fix.
  • Fleet package test pending: MessagesLabHomeTests.

Captures

Fleet capture state committed at scripts/cmux-next/media/states/chief-footnote-gap.json; base and head light/dark captures are pending the fleet capture helper. Before is the base layout with the footnote flush to the Switching card; after is the head layout with visible 8-point space.

Changelog

Fixed: Home's Chief memory pause footnote now has visible space below the Switching card.

Agent session: agent session

@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 651b20c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28078 -f ref=lane/cdc-fix-chief-footnote-gap -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 438ece0 to compare; do not merge until green; see lane-rules

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41071509570 at a6ca7ea failed: cmux-next generated files (shared build).
Those jobs last passed at 8e867c5. This pull request is one of 5 merged since: #28088, #27811, #27892, #28349, #28078.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Chief area awareness: Lawrence Chen is requested as reviewer because git history for the last 30 days shows 40 commits on the changed Home layout path and 16 on the focused test path, the most of any teammate. The fix changes only the Home conversation notice gap from 0 to the existing 8-point spacing token.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Capture investigation: the paused-memory footnote is produced only when the Chief host observes $MUX_HOME/state/compactor.json, which optchat-chief writes from its live compactor fault path. There is no supported capture RPC, CLI command, or debug toggle to create that state; the capture scene registry only seeds the fresh Home page and does not expose compactor fault injection. The committed unit regression is therefore the deterministic proof: HomeTurnStatusTests.theChiefFootnoteHasHomeSpacingUnderTheSwitchingCard passes at head and is absent on base.

I also retried gh pr edit --add-reviewer lawrencecchen; this lane VM's broker rejects reviewer flags, so the request still needs to be made from a GitHub-capable host.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at 651b20c

No blocking findings.

cmux-bot[bot]
cmux-bot Bot previously approved these changes Oct 30, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 651b20c: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@cursor

cursor Bot commented Oct 30, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cmux-bot
cmux-bot Bot dismissed their stale review October 30, 2026 12:46

A newer verdict blocks 2c282d4 (no independent SHIP at the head).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at 2c282d4

The independent SHIP at 651b20c carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (45cb3bc8d537106a) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 2c282d48 Deployed Oct 30, 2026 by teamleaderleo via cmux-tui tree preflight #83056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant