Repository navigation
Home: add spacing above Chief memory pause footnote - #28078
Conversation
|
Found 2 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 438ece0 to compare; do not merge until green; see lane-rules The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41071509570 at a6ca7ea failed: cmux-next generated files (shared build). |
|
Owned by an agent session · session |
|
Chief area awareness: Lawrence Chen is requested as reviewer because git history for the last 30 days shows 40 commits on the changed Home layout path and 16 on the focused test path, the most of any teammate. The fix changes only the Home conversation notice gap from 0 to the existing 8-point spacing token. |
|
Capture investigation: the paused-memory footnote is produced only when the Chief host observes I also retried |
|
Review (codex gpt-6-astra high, next-review): SHIP at 651b20c No blocking findings. |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
A newer verdict blocks 2c282d4 (no independent SHIP at the head).
|
Review (next-review patch-id; carried): SHIP at 2c282d4 The independent SHIP at 651b20c carries to this head: the PR's own change ( |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Fixes the spacing above Home's Chief memory pause footnote by applying the existing Home 8-point spacing token to the conversation notice row. This leaves the footnote text, Switching card, colors, and defaults unchanged.
Dry-run runbook:
Root cause
The shared Home transcript layout emitted the conversation notice row with
gap: 0, so the paused-memory footnote started directly at the preceding Switching card's bottom edge.Fix
The conversation notice row now uses
gap: 8, matching the existing Home spacing token used by the status notice. The focused test asserts that the paused-memory footnote receives this gap.Chief area: extra care
Changed paths are Home transcript layout and its Home status test. Lawrence Chen is the selected teammate owner: git history for the last 30 days shows 40 commits on the changed Home layout path and 16 on the focused test path, more than any other teammate. I will request Lawrence Chen as reviewer and add an awareness comment.
Risk
Low and localized: this changes only the vertical gap before the Home conversation footnote row. It does not change text, card layout, colors, behavior, or defaults.
Tests
HomeTurnStatusTests.theChiefFootnoteHasHomeSpacingUnderTheSwitchingCardasserts the paused-memory notice row gap is 8.MessagesLabHomeTests.Captures
Fleet capture state committed at
scripts/cmux-next/media/states/chief-footnote-gap.json; base and head light/dark captures are pending the fleet capture helper. Before is the base layout with the footnote flush to the Switching card; after is the head layout with visible 8-point space.Changelog
Fixed: Home's Chief memory pause footnote now has visible space below the Switching card.
Agent session: agent session