fix(cmux-next): VNC reconnect test helpers are nonisolated (CmuxNextAppTests compile red) by teamleaderleo · Pull Request #27862 · manaflow-ai/cmux

teamleaderleo · 2026-10-30T02:41:45Z

#26557 landed RemoteVNCReconnectTests (carried from #26697). Under the CmuxNext test target's .defaultIsolation(MainActor.self), the private AttemptCounter is main-actor isolated, so the @Sendable transport factory cannot call increment():

RemoteViewVNCTests.swift:130:22: error: call to main actor-isolated instance method 'increment()' in a synchronous nonisolated context

CmuxNextAppTests does not compile on feat-cmux-next at 0ce3c31, so every CmuxNext suite run fails at build. This marks the two lock-guarded test helpers nonisolated, as #27811 already writes them (that PR now conflicts with base). Two lines, tests only.

Observed / Not run

Fleet focused run at feat-cmux-next 57b38a2-based head: test target fails to compile with the error above.
Fleet focused run at this head (RemoteVNCReconnectTests, RemoteVNCMappingTests, PaneTabBarControlsTests, NewTabMenuTriggerTests): result posted in a comment below.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Fixes the CmuxNextAppTests compile failure on feat-cmux-next by marking two VNC reconnect test helpers as nonisolated.

Under the test target's MainActor default isolation, the @Sendable transport factory could not call AttemptCounter.increment(), breaking the build for every CmuxNext suite run. The lock-guarded CountingRFBTransport and AttemptCounter helpers are now nonisolated; test behavior is unchanged.

^{Written for commit 4a4c593. Summary will update on new commits.}

…et compile red) #26557 added RemoteVNCReconnectTests; under the test target's MainActor default isolation, AttemptCounter.increment() is main-actor isolated and the @sendable transport factory cannot call it, so CmuxNextAppTests does not compile on feat-cmux-next. Both lock-guarded helpers are nonisolated, as #27811 already writes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo · 2026-10-30T02:42:00Z

Owned by an agent session · session

github-actions · 2026-10-30T02:44:33Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 4a4c593: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27862 -f ref=fix-vnc-test-isolation -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 4a4c593e20; ci-status is green without them.

CI passes on 4a4c593e20 (run 40993713808 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c033155 to compare; do not merge until green; see lane-rules

teamleaderleo · 2026-10-30T02:47:14Z

Review (codex gpt-6-astra high fast, independent box): SHIP at 4a4c593

SHIP

No findings. Both helpers safely support nonisolated access: the transport is stateless, and the counter protects all mutable state with a lock.

Tests could not run because Swift is unavailable.

teamleaderleo · 2026-10-30T02:47:18Z

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 4a4c593

SHIP

No findings. Both helpers safely support nonisolated access: the transport is stateless, and the counter protects all mutable state with a lock.

Tests could not run because Swift is unavailable.

blacksmith-sh · 2026-10-30T02:47:26Z

Found 8 test failures on Blacksmith runners:

Failures

Test	View Logs
`--from must install a complete prebuilt tree/` `--from must install a complete prebuilt tree`	View Logs
`/tmp/tmpiz6yg9qa/summary-missing.json (live):/summary-missing.json (live):`	View Logs
`/tmp/tmpo1kfruxo/summary-fail.json (live):/summary-fail.json (live):`	View Logs
`[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/` `[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows`	View Logs
`[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames`	View Logs
`[tabs] debug.tab_switch timed 0 of 40 switches/` `[tabs] debug.tab_switch timed 0 of 40 switches`	View Logs
`[tabs] the window draws no frames/[tabs] the window draws no frames`	View Logs
`test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt` `epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/` `test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt` `epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

cmux-bot

cmux-bot approves 4a4c593: an independent review passed this exact head (review box review-27862-4a4c receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

teamleaderleo · 2026-10-30T02:58:19Z

Fleet focused run at 4a4c593 (step fc0c7d0c99ce6df26bc51880): RemoteVNCReconnectTests, RemoteVNCMappingTests, PaneTabBarControlsTests and NewTabMenuTriggerTests all passed. On current feat-cmux-next the same test target does not compile (RemoteViewVNCTests.swift:130:22, a call to main actor-isolated 'increment()'; step 7e6da2ca3ec136fbda9cad5c). The 'cmux-next checks' and release-notary reds here also fail on base e430ffd; prepush-gate on this commit reports no new violations.

github-actions · 2026-10-30T03:00:28Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40994392464 at b0b87c9 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 7c1b653. This pull request is one of 1 merged since: #27862.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

#27862 made the old test's helpers nonisolated; this branch replaces that test with the stronger one, whose helpers already are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b22822edaca3611659c9

github-actions · 2026-10-30T04:26:42Z

Shipped in:

cmux NEXT nightly 1.0.0-nightly.4099795415801 (a14725a01e)

github-actions · 2026-10-30T04:29:24Z

Shipped in:

cmux NEXT nightly 1.0.0-nightly.4099849490201 (9d89be8865)
cmux NEXT nightly 1.0.0-nightly.4100000843001 (e58eb649c8)
cmux NEXT nightly 1.0.0-nightly.4100052035301 (1cde021b9e)

…ice 1 merge seam) Slice 1 switch/conflict review (2026-10-30), finding 1: feat's tests merged without a text conflict but call APIs perf changed, so CmuxNextAppTests does not compile. - PaneTabBarControlsTests: TabStripView.testing(model:) (perf makes input: required) and strip.scroller.settle() (perf moved feat's settleScroll() into TabStripScroller.settle(), the same body). - RemoteViewVNCTests (#27862): RemoteVNCSession(cloudRecord:makeTransport:) now also takes perf's work:, mainWork: and signIns:; the test passes its own lane, scheduler and in-memory sign-ins, as RemoteVNCSignInReadTests does. No assertion changes. Proof: the fleet compile of CmuxNextAppTests on this head.

teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026

teamleaderleo temporarily deployed to ci-routing-agent October 30, 2026 02:41 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to ci-routing-agent October 30, 2026 02:43 — with GitHub Actions Inactive

teamleaderleo removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026

cmux-bot Bot approved these changes Oct 30, 2026

View reviewed changes

github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026

teamleaderleo merged commit b0b87c9 into feat-cmux-next Oct 30, 2026
175 of 192 checks passed

teamleaderleo deleted the fix-vnc-test-isolation branch October 30, 2026 02:54

austinywang mentioned this pull request Oct 30, 2026

cmux NEXT browser: a page under a hidden ancestor takes no focus (focus loop hang) #27873

Merged

teamleaderleo mentioned this pull request Oct 30, 2026

[ask-2663fecb03] Add a separate pane-type chevron beside the plain plus #27004

Merged

austinywang added a commit that referenced this pull request Oct 30, 2026

side: carry #27862 VNC test compile fix for the green run

e582a89

austinywang mentioned this pull request Oct 30, 2026

cmux NEXT: palette search field and rows grow with large text (Fixes #26606) #26621

Merged

austinywang mentioned this pull request Oct 30, 2026

Fixes #25675 #25703

Merged

teamleaderleo mentioned this pull request Oct 30, 2026

cmux NEXT: the workspace row copies its link before its ID, and a test that the link opens it #27564

Merged

teamleaderleo mentioned this pull request Oct 30, 2026

fix(cloud): resume New Cloud Machine after sign-in once #27104

Merged

Navigation Menu

Repository navigation

fix(cmux-next): VNC reconnect test helpers are nonisolated (CmuxNextAppTests compile red) - #27862

fix(cmux-next): VNC reconnect test helpers are nonisolated (CmuxNextAppTests compile red)#27862
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix-vnc-test-isolation

teamleaderleo commented Oct 30, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 •

edited by cmux-bot Bot

Loading

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

blacksmith-sh Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

cmux-bot Bot left a comment

Uh oh!

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 30, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Observed / Not run

Changelog

Summary by cubic

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited by cmux-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

blacksmith-sh Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

cmux-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

teamleaderleo commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 30, 2026 •

edited by cubic-dev-ai Bot

Loading

github-actions Bot commented Oct 30, 2026 •

edited by cmux-bot Bot

Loading

blacksmith-sh Bot commented Oct 30, 2026 •

edited

Loading

github-actions Bot commented Oct 30, 2026 •

edited

Loading