Skip to content

test(next): prove multi-view split drags keep focus and visible rows lit - #27845

Merged
cmux-bot[bot] merged 8 commits into
feat-cmux-nextfrom
lane/sidebar-visible-workspaces
Nov 1, 2026
Merged

cmux-bot[bot] merged 8 commits into
feat-cmux-nextfrom
lane/sidebar-visible-workspaces

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Private design-reference comparison: done.

Leo’s item D prototype is already present on feat-cmux-next through the merged multi-view work (#23437, #23651, #24067): sidebar.multiView remains off by default; mouse-down does not navigate, mouse-up on the same row does; the window remembers its visible workspace set; workspace rows use the existing pane drop overlay; and a pane-edge drop keeps the current focus.

This first commit adds the missing real-window, per-frame regression:

  • hold and drag a sidebar workspace toward a split edge;
  • while the drag is held, the focused workspace stays focused;
  • every workspace already in the view remains highlighted (focused row strong, other visible rows soft);
  • the existing pane drop overlay shows its split indicator;
  • releasing adds the workspace to the current view without changing focus or dropping visible-row highlights.

Leo’s words:

“do the Claude Code desktop multi-view better”

and:

“MOUSE DOWN DRAGGING ... SHOULDN'T BE IMMEDIATELY FOCUSING”

Before / after captures

These are the existing item-D dogfood captures for the behavior this test protects:

Before (toggle off) After (multi-view toggle on)
light · dark light · dark

Validation

  • git diff --check passed.
  • Focused fleet test still required at this exact head: SidebarMultiViewDropTests / SidebarMultiViewWindowTests on a GUI-capable Mac.
  • Exact-head Astra high/fast review still required at 4726064.
  • No production overlay was added; the test asserts the existing LayoutRootView drop overlay.

This is a draft until the focused fleet check and exact-head independent review are recorded.

agent-identity footer --repo manaflow-ai/cmux
Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds a real-window regression test proving a multi-view sidebar drag keeps the focused workspace focused and every visible row lit for the whole drag, then joins the dragged workspace into the view on drop without moving focus.

Also fixes the test's highlight assertion: litRows now counts the soft fill of a workspace on screen beside the focused one (via WorkspaceRowView.isOnScreen), which SidebarPointerGestureTests.filledRows alone missed.

Written for commit 8305d2b. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 8305d2b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27845 -f ref=lane/sidebar-visible-workspaces -f platform=macos -f backend_mode=local

web and size checks: green

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6.1-sol xhigh, router-review): BLOCK at 4726064

BLOCK at 4726064

Visual verdict: no images; Leo tries the build

  1. [P1] [blocking] The fill assertion cannot recognize multi-view highlights — Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/SidebarMultiViewDropTests.swift:41 (also lines 57 and 67). SidebarPointerGestureTests.filledRows checks only isSelected, isSecondarySelected, and isDropTarget; the visible companion row uses isOnScreen for its soft fill. Thus the first assertion sees only k0 and the new test fails before testing the split preview. Include isOnScreen in the helper or assert that property directly.

Follow-ups: none

Leo Li and others added 2 commits November 1, 2026 03:36
…w highlights

SidebarPointerGestureTests.filledRows only sees selection-colored fills; the workspace shown beside the
focused one draws its soft fill through isOnScreen, so the split-drag test could never see k1 lit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo marked this pull request as ready for review November 1, 2026 03:36
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at f385485

Reviewer: codex gpt-6-astra high, fast tier.

Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward.

SHIP at f385485

Visual verdict: no images; Leo tries the build

  1. [P2] [follow-up] No after screenshot artifact was provided (review/images/README.txt:1), so visual comparison was unavailable.

Follow-ups:

  • [P2] [follow-up] No after screenshots available for visual validation.

cmux-bot[bot]
cmux-bot Bot previously approved these changes Nov 1, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves f385485: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cmux-bot
cmux-bot Bot dismissed their stale review November 1, 2026 05:21

A newer verdict blocks 5f594b8 (no independent SHIP at the head).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (carry): SHIP at 5f594b8 (base merge only since f385485; patch-id unchanged)

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 09:44 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 09:44 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 09:45 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at 7c6960b

The independent SHIP at f385485 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (7c61b1de559ef676) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 11:47 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 11:47 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 11:47 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at 95a4a76

The independent SHIP at f385485 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (7c61b1de559ef676) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@cursor

cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 16:37 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 16:37 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (next-review patch-id; carried): SHIP at fc2ef0d

The independent SHIP at f385485 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (7c61b1de559ef676) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.

@cursor

cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 18:41 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 18:41 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 1, 2026 18:42 Inactive
@cmux-bot
cmux-bot Bot merged commit 2b962c6 into feat-cmux-next Nov 1, 2026
161 of 165 checks passed
@cmux-bot
cmux-bot Bot deleted the lane/sidebar-visible-workspaces branch November 1, 2026 18:53
teamleaderleo added a commit that referenced this pull request Nov 2, 2026
…tion repaint the fills (#31564)

The sidebar repaints on-screen row fills from its observation task, a MainActor turn after
SidebarModel.onScreen changes; the last check of #27845's test read litRows in the same turn
as the drop. It now gives that task bounded turns before checking.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 8305d2bd Deployed Nov 1, 2026 by cmux-bot[bot] via wait for same-key tree publisher #97169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant