Repository navigation
test(next): prove multi-view split drags keep focus and visible rows lit - #27845
Conversation
|
Found 1 test failure on Blacksmith runners: Failure
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Shipped in:
|
|
Owned by an agent session · session |
|
Review (codex gpt-6.1-sol xhigh, router-review): BLOCK at 4726064 BLOCK at 4726064 Visual verdict: no images; Leo tries the build
Follow-ups: none |
…w highlights SidebarPointerGestureTests.filledRows only sees selection-colored fills; the workspace shown beside the focused one draws its soft fill through isOnScreen, so the split-drag test could never see k1 lit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review (codex, router-review): SHIP at f385485 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at f385485 Visual verdict: no images; Leo tries the build
Follow-ups:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A newer verdict blocks 5f594b8 (no independent SHIP at the head).
|
Review (next-review patch-id; carried): SHIP at 7c6960b The independent SHIP at f385485 carries to this head: the PR's own change ( |
|
Review (next-review patch-id; carried): SHIP at 95a4a76 The independent SHIP at f385485 carries to this head: the PR's own change ( |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (next-review patch-id; carried): SHIP at fc2ef0d The independent SHIP at f385485 carries to this head: the PR's own change ( |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…tion repaint the fills (#31564) The sidebar repaints on-screen row fills from its observation task, a MainActor turn after SidebarModel.onScreen changes; the last check of #27845's test read litRows in the same turn as the drop. It now gives that task bounded turns before checking. Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Private design-reference comparison: done.
Leo’s item D prototype is already present on feat-cmux-next through the merged multi-view work (#23437, #23651, #24067): sidebar.multiView remains off by default; mouse-down does not navigate, mouse-up on the same row does; the window remembers its visible workspace set; workspace rows use the existing pane drop overlay; and a pane-edge drop keeps the current focus.
This first commit adds the missing real-window, per-frame regression:
Leo’s words:
and:
Before / after captures
These are the existing item-D dogfood captures for the behavior this test protects:
Validation
This is a draft until the focused fleet check and exact-head independent review are recorded.
agent-identity footer --repo manaflow-ai/cmux
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds a real-window regression test proving a multi-view sidebar drag keeps the focused workspace focused and every visible row lit for the whole drag, then joins the dragged workspace into the view on drop without moving focus.
Also fixes the test's highlight assertion:
litRowsnow counts the soft fill of a workspace on screen beside the focused one (viaWorkspaceRowView.isOnScreen), whichSidebarPointerGestureTests.filledRowsalone missed.Written for commit 8305d2b. Summary will update on new commits.