Repository navigation
fix(api): require mutation grants for GitHub write tokens - #27828
Conversation
|
Found 1 test failure on Blacksmith runners: Failure
|
Hosted regression at 1619275: github-token.test.ts has 7 passing cases and read-only write failing (200 vs 403), run 40990137138. Preserve VM writes behind the live-machine ownership gate. Agent-Session: https://cmux.com/deeplink/agent?id=aid-7b191c38902b8b818181
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 204474a SHIP
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41070142155 at 99e8529 failed: cmux-next generated files (shared build). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
GitHub token minting now enforces the install grant before any token cache lookup or provider mint. Every non-VM install request requires
read; any requested GitHubwritepermission also requiresmutate-own. The VM path retains its existing live-machine ownership check and write access, so no existing caller loses write.Leo's request:
Verification:
1619275f5b3a4d40116d4cc9be64a8e59e9b660c:github-token.test.tshad 7 passing cases and 1 failure because a read-only grant received HTTP 200 for a mixed read/write request (run 40990137138).204474add9ff59a6ae0152b0829a5143a5807b63: all 8github-token.test.tscases passed (run 40991900571).Review (codex gpt-6-astra): SHIP at 204474add9ff59a6ae0152b0829a5143a5807b63.release-notaryandGuard statusfailures are base failures; the changed backend test and typecheck are green.Changelog
Fixed GitHub write token requests exceeding an install's grant.
Agent session: agent session