Repository navigation
fix(sidebar): unify pinned hover geometry on the drawn pill - #27585
Merged
Merged
Conversation
Sidebar-Look: no visual change; regression coverage for Leo’s workspace preview gap. Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0e2e06c2fc61fa2b914
Sidebar-Look: Leo: "the gap between the hover preview and ... the workspace sidebar element thingy". Touch the row before the drag-out thumb; snap inward so fractional edges leave no seam. Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0e2e06c2fc61fa2b914
Sidebar-Look: no visual change; align pointer escape with the new drawn-fill placement. Exercise vertical dismissal on the list side, outside the now-flush preview. Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0e2e06c2fc61fa2b914
Preserve the row-fill and pinned-pill no-gap anchors while retaining current-base hover sweep behavior. Sidebar-Look: no visual change from the reviewed preview placement fix Agent-Session: https://cmux.com/deeplink/agent?id=aid-acedf8848325f4f883bb
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 21:04 — with
GitHub Actions
Inactive
Check actual panel placement and following against the narrower drawn pill, with exact escape anchors. Allow the screen clamp to choose the panel top. Require the shared list anchor to use the same pill. Agent-Session: https://cmux.com/deeplink/agent?id=aid-3b3e9f142f8f98e4f658
Use the drawn pill for the workspace anchor and delegate its hover band to the same geometry. Exact-head tracing shows the controller already used the pill band for panel placement and following; this removes the stale cell-bounds helper and adds actual-panel coverage in the preceding commit. Sidebar-Look: no visual change Agent-Session: https://cmux.com/deeplink/agent?id=aid-3b3e9f142f8f98e4f658
teamleaderleo
force-pushed
the
lane/fix-26942-pill-panel-frame
branch
from
October 29, 2026 21:14
5a4c266 to
5f7a6f7
Compare
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 21:14 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 4400b7a to compare; do not merge until green; see lane-rules |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 21:38 — with
GitHub Actions
Inactive
teamleaderleo
marked this pull request as ready for review
October 29, 2026 21:41
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 21:41 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 21:43 — with
GitHub Actions
Inactive
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned workspace geometry still exposed two different anchors: the drawn pill for the card controller and the full layout cell from the shared list helper. The list anchor now returns the pill, and the hover band delegates to it. A regression checks the actual
panel.cardFrameagainst the pill’s trailing edge on show and after the pill moves, including the panel’s exact escape anchor. Screen clamping may determine the panel’s top.Requested scope:
Started from exactly
d3f0e0762a994eb63ff5cac70cb0d191e05775ce; resolved heade2fc6cd278cc7d9d77b9549e7352b0064ac05d14. The product delta is two files, 29 additions and 7 deletions; the pushed head is a normal merge oforigin/feat-cmux-nextat4400b7aaeff30033fd6aeebc5be288218ce488d7. This branch carries the original #26942 commits because the requested starting head is retained.Source tracing at that starting head found that the controller already supplied the pill to both
panel.presentandpanel.follow. The contradictory list helper and its incomplete test are the changes here; this PR does not claim a reproduced panel-placement failure at that head.Verification
Focused fleet command:
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref SHA --arg=suite --arg=Packages/macOS/CmuxNext --arg=PinnedRowHoverCardTests --env CMUX_TEST_REQUIRE_GUI=1 --label gui-session-v1 --key KEY.ba1a6ba4100937f7ac16e39e05c3725f2fd73bee: fleet job8f54b51318b2ea42cb143786completed with exit 1; 5 tests executed with one expected failure atPinnedRowHoverCardTests.swift:123, where the shared anchor used cell bounds instead of the drawn pill.5f7a6f7048a3602d7691de7fdeeb1fdb28f1b50b: fleet job321e9ae0652a2f7a0845bfaepassed all 5 tests with identical test source, includingthePanelFollowsThePinnedPill(exit 0).e2fc6cd278cc7d9d77b9549e7352b0064ac05d14: exact-head focused fleet jobd8a0c839f28441caa41f9ac5is submitted after the normal base merge; it is queued while the refreshed head checks run.git diff --checkandpython3 scripts/cmux-next/prepush-gate.py --base d3f0e0762a994eb63ff5cac70cb0d191e05775cepassed with no new violations.5f7a6f7048a3602d7691de7fdeeb1fdb28f1b50b, complete two-file delta plus coordinator/panel paths; no correctness findings.Observed / Not run
Native package test compilation and all 5 focused tests passed on the pre-merge head through the fleet. Old-source comparison job
8f54b51318b2ea42cb143786is terminal RED (exit 1) atPinnedRowHoverCardTests.swift:123: the shared anchor was(200.0, 244.0, 240.0, 24.0)while the drawn pill was(206.0, 244.0, 228.0, 24.0). The identical pre-merge test passed all 5 tests in job321e9ae0652a2f7a0845bfae. Resolved-head jobd8a0c839f28441caa41f9ac5is queued; the PR head checks have refreshed with 34 passed, 0 failed and no required failures. Static verification ran; localization reports existing catalog debt and this VM has noswiftc. An independent source review confirmed that actual panel placement at the requested starting head already used the pill.No capture: this consolidates equivalent placement paths and corrects the unused cell-bounds helper without changing the currently drawn panel. The actual panel regression provides geometry evidence; no before/after screenshot is presented as evidence of a visual change.
Risk: the shared pinned-row anchor now describes the drawn fill. Listed workspace and group anchor behavior is preserved.
Changelog
Fixed: Pinned workspace hover-card geometry uses one drawn-pill anchor, with coverage of actual panel placement and following.
Agent session: agent session