Repository navigation
fix: preserve the motion gate for popover animation expressions - #27494
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c230bb5 to compare; do not merge until green; see lane-rules |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Bead |
|
Shipped in:
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40932218191 at f282b73 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
Preserve the continuation-aware popover Motion guard from #27494 alongside the popup entrance ban. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d67683eca2ffed7eb61f
Popover animation assignments such as
popover.animates = flagmust still go through a Motion gate. This preserves the broad assignment guard and exempts only the explicitfalseliteral, including a trailing statement or closing block. Variables, comparisons, andfalse || flagremain rejected.Follow-up to the nonblocking P3 review finding on #27136. Leo’s requirement: “You click, you get a response, period. Everything. Every single f***ing instance.” This guard can land independently; #27136 must preserve it when integrating the updated base.
Validation at exact source
9834c685f6e5383a0015b3ce32eadd21220dac55:The false exemption checks the next significant Swift line, so
falsefollowed by|| flag, a type check or member access remains rejected. This also closes the multiline hole identified during the follow-up review.No capture: this changes the source guard and executable shell fixtures only.
Agent session: agent session