Skip to content

fix: preserve the motion gate for popover animation expressions - #27494

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
codex/popover-animates-guard
Oct 29, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
codex/popover-animates-guard

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Popover animation assignments such as popover.animates = flag must still go through a Motion gate. This preserves the broad assignment guard and exempts only the explicit false literal, including a trailing statement or closing block. Variables, comparisons, and false || flag remain rejected.

Follow-up to the nonblocking P3 review finding on #27136. Leo’s requirement: “You click, you get a response, period. Everything. Every single f***ing instance.” This guard can land independently; #27136 must preserve it when integrating the updated base.

Validation at exact source 9834c685f6e5383a0015b3ce32eadd21220dac55:

  • Managed Linux red/green run 40931154661 passed. Replaying the preceding guard fails the new multiline fixture as intended; the repaired guard passes the complete shell suite, shell syntax and diff checks.
  • Independent Codex gpt-6-astra HIGH/FAST review of the full own diff: SHIP at this exact head. The reviewer also ran the regression suite and the guard against the real CmuxNext package; both passed.

The false exemption checks the next significant Swift line, so false followed by || flag, a type check or member access remains rejected. This also closes the multiline hole identified during the follow-up review.

No capture: this changes the source guard and executable shell fixtures only.

Agent session: agent session

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 9834c68: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27494 -f ref=codex/popover-animates-guard -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c230bb5 to compare; do not merge until green; see lane-rules

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-8w08jk created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit f282b73 into feat-cmux-next Oct 29, 2026
142 of 144 checks passed
@teamleaderleo
teamleaderleo deleted the codex/popover-animates-guard branch October 29, 2026 18:35
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40932218191 at f282b73 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at e8dc026. This pull request is one of 1 merged since: #27494.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

teamleaderleo added a commit that referenced this pull request Oct 29, 2026
Preserve the continuation-aware popover Motion guard from #27494 alongside the popup entrance ban.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-d67683eca2ffed7eb61f

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 9834c685 Deployed Oct 29, 2026 by teamleaderleo via cmux-tui tree preflight #77737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant