Repository navigation
acpmux: regenerate the protocol IR for the machine consent methods (base red) - #27438
Conversation
…ase red) #27216 registered `_acpmux/machine_consent_set`, `_acpmux/machine_consent_get` and `_acpmux/machine_consent_refused` without refreshing spec/acpmux-protocol.json, so `protocol::tests::protocol_ir_is_current` fails on every lib run. Regenerated with ACPMUX_PROTOCOL_BLESS=1, then `bun run acpmux-protocol:codegen` for the web method catalog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 5889445; does not block Gallery before/after for
States
Pick other states with a |
|
Owned by an agent session · session |
|
Found 7 test failures on Blacksmith runners: Failures
|
|
Bead |
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (gpt-6-astra, high, fast; independent Codex reviewer): SHIP at 0b15beb
No correctness findings. Only the two expected generated files change. All three methods appear in registry order (set, get, refused), with matching untyped request shapes in the JSON IR, the TypeScript interface and the method catalog. Nothing is missing and nothing unrelated changed.
Reds at this head, all base reds that fail the same way on feat-cmux-next, none this PR's:
cmux-tui SDKs / protocol contractandcmux-tui spec inventory / inventory: test_irtest_live_raw_v12_layout_and_history_contracts_are_exact, command new-pane-right.cmux-next checks: No new SwiftUI.
|
Shipped in:
|
…ux (#27599) * ci(cmux-tui-spec): run acpmux's protocol tests on PRs that touch acpmux spec/acpmux-protocol.json is generated from acpmux's protocol registry, but only the dispatch-only cmux-tui.yml ran protocol_ir_is_current, so #27050 and the machine consent methods left a stale IR on base until #27556 and #27438 regenerated it. A new acpmux-protocol-ir job in cmux-tui-spec.yml (already path-filtered to cmux-tui/**) runs `cargo test -p acpmux --lib -- protocol::` when the change touches the acpmux crate, the cmux-tui manifest, lockfile or toolchain, and skips the build otherwise. Lib target only, on Blacksmith 32 vCPU, with its own cargo cache saved from feat-cmux-next pushes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a * ci(cmux-tui-spec): quote the acpmux test step's name (a trailing :: is YAML) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a * ci(cmux-tui-spec): the acpmux scope diff lists both sides of a rename Moving the IR out of the crate reported only the new path, which the scope missed, so the job skipped while protocol_ir_is_current would fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes a base red.
protocol::tests::protocol_ir_is_currentfails on everycargo test -p acpmux --librun on feat-cmux-next (60 of 60 in our runs at 13531e3): "spec/acpmux-protocol.json is stale". Never blocked.Cause
#27216 registered
_acpmux/machine_consent_set,_acpmux/machine_consent_getand_acpmux/machine_consent_refusedin the protocol registry. It did not refresh the committed IR or the web method catalog generated from it.Fix
Regenerated, with no hand edits:
ACPMUX_PROTOCOL_BLESS=1 cargo test -p acpmux --lib -- --exact protocol::tests::protocol_ir_is_currentbun run acpmux-protocol:codegeninwebviewsOnly the three new methods appear, in the IR and in
generated/methods.ts. They are untyped (params: unknown), like theirpair_*neighbours.Evidence (Linux,
cmux-ci test)protocol_ir_is_currentcargo test -p acpmux --lib -- protocol::andbun run acpmux-protocol:checkNo capture: generated protocol catalog only; no UI renders differently.
Risk: none at runtime. These are generated files only.
Agent session: agent session
🤖 Generated with Claude Code