Skip to content

ci: export xcresult attachments in cmux-next-ios-sim evidence - #27379

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ios-ci-2/ui-attachments
Oct 29, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ios-ci-2/ui-attachments

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

scripts/ci/cmux-next-ios-sim.sh keeps each xcresult's log, console, tests.json and counts, but not its attachments. A UI test's keepAlways screenshots (for example #27372's AgentChatJumpCaptureUITests) stay inside the bundle, and the evidence zip never carries them, so a UI capture step comes back with no images.

keep_test_logs now also runs xcrun xcresulttool export attachments into $out/<name>-attachments/ (the screenshots plus the manifest.json that maps each file to its test). It applies to both the kit and UI bundles. Like the other xcresulttool calls there it is || true, so a bundle with no attachments, or a failed export, changes nothing else.

Risk: low. The change is CI-script only, adds 4 lines and changes no test selection or exit status. The step's zip gets bigger by the size of the attachments.

Checked: bash -n; xcresulttool export attachments --help matches the flags used (--path, --output-path).

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Exports xcresult attachments in cmux-next-ios-sim CI evidence so UI test screenshots (like keepAlways captures) reach the evidence zip.

  • A new xcrun xcresulttool export attachments call writes the files plus manifest.json to $out/<name>-attachments/ for both kit and UI bundles.
  • The export is || true like other xcresulttool calls, so bundles with no attachments or failed exports don't change anything else; the zip just grows by the size of the attachments.

Written for commit 37386bd. Summary will update on new commits.

View guided diff Turn on auto-fix

UI tests' keepAlways screenshots stayed inside the xcresult bundle, which the
evidence zip never carried. keep_test_logs now exports them (and their
manifest.json) to $out/<name>-attachments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-6dfe06dae30c0577029f
@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 37386bd: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27379 -f ref=ios-ci-2/ui-attachments -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-pkpsq5 created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 33dff86 into feat-cmux-next Oct 29, 2026
150 of 156 checks passed
@teamleaderleo
teamleaderleo deleted the ios-ci-2/ui-attachments branch October 29, 2026 11:10
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40863444386 at e85bfbd failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files.
Those jobs last passed at 3aae968. This pull request is one of 4 merged since: #27377, #27390, #27379, #27220.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

3 inactive deployments
artifacts — 37386bde Deployed Oct 29, 2026 by teamleaderleo via add the Windows daemon to the tree #76350
sentry-dsyms — 37386bde Deployed Oct 29, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #76350
ci-routing-agent — 37386bde Deployed Oct 29, 2026 by teamleaderleo via cmux-tui tree preflight #76350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant