Repository navigation
test(next): BrowserEntryRetirementTests compiles again (base red from #27166) - #27301
teamleaderleo wants to merge 1 commit into
Conversation
… chrome sent out of a Mutex) #27166's releasingAnEntryOffMainRetiresItsPageOnMain read the entry's chrome out of its Mutex (`owner.entry.withLock { $0?.chrome }`), a main actor-isolated value returned as a `sending` result: CmuxNextAppTests no longer compiles on feat-cmux-next, so no suite in that target runs. The chrome now goes into the window before the entry moves into its owner; the test's release off main is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1cff2b4271eadd0a1bb8
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a2cee9c to compare; do not merge until green; see lane-rules |
|
Owned by an agent session · session |
|
Found 7 test failures on Blacksmith runners: Failures
|
|
Tests: |
|
Bead |
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at a5c1c39 SHIP No findings. |
|
Closing as redundant: feat-cmux-next already has the same fix in 83fb73e ("BrowserEntryRetirementTests compiles under strict concurrency"), which also reads the chrome on main in a scope before the entry goes into the Mutex. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red fix:
CmuxNextAppTestsdoes not compile on feat-cmux-next, so no suite in that target runs.#27166's
releasingAnEntryOffMainRetiresItsPageOnMainread the entry's chrome out of itsMutex(owner.entry.withLock { $0?.chrome }). Now the chrome goes into the window on main before the entry moves into its owner. The test is otherwise the same: the last reference is still released off main, and it still checks that the page is retired on main.Found while running
ChannelsPageStateTestsfor #27289: the fleet's package-test lane failed at this compile error, which has nothing to do with that PR.Test:
BrowserEntryRetirementTestsandChannelsPageStateTestsare running on a fleet Mac (package-test-lane.sh suite); the result goes in a comment.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes a Swift 6 compile error in
BrowserEntryRetirementTeststhat was breaking the entireCmuxNextAppTeststarget onfeat-cmux-next.The test previously read the entry's chrome out of its
Mutexas asendingresult, which the compiler rejected because the chrome is main-actor-isolated. The chrome now goes into the window before the entry moves into its owner; the test's behavior (releasing the last reference off main, checking that the page retires on main) is unchanged.Written for commit a5c1c39. Summary will update on new commits.