Skip to content

test(next): BrowserEntryRetirementTests compiles again (base red from #27166) - #27301

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix-browser-entry-retirement-sending
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix-browser-entry-retirement-sending

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Base red fix: CmuxNextAppTests does not compile on feat-cmux-next, so no suite in that target runs.

Tests/CmuxNextAppTests/BrowserEntryRetirementTests.swift:43:57: error: returning main actor-isolated '$0.some.chrome.some' as a 'sending' result risks causing data races

#27166's releasingAnEntryOffMainRetiresItsPageOnMain read the entry's chrome out of its Mutex (owner.entry.withLock { $0?.chrome }). Now the chrome goes into the window on main before the entry moves into its owner. The test is otherwise the same: the last reference is still released off main, and it still checks that the page is retired on main.

Found while running ChannelsPageStateTests for #27289: the fleet's package-test lane failed at this compile error, which has nothing to do with that PR.

Test: BrowserEntryRetirementTests and ChannelsPageStateTests are running on a fleet Mac (package-test-lane.sh suite); the result goes in a comment.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes a Swift 6 compile error in BrowserEntryRetirementTests that was breaking the entire CmuxNextAppTests target on feat-cmux-next.

The test previously read the entry's chrome out of its Mutex as a sending result, which the compiler rejected because the chrome is main-actor-isolated. The chrome now goes into the window before the entry moves into its owner; the test's behavior (releasing the last reference off main, checking that the page retires on main) is unchanged.

Written for commit a5c1c39. Summary will update on new commits.

View guided diff Turn on auto-fix

… chrome sent out of a Mutex)

#27166's releasingAnEntryOffMainRetiresItsPageOnMain read the entry's chrome out of
its Mutex (`owner.entry.withLock { $0?.chrome }`), a main actor-isolated value
returned as a `sending` result: CmuxNextAppTests no longer compiles on
feat-cmux-next, so no suite in that target runs. The chrome now goes into the
window before the entry moves into its owner; the test's release off main is
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-1cff2b4271eadd0a1bb8
@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a5c1c39: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27301 -f ref=fix-browser-entry-retirement-sending -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a2cee9c to compare; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Found 7 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpddmitaj1/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpladkzm5d/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Tests: BrowserEntryRetirementTests (all three tests, including releasingAnEntryOffMainRetiresItsPageOnMain) and ChannelsPageStateTests passed at this head a5c1c395 on a fleet Mac (package-test-lane.sh suite, step 52ade3e742b616ed108d844c). CmuxNextAppTests compiles again.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-u2uc45 created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at a5c1c39

SHIP

No findings.

@teamleaderleo teamleaderleo removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as redundant: feat-cmux-next already has the same fix in 83fb73e ("BrowserEntryRetirementTests compiles under strict concurrency"), which also reads the chrome on main in a scope before the entry goes into the Mutex. CmuxNextAppTests compiles on base again.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — a5c1c395 Deployed Oct 29, 2026 by teamleaderleo via namespace autofix #6081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant