Repository navigation
fix(ios): keep Chief attachments when trying a failed turn again - #27286
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2209fa76608f5c2d6757
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2209fa76608f5c2d6757
|
Validation requested at |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Bead |
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 66262e7 SHIP No findings. |
|
MacHomeFeedTests on its own: head This run decides whether the one failure from the full-kit run ( Harness: the same for both SHAs, back to back on one AWS M4 Pro simulator host (Xcode 26.6, iPhone 17 Pro, iOS 26.5). No other xcodebuild or swift-test process ran during either side. The Rust FFI xcframework was built at each SHA first. For each SHA: one unmodified run (the receipt), then the same command with
Verdict: not the PR's red. At the head, the 7 tests pass every time in isolation (6 runs each). The same suite also fails on its own at base when the host is loaded, just in a different test. Both failures are the suite's own timing waits ( A second, independent harness gave the same result: Full-kit runs side by side, the fleet's
Base passed the full kit, so neither full-kit failure ( Agent session: agent session |
|
Exact-head SHIP remains at 66262e7. The paired MacHomeFeed receipts establish the corresponding failures on base (head 7/7 versus base 6/7, and head 12/12 versus base 11/12). The remaining WorkspaceTabsSourceTests assertion needs one focused rerun at this head, in the original failing environment. Commands:
If it passes, record the receipt and proceed through fast gates to ready and the pinned merge. If it fails, inspect the per-test error and fix it. Dispatch is currently blocked because the message relay cannot read the destination session list; no rerun success is claimed. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Chief's Try Again rebuilt a failed input from text alone, dropping photos and files and substituting “Please try that again.” for attachment-only messages. It now resends the original text, image bytes and MIME type, files and file names, or an audio recording using the existing conversation APIs. Repeated taps send once. Missing original inputs or attachment bytes send nothing and keep the failure available for retry.
Leo's request:
This is the Chief portion of the retry fix. Failed agent Retry is handled separately by #27314 using the daemon's retry provenance. Edit and Resend remains separate; desktop edits fork before the edited turn. No shared CmuxConversation changes, menu removals, defaults, timers, or observers.
Validation:
Risk: retry uploads the original attachments again under a new outgoing message id. The original input remains intact if a complete resend cannot be constructed.
Agent session: agent session
🤖 Generated with Claude Code