Skip to content

Add thread minimap inset gallery variants - #27192

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
nx-settings-rail-inset-variants
Oct 29, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
nx-settings-rail-inset-variants

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Lawrence's ask was: “needs more left padding”. This PR adds a gallery-only comparison for the thread minimap edge spacing while preserving the existing gap scenarios:

  • keeps the current gap-4-chosen, gap-8, and gap-12 gallery variants;
  • adds an unmodified current-placement baseline plus 4, 8, 12, and 16 px exploratory pane-edge candidates;
  • leaves railPlacement, useRailPlacement, CSS, and production defaults unchanged so the selected token can be coordinated with the placement work in Fix prompt rail pane anchoring and narrow-width access #26641.

The values are candidates for rendered comparison, not claims about private-image pixel scale. The rendered 8 px candidate is preferred for the production follow-up: it separates the resting ticks from the pane edge while leaving more text-side room than 12 or 16 px. That preference is visual judgment, not a pixel-scale claim about reference images. The production change must retain gutter compression and the existing maximum text overlap through the placement work in #26641. No private captures are included.

Evidence

  • Exact-head retained gallery artifact: gallery-advisory-27192-b8499b80ff619e887761ef59d9ad04cfe60332e8. Includes all eight narrow variants at 780 CSS px in light/dark Chromium, plus base images for the three existing gap variants. gallery-review.json binds head b8499b80ff619e887761ef59d9ad04cfe60332e8 to base 3004f44a390858dc8b928f7c6a8c7b2561abfae1; all ten new inset images are ready. New variants have no same-name base image.
  • Gallery matrix run 40807997283: 16 window-frame cases across eight variants and two appearances, rendered in both Chromium and WebKit (32 ready stages). This is render-health evidence only: the default window frame was used, and images were not retained; retained exact-head narrow visual comparison is in the advisory artifact above; source snapshot d44e6027c9cc22c3752e1f3449731f9f39772eab.
  • Focused test run 40808539178: bun test test/thread-minimap-inset-variants.test.ts, 1/1 passed; source snapshot 12035ab9cd903a9b632eb45533e87fe51c6e3271.
  • Web lint run 40809243907: bun run lint passed; source snapshot 190d98241060d7e3d6d8d90f128774dbb59f7dc5.
  • No Swift files changed.

Agent session: agent session

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review bd6e3d7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27192 -f ref=nx-settings-rail-inset-variants -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 30abc05e78 (run 40866223574 attempt 1): 2 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (3) code a web test failed
web / react-apps-base-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs markdown-table-obsidian.test.ts markdown tables (webkit) > a drag across cells selects text from the press to the pointer, not whole...: failed (job)
  • seen on other PRs queued-user-footer.test.ts an unread steer shows only queue controls; pointer Send now reaches its prompt and accepted delivery...: failed (job)
  • seen on other PRs chiefLook.test.tsx search renders Bubble Style in the Look card: failed (job)
  • seen on other PRs rowSummary.test.tsx no description line on any Settings page is over 60 characters, in any language: failed (job)
  • seen on other PRs rowSummary.test.tsx every schema summary fits 60 characters in every language: failed (job)
  • seen on other PRs thread-minimap-left-rail-stays.test.ts webkit: an open card follows its rail on every painted inspector and resize frame at 1084px: failed (job)
  • seen on other PRs transcript-fold-no-blank-space-browser.test.ts a long turn with notifications, bookkeeping and messages draws no blank space, folded or open: failed (job)
  • seen on other PRs transcript-gap-select-browser.test.ts chromium: RTL document gaps and both gutters preserve rtl line endpoints: failed (job)
  • seen on other PRs transcript-gap-select-browser.test.ts chromium: RTL document gaps and both gutters preserve ltr line endpoints: failed (job)
  • seen on other PRs transcript-gap-select-browser.test.ts webkit: RTL document gaps and both gutters preserve rtl line endpoints: failed (job)
Matched log lines
web / react-apps-base-check (3): (fail) markdown tables (webkit) > a drag across cells selects text from the press to the pointer, not whole cells [669.78ms]
web / react-apps-base-check (1): (fail) search renders Bubble Style in the Look card [3836.37ms]

Not re-run automatically: web / react-apps-base-check (3), web / react-apps-base-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 9458432; do not merge until green; see lane-rules
red: web / Web status; base red: the same failure on the base 9458432; does not block
red: web / react-apps-base-check (1); no finished base run on 9458432 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (3); no finished base run on 9458432 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; base red: the same failure on the base 9458432; does not block

Gallery before/after for 30abc05: 16 states rendered, 10 images differ, 15 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40866223226 -R manaflow-ai/cmux -n gallery-advisory-27192-30abc05e78886144f8ec2a3bd2b84715a08ec054 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.thread-minimap-narrow/inset-current Apple System Colors Light new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-current Apple System Colors new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-4-lawrence-candidate Apple System Colors Light new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-4-lawrence-candidate Apple System Colors new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-8-reference-candidate Apple System Colors Light new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-8-reference-candidate Apple System Colors new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-12-alternative Apple System Colors Light new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-12-alternative Apple System Colors new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-16-alternative Apple System Colors Light new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/inset-16-alternative Apple System Colors new 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-4-chosen Apple System Colors Light unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-4-chosen Apple System Colors unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-8 Apple System Colors Light unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-8 Apple System Colors unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-12 Apple System Colors Light unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap-narrow/gap-12 Apple System Colors unchanged 0% own threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-markdown Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-markdown Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-failure Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-failure Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-metadata Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-metadata Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-fixed-2 Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-fixed-2 Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-fixed-3 Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-fixed-3 Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-growing Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/card-prompt-growing Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/rest Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/rest Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/scrubbing Apple System Colors Light unchanged 0% same-folder threadMinimapNarrow.gallery.ts
agent-pane.thread-minimap/scrubbing Apple System Colors unchanged 0% same-folder threadMinimapNarrow.gallery.ts

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-1ha3la created for this PR by the cmux coordinator.

@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Found 14 test failures on Blacksmith runners:

Failures

Test View Logs
src/pages/settings/chiefLook.test.tsx/chiefLook.test.tsx View Logs
src/pages/settings/chiefLook.test.tsx/chiefLook.test.tsx View Logs
src/pages/settings/rowSummary.test.tsx/rowSummary.test.tsx View Logs
src/pages/settings/rowSummary.test.tsx/rowSummary.test.tsx View Logs
test/markdown-table-obsidian.test.ts/markdown-table-obsidian.test View Logs
test/markdown-table-obsidian.test.ts/markdown-table-obsidian.test View Logs
test/queued-user-footer.test.ts/queued-user-footer.test View Logs
test/queued-user-footer.test.ts/queued-user-footer.test View Logs
test/thread-minimap-left-rail-stays.test.ts/thread-minimap-left-rail-stays.test View Logs
test/thread-minimap-left-rail-stays.test.ts/thread-minimap-left-rail-stays.test View Logs

...and 4 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · took over from an earlier session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at bd6e3d7

No blocking findings.

@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@cursor

cursor Bot commented Oct 29, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo
teamleaderleo merged commit 25e72b6 into feat-cmux-next Oct 29, 2026
151 of 156 checks passed
@teamleaderleo
teamleaderleo deleted the nx-settings-rail-inset-variants branch October 29, 2026 14:48
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40895243022 at 25e72b6 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 72902c8. This pull request is one of 5 merged since: #27429, #27443, #26969, #27447, #27192.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

teamleaderleo added a commit that referenced this pull request Oct 29, 2026
Resolve against #27192's exploratory inset gallery: the pane-edge placement here
replaces those plays, so the gallery keeps this PR's resting/hovered/focused
variants and the exploratory inset test goes with them. Keep the flushSync band
render (9439a80) and Session Info's useUnderInspector.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-636fd2e0ce24b82d1b3d

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 30abc05e Deployed Oct 29, 2026 by teamleaderleo via wait for same-key tree publisher #76610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant