Repository navigation
Add thread minimap inset gallery variants - #27192
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: green on the base 9458432; do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
|
Bead |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Found 14 test failures on Blacksmith runners: Failures
...and 4 more test failures. View all on Blacksmith
|
|
Owned by an agent session · took over from an earlier session · session |
|
Review (codex gpt-6-astra high, next-review): SHIP at bd6e3d7 No blocking findings. |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Shipped in:
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40895243022 at 25e72b6 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
Resolve against #27192's exploratory inset gallery: the pane-edge placement here replaces those plays, so the gallery keeps this PR's resting/hovered/focused variants and the exploratory inset test goes with them. Keep the flushSync band render (9439a80) and Session Info's useUnderInspector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-636fd2e0ce24b82d1b3d
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Lawrence's ask was: “needs more left padding”. This PR adds a gallery-only comparison for the thread minimap edge spacing while preserving the existing gap scenarios:
gap-4-chosen,gap-8, andgap-12gallery variants;railPlacement,useRailPlacement, CSS, and production defaults unchanged so the selected token can be coordinated with the placement work in Fix prompt rail pane anchoring and narrow-width access #26641.The values are candidates for rendered comparison, not claims about private-image pixel scale. The rendered 8 px candidate is preferred for the production follow-up: it separates the resting ticks from the pane edge while leaving more text-side room than 12 or 16 px. That preference is visual judgment, not a pixel-scale claim about reference images. The production change must retain gutter compression and the existing maximum text overlap through the placement work in #26641. No private captures are included.
Evidence
gallery-advisory-27192-b8499b80ff619e887761ef59d9ad04cfe60332e8. Includes all eight narrow variants at 780 CSS px in light/dark Chromium, plus base images for the three existing gap variants.gallery-review.jsonbinds headb8499b80ff619e887761ef59d9ad04cfe60332e8to base3004f44a390858dc8b928f7c6a8c7b2561abfae1; all ten new inset images are ready. New variants have no same-name base image.d44e6027c9cc22c3752e1f3449731f9f39772eab.bun test test/thread-minimap-inset-variants.test.ts, 1/1 passed; source snapshot12035ab9cd903a9b632eb45533e87fe51c6e3271.bun run lintpassed; source snapshot190d98241060d7e3d6d8d90f128774dbb59f7dc5.Agent session: agent session