Repository navigation
Warn about machine load in the composer Computer menu - #27102
Conversation
|
Bead |
|
Review (codex gpt-6-astra): SHIP at b3e13e0 Independent full-file review, high reasoning and fast mode. All earlier findings are resolved. Static review only; native compilation remains unverified, and the Swift HOLD remains in force. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on bb383a7 to compare; do not merge until green; see lane-rules Gallery before/after for |
Default changesThis pull request changes 6 defaults at
Needs a review. It passes with an independent review receipt on this commit: a comment or review whose first line is Regenerate the snapshot with |
|
Found 10 test failures on Blacksmith runners: Failures
|
|
Orphaned: no activity for 15 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
Orphaned: only the sweep's base merge since, and no lane holds a lease on it. The orphan sweep could not merge |
|
Review (codex gpt-6-astra): SHIP at 6f3ed62 Exact-head review after the generated settings exports were applied. The prior stale-export finding is resolved; no actionable wrong-state, security, crash, or compile integration findings remain. |
|
Review (codex gpt-6-astra): SHIP at 6f3ed62 Exact-head review after applying the generated settings exports. No actionable wrong-state, security, crash, or compile integration findings remain. |
|
Review (codex gpt-6-astra): SHIP at a813e4d Delta review of the one catalog-only commit: both machine-load-warning keys now have all 21 locales, valid stringUnit shapes/states, semantically faithful text, and no placeholder or line-break mismatches. No actionable wrong-state, security, crash, or compile integration findings. |
|
Shipped in:
|
|
Shipped in:
|
…s, not on _acpmux/status (#28492) (#28529) pendingTrustNeverMovesFromDaemonAToDaemonB (#26130) used the page's _acpmux/status as its barrier: it waited until the stand-in daemon saw that frame, then checked that no acp.trust.set had reached daemon B. Since #27102 (9328d55) the pane answers a page's _acpmux/status from its daemon's socket and never relays it (AgentPaneTransport+Check.swift :99, covered by AgentPaneTransportStatusTests), so the barrier never came and both cases failed at :336, at feat-cmux-next df9b52b (fleet job f44e8e745193fb4ba92d2646) and with #28495 (b2ffa8a35039b75baf009b9e). The crash fixed by #28495 hid it in CI. The local answer is the intended behavior, so the test changes: its barrier is _acpmux/harnesses, a read-only request the pane relays unchanged. What the test checks is the same. Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The chat and New Tab composers’ Computer menus now warn before dispatching to a connected machine at its CPU or free-memory budget. It shows a quiet warning tint and a precise detail such as “High load: 14/10 cores busy” or “Low memory: 1.2 GB free”. Healthy machines keep their existing rows. Settings > General > Agent Chat includes Show Machine Load Warnings, on by default.
The existing status refresh uses the daemon's cached minute reading, the same source used by the native machine sidebar. Budget overrides are respected; there is no added poller. Disconnected machines keep their readiness message. Placement roles are not present on these rows, so this change adds no build-role plumbing.
Leo's request (ask-5e97611b66):
Validation:
ce088c2a4c17de89fd96864e1bc0f2c06a456e32: cmux-ci run 40998609115, 64 parser/menu tests and 18 New Tab tests. The later generated-export-only commits do not alter web behavior.6f3ed62dd8d0e0a514270e3487b56346cbdd3e58after the generated exports were applied. The fleet app compile-check passed at that exact head: jobfb5599b3c560bcb5523fc0d4, kindcmux-next-swift-check, commandcmux-next-swift-check.sh 6f3ed62dd8d0e0a514270e3487b56346cbdd3e58 --app, on the Linux-pool worker (190 second build, artifact uploaded).Risk: the native relay carries a bounded subset of cached health into the composer. Each local connection permits one read at a time, with a two-second deadline; replies use the existing bounded inbound queue and request-ID filter. Closed connections discard late replies. Daemon access rules remain unchanged. Native compilation passed at the exact head as recorded above.
Capture
tour-agent-paneata813e4d64a0b(fleet build, capture mini, text checked for private data)Capture
scene-settingsata813e4d64a0b(fleet build, capture mini, text checked for private data)These fleet captures satisfy the real-capture guard but do not reach the changed Computer-menu warning or Settings toggle; the existing before/after gallery image above shows the Computer-menu warning variants. The Settings toggle is not shown in these captures.
Validation at
a813e4d64a0be74dac863d4857a1b39d14526a1b: independent Astra delta review returned SHIP; fleet app compile-checkfd3556966cd8560320bdd36cpassed in 88 seconds. L10n run 41054084252 used the exact head tree and confirms both added keys have all 21 locales; 112 unrelated base omissions remain. CI run 41052652253 passed its web shards and aggregate.Agent session: agent session