Repository navigation
acpmux: keep session rows stable across short peer reconnects - #27005
Closed
teamleaderleo wants to merge 9 commits into
Closed
teamleaderleo wants to merge 9 commits into
teamleaderleo wants to merge 9 commits into
Conversation
Collaborator
Author
|
Bead |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 21:38 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 21:48 — with
GitHub Actions
Inactive
teamleaderleo
force-pushed
the
lane/hb-peer-flap-grace
branch
from
October 28, 2026 22:03
18f5813 to
fee7af0
Compare
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 22:04 — with
GitHub Actions
Inactive
teamleaderleo
force-pushed
the
lane/hb-peer-flap-grace
branch
from
October 28, 2026 22:06
fee7af0 to
372a60f
Compare
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 22:14 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 28, 2026 22:31 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 538ccd0 to compare; do not merge until green; see lane-rules |
teamleaderleo
temporarily deployed
to
sentry-dsyms
October 28, 2026 23:21 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 28, 2026 23:21 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 28, 2026 23:26 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 28, 2026 23:26 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 28, 2026 23:31 — with
GitHub Actions
Inactive
This was referenced Oct 29, 2026
Collaborator
Author
|
Owned by an agent session · took over from an earlier session · session |
Collaborator
Author
teamleaderleo
force-pushed
the
lane/hb-peer-flap-grace
branch
from
October 30, 2026 02:46
372a60f to
2544faf
Compare
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 30, 2026 02:46 — with
GitHub Actions
Inactive
|
Found 8 test failures on Blacksmith runners: Failures
|
teamleaderleo
temporarily deployed
to
sentry-dsyms
October 30, 2026 03:08 — with
GitHub Actions
Inactive
teamleaderleo
had a problem deploying
to
artifacts
October 30, 2026 03:08 — with
GitHub Actions
Failure
Collaborator
Author
|
Superseded by #27809, which carries its eight peer-flap commits with their authorship. The soak and review continue there (comment at 01:29Z). |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
HOLD: Final rebased-head review and paired soak are pending (#27048 has landed).
A peer restart currently marks every session unreachable, including closed chats, then announces the entire list again. This change gives row updates a 10-second disconnect grace and keeps closed rows closed. Reconnects announce only rows whose contents changed. Forwarded requests still fail immediately when the link is down.
Leo: "I do a hell of a lot of routing to remote machines, right? ... Are we covering the edge cases for when, you know, something isn't going right, if there's recovery, whatever, stuff like that."
A single notice loop owns the grace deadlines. A fresh list or ready notice cancels its peer's deadline; repeated failures do not extend it; generation checks reject deadlines for replaced peers. A dedicated persistent stop signal cancels the loop at daemon shutdown without consuming the main daemon's notification. Logging, purge fencing, and transcript persistence still happen at the real disconnect. No daemon update timing, forwarding refusal, or list_guard changes.
Reconnect still saves the cache because a preceding session notice may have changed a row while its save was throttled. Already-stale and closed rows avoid redundant row writes on subsequent failures.
Validation
Performance
The Linux-only ignored harness measures the daemon Hub in a test process with fake notices and a memory store. It excludes SSH, app rendering, and disk-cache I/O. The prepared paired runner builds both versions with the identical harness, then runs isolated processes on the same Linux worker.
Remaining integration and landing block
This draft overlaps #27002 in disconnect cache handling. When integrating, preserve that PR's first/hourly outage-save condition and clearing of saved outage state on Connected.
The broker refused a normal merge of companion #26998 because its credential is limited to publishing. The relay also could not reach the authorized landing owner. No merge override was attempted. This PR remains draft pending the final checks, measurements, and an authorized landing path.
Agent session: agent session