Repository navigation
ci(cla-rerun): name a spent glaeda-route App budget and re-run the guard's rejects from that hour - #26992
Merged
Conversation
…run the guard's rejects from that hour CLA policy guard on main reads on the glaeda-route App token, the same one the CLA quota re-run janitor reads and re-runs with. When that budget is spent the guard rejects every pull request with its generic message, and the janitor logged only "HTTP 403 on ...: the budget is spent". Now a refused call on the App token says plainly that the glaeda-route App budget is spent and that the guard's rejects in that hour are the budget, not a policy; the pass waits for the reset as before, and a guard reject that finished in that App hour counts as evidence, so policy-changing pull requests are re-run too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a592ef92c66f080e3cc
Collaborator
Author
|
Owned by an agent session · session |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
…d reject in it is evidence Review: a guard run that failed for another reason in that hour was re-run, and a Retry-After or fallback wait was taken for the App hour's reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a592ef92c66f080e3cc
Review: a secondary limit or a permission refusal (403/429 with X-RateLimit-Remaining above 0) carried a reset header and was taken for the App hour running out. Now only X-RateLimit-Remaining 0 with its reset counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a592ef92c66f080e3cc
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Merge receipt for |
teamleaderleo
added a commit
that referenced
this pull request
Oct 28, 2026
A secondary limit or a refusal on the glaeda-route App token (no X-RateLimit-Remaining 0 with a reset) logged the 'App budget spent' warning and promised re-runs after the reset, though it opens no App hour. It now logs a plain line instead. Review nit on #26992. Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a592ef92c66f080e3cc Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLA policy guard on
mainreads on the glaeda-route App token (#25611), the same token the CLA quota re-run janitor reads and re-runs with. When that App budget runs out (2026-10-28 from 06:44Z), the guard rejects every pull request with its generic "rejected the proposed policy", and the janitor's log only saidHTTP 403 on ...: the budget is spent, which read like the workflow token's budget.scripts/ci/cla_quota_rerun.pynow:::warning title=glaeda-route App budget spent::annotation names the budget and its reset, and states that the guard's rejects in that hour are the budget, not a policy;MAX_GUARD_ATTEMPTstill caps it.The workflow token's spent-budget path and its messages are unchanged. No workflow, permission or token changes.
Measured context: since #26760 the App installation peaked at about 3150 of 5000 calls an hour today (probe lines from #26856 and the janitor's own
Log the glaeda-route App's budgetstep), so this is the fallback for the next exhaustion, not a fix for a live one.Testing
python3 -m unittest tests.test_cla_quota_rerun tests.test_glaeda_route_app_budget: 58 tests OK.The new
test_a_spent_app_budget_is_named_waited_out_and_its_guard_rejects_rerunfails on base (no App-budget message, and the policy-changing reject is left alone) and passes on head.test_a_spent_workflow_token_budget_is_not_called_the_appskeeps the workflow-token message as it was.Observed / Not run
Observed: the unit tests above, red on base for the new test and green on head. Not run: a live pass against a spent App budget (none has happened since the morning of 2026-10-28).
Changelog
none
🤖 Generated with Claude Code
Agent session: agent session