Repository navigation
fix(sidebar): show hover previews instantly after dwell - #26961
Conversation
|
Review (Astra high): SHIP at 320892d. Independent static review found no production correctness defect. The new path only handles a first Coverage limit: the test sets Reduce Motion off but does not force every motion setting or display capability. Motion disabled in the environment can make the old entry snap too. Acceptance therefore requires the red run's expected first-frame assertion failure and a passing green run with tests executed; a passing head alone is insufficient. Native verification is blocked on fleet capacity. Green job |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b43bd42 to compare; do not merge until green; see lane-rules |
|
Bead |
|
Review (codex gpt-6-astra high, next-review): SHIP at b119403 No blocking findings. |
|
Owned by an agent session · session |
Sidebar-Look: no visual change Agent-Session: https://cmux.com/deeplink/agent?id=aid-4b1357c220139dbbe35a
Sidebar-Look: Leo ask-067e9aa217: instantly come in on the first load; the delay that we have is fine Agent-Session: https://cmux.com/deeplink/agent?id=aid-4b1357c220139dbbe35a
Sidebar-Look: no visual change Agent-Session: https://cmux.com/deeplink/agent?id=aid-4b1357c220139dbbe35a
b119403 to
f6143c0
Compare
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6-astra high, next-review): SHIP at f6143c0 No blocking findings. |
|
Review (codex gpt-6-astra high fast, independent box review-26961-f614): SHIP at f6143c0 No actionable findings. Sidebar previews appear immediately after the dwell, and the existing retarget and update-card animations are intact. A focused GUI rerun at this head passes all 3 suites (HoverCardPanelMotion 4/4, SidebarHoverCardDwell 2/2, UpdateCardHoverParity 4/4). The generated-files red is the stale-resource-bundle base red that #27188 fixed. Landing waits on the Swift test hold (#26809). |
|
Review (codex gpt-6-astra high, review-router): SHIP at 7ca0725
VERDICT: SHIP |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Workspace hover previews now appear at full opacity in their resting position when the existing dwell expires. Retargeting an open card keeps its transition. The placement adjustment is owned by #26942.
Leo, ask-067e9aa217: “there's no fade-in animation for the hover. We can just have it instantly come in on the first load; the delay that we have is fine, maybe.”
Reference: cmux sidebar hover preview. The card's settled appearance is unchanged.
Validation
The regression commit is
6197d8ae96e1c10f021f39cc021b94e9b649aaeb; the fix is320892df18e7c084f4a1009a10057bc9204a7875; the final parity-test adjustment isb1194033831059637fe892b195c2323d40508397.The red GUI run
6ea7843cb794ad2ca7563a95on the regression commit failed exactly on the new first-show assertions (alpha 0 instead of 1 and slide start(-6, 0)instead of nil). The green GUI run192dc9a702f37b25c2aed72fpassed the motion and dwell suites on the fix. Final exact-head GUI run763f855d0559ee8bbfb4e9c5(b1194033831059637fe892b195c2323d40508397,CMUX_TEST_REQUIRE_GUI=1) passed oncmux13s-Mac-mini.local:HoverCardPanelMotionTests,SidebarHoverCardDwellTests, andUpdateCardHoverParityTestsall passed (exit 0; artifactsha256:9ab24fcd1be08247cbc640af9c77bebfeae0cd682a6db5550d6b476bd9981945).Passed Swift syntax checks,
git diff --check, and the NEXT prepush gate.Before / after capture
3a7653b054ed0407e8fb0b62ad7e79b5229643c8(before)b1194033831059637fe892b195c2323d40508397(after)Both captures use the explicit
action.runworkspace-new RPC (focus: true,origin: script,cwd: /tmp) followed byworkspace.showResources, with the existing 250 ms dwell. Base job9b15699f0e22c859756839ba(hostcmux13s-mac-mini) and final build437f41a94566ab88e8b7a5bc(hostcmux8s-mac-mini) both completed all steps with no privacy hits. The recorded card geometry is base{{620,868},{180,52}}/ final{{620,871},{180,52}}; anchor geometry is base{{410,896},{208.5,24}}/ final{{410,899},{208.5,24}}; both reportcard_showing=true,delay_ms=250, and textPreview first show/tmp.Performance
No perf numbers: this changes the first presentation frame after the existing dwell; it removes the entry fade and slide without changing the timer or doing per-frame work.
Changelog
Fixed: Workspace hover previews appear instantly after the hover delay.
Agent session: agent session