Skip to content

fix(sidebar): show hover previews instantly after dwell - #26961

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
nx-sidebar-hover-no-fade-1028
Oct 29, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
nx-sidebar-hover-no-fade-1028

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Workspace hover previews now appear at full opacity in their resting position when the existing dwell expires. Retargeting an open card keeps its transition. The placement adjustment is owned by #26942.

Leo, ask-067e9aa217: “there's no fade-in animation for the hover. We can just have it instantly come in on the first load; the delay that we have is fine, maybe.”

Reference: cmux sidebar hover preview. The card's settled appearance is unchanged.

Validation

The regression commit is 6197d8ae96e1c10f021f39cc021b94e9b649aaeb; the fix is 320892df18e7c084f4a1009a10057bc9204a7875; the final parity-test adjustment is b1194033831059637fe892b195c2323d40508397.

The red GUI run 6ea7843cb794ad2ca7563a95 on the regression commit failed exactly on the new first-show assertions (alpha 0 instead of 1 and slide start (-6, 0) instead of nil). The green GUI run 192dc9a702f37b25c2aed72f passed the motion and dwell suites on the fix. Final exact-head GUI run 763f855d0559ee8bbfb4e9c5 (b1194033831059637fe892b195c2323d40508397, CMUX_TEST_REQUIRE_GUI=1) passed on cmux13s-Mac-mini.local: HoverCardPanelMotionTests, SidebarHoverCardDwellTests, and UpdateCardHoverParityTests all passed (exit 0; artifact sha256:9ab24fcd1be08247cbc640af9c77bebfeae0cd682a6db5550d6b476bd9981945).

Passed Swift syntax checks, git diff --check, and the NEXT prepush gate.

Before / after capture

Base 3a7653b054ed0407e8fb0b62ad7e79b5229643c8 (before) Final b1194033831059637fe892b195c2323d40508397 (after)
Light · Dark Light · Dark

Both captures use the explicit action.run workspace-new RPC (focus: true, origin: script, cwd: /tmp) followed by workspace.showResources, with the existing 250 ms dwell. Base job 9b15699f0e22c859756839ba (host cmux13s-mac-mini) and final build 437f41a94566ab88e8b7a5bc (host cmux8s-mac-mini) both completed all steps with no privacy hits. The recorded card geometry is base {{620,868},{180,52}} / final {{620,871},{180,52}}; anchor geometry is base {{410,896},{208.5,24}} / final {{410,899},{208.5,24}}; both report card_showing=true, delay_ms=250, and text Preview first show / tmp.

Performance

No perf numbers: this changes the first presentation frame after the existing dwell; it removes the entry fade and slide without changing the timer or doing per-frame work.

Changelog

Fixed: Workspace hover previews appear instantly after the hover delay.

Agent session: agent session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (Astra high): SHIP at 320892d.

Independent static review found no production correctness defect. The new path only handles a first .besideRow show; it clears an old slide, sets full opacity and orders the panel front. Dwell, existing-card retargeting, morphing, crossfade and resume paths are unchanged. Primary review independently inspected the whole three-file diff and reached the same static verdict.

Coverage limit: the test sets Reduce Motion off but does not force every motion setting or display capability. Motion disabled in the environment can make the old entry snap too. Acceptance therefore requires the red run's expected first-frame assertion failure and a passing green run with tests executed; a passing head alone is insufficient.

Native verification is blocked on fleet capacity. Green job 192dc9a702f37b25c2aed72f reached its 120-second queue wait and remains queued. Red job 6ea7843cb794ad2ca7563a95 is compiling. Capture build e99cc913245da386a3acc88d is running. These are accepted/running receipts, not terminal success. Resume the same jobs. The PR has not been marked ready-to-land.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review f6143c0: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26961 -f ref=nx-sidebar-hover-no-fade-1028 -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b43bd42 to compare; do not merge until green; see lane-rules

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-b4wp5p created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at b119403

No blocking findings.

@teamleaderleo

teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp_tc49g57/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpqnhoa145/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at f6143c0

No blocking findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high fast, independent box review-26961-f614): SHIP at f6143c0

No actionable findings. Sidebar previews appear immediately after the dwell, and the existing retarget and update-card animations are intact. A focused GUI rerun at this head passes all 3 suites (HoverCardPanelMotion 4/4, SidebarHoverCardDwell 2/2, UpdateCardHoverParity 4/4). The generated-files red is the stale-resource-bundle base red that #27188 fixed. Landing waits on the Swift test hold (#26809).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, review-router): SHIP at 7ca0725

  • No blocking findings in the supplied diff. The .besideRow branch removes entry motion and restores full opacity while preserving retarget behavior. No timers or observers are added.
  • Review limited to the supplied files; repository reads required unavailable approval. No builds run.
  • The existing PR HOLD remains applicable.

VERDICT: SHIP

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Carried onto current base as #27529 (same commits, authorship kept). The owner lane can't be reached, so #27529 lands it. The #26809 HOLD never applied here.

@teamleaderleo
teamleaderleo merged commit 3bc5c64 into feat-cmux-next Oct 29, 2026
174 of 177 checks passed
@teamleaderleo
teamleaderleo deleted the nx-sidebar-hover-no-fade-1028 branch October 29, 2026 22:02
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 7ca07253 Deployed Oct 29, 2026 by teamleaderleo via wait for same-key tree publisher #77425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant