Skip to content

fix(cmux-next): declare CmuxNextDictation dependency for CmuxNextApp - #26873

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
hotswap-opus/dictation-dep
Oct 28, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
hotswap-opus/dictation-dep

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the base red on feat-cmux-next from c27c60f ("Labs Voice Room in cmux … (part 2)").

Sources/CmuxNextApp/VoiceRoom/VoiceRoomHandlers.swift imports CmuxNextDictation, but the CmuxNextApp target in Packages/macOS/CmuxNext/Package.swift did not declare it, so the "Package dependency lists sorted" step in "cmux-next checks" fails:

CmuxNextApp: imports CmuxNextDictation but does not declare it in its dependencies

This adds "CmuxNextDictation" to CmuxNextApp's dependencies. Nothing else changes. CmuxNextDictation is a service-layer target, and CmuxNextApp (the app layer) already mixes service targets (plans/cmux-next/architecture-layers.json). SwiftPM was already building the module transitively, so this only makes the edge explicit for incremental builds.

Verification (local, no Swift build):

  • scripts/cmux-next/check-package-dependency-lists.py: fails on the base tip 0c37fbe, passes with this change
  • scripts/cmux-next/tests/test_check_package_dependency_lists.py: 14 tests OK

Risk: low. One manifest line, adding a dependency that already exists transitively.

Review (codex gpt-6-astra high, fast): SHIP at c4fc19d

Agent session: agent session

🤖 Generated with Claude Code

VoiceRoomHandlers.swift (c27c60f) imports CmuxNextDictation, but the
CmuxNextApp target did not declare it, so the "Package dependency lists
sorted" check fails on feat-cmux-next.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3891b16636fa80ffc495
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review c4fc19d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26873 -f ref=hotswap-opus/dictation-dep -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

For awareness, lawrencecchen: c27c60f (Labs Voice Room, part 2) went to feat-cmux-next directly, and its VoiceRoomHandlers.swift imports CmuxNextDictation without CmuxNextApp declaring it. That turned the "Package dependency lists sorted" check red on base. This PR only adds the missing dependency line. Running python3 scripts/cmux-next/check-package-dependency-lists.py before pushing catches this.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-9qihmt created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 4b0b9eb into feat-cmux-next Oct 28, 2026
167 of 177 checks passed
@teamleaderleo
teamleaderleo deleted the hotswap-opus/dictation-dep branch October 28, 2026 13:26
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40697064264 at 3d58f37 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 2a0fe48. This pull request is one of 3 merged since: #26865, #26873, #26127.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40696480262 at 4b0b9eb failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 0c37fbe. This pull request is one of 2 merged since: #26865, #26873.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — c4fc19d4 Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #71916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant