Repository navigation
fix(cmux-next): declare CmuxNextDictation dependency for CmuxNextApp - #26873
Conversation
VoiceRoomHandlers.swift (c27c60f) imports CmuxNextDictation, but the CmuxNextApp target did not declare it, so the "Package dependency lists sorted" check fails on feat-cmux-next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3891b16636fa80ffc495
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
For awareness, |
|
Bead |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40697064264 at 3d58f37 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40696480262 at 4b0b9eb failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
Fixes the base red on
feat-cmux-nextfrom c27c60f ("Labs Voice Room in cmux … (part 2)").Sources/CmuxNextApp/VoiceRoom/VoiceRoomHandlers.swiftimportsCmuxNextDictation, but theCmuxNextApptarget inPackages/macOS/CmuxNext/Package.swiftdid not declare it, so the "Package dependency lists sorted" step in "cmux-next checks" fails:This adds
"CmuxNextDictation"toCmuxNextApp's dependencies. Nothing else changes.CmuxNextDictationis aservice-layer target, andCmuxNextApp(theapplayer) already mixes service targets (plans/cmux-next/architecture-layers.json). SwiftPM was already building the module transitively, so this only makes the edge explicit for incremental builds.Verification (local, no Swift build):
scripts/cmux-next/check-package-dependency-lists.py: fails on the base tip 0c37fbe, passes with this changescripts/cmux-next/tests/test_check_package_dependency_lists.py: 14 tests OKRisk: low. One manifest line, adding a dependency that already exists transitively.
Review (codex gpt-6-astra high, fast): SHIP at c4fc19d
Agent session: agent session
🤖 Generated with Claude Code