Skip to content

fix(settings): declare sidebar hover controls agent policy - #26840

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/nx-sidebar-hover-agent-policy
Oct 28, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/nx-sidebar-hover-agent-policy

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

The base test SettingsSchemaExportTests.everyKeyHasAnExplicitAgentPolicy reported missing → ["sidebar.controlsOnHover"] after f004cef added the setting without an agent-policy decision.

Allow agents to set this appearance-only setting, matching the existing sidebar visibility controls, and refresh the generated settings export. No sidebar rendering or default changes.

Validation:

  • Swift syntax, prepush-gate.py, git diff --check, pr-overlap, and pr-owner check-push passed.
  • Fleet export step dee42f3df70d4c7d45323710 ran at source head 186bce421956c423c5997a3663f593df7cec01aa, exited 0, and produced artifact sha256:4439dcf4487992adc635c1aee8623ea1914ffb8abeee1b8d40457d3ce2da112e. Its native SettingsSchemaExportTests ran 5 tests, including everyKeyHasAnExplicitAgentPolicy and exportIsFresh, all passed; ManagedPreferencesManifestTests ran 4 tests and passed.
  • The artifact changed only schemas/settings/settings-schema.json, setting sidebar.controlsOnHover.agent_settable from false to true; bot-only defaults/docs outputs were dropped.
  • Final exact-head native verification is step fef8942f67931d2b563778c8, ref e9a2e009ee4875bdce5ff481714ba99530bec2ba, with CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app; it exited 0 on the managed fleet. SettingsSchemaExportTests ran 5 tests, including everyKeyHasAnExplicitAgentPolicy and exportIsFresh, all passed. Summary digest: sha256:aa1c5e582ba683e20169b4a25b6084ac8483bfcf3afdd495354228ad42248a64.
  • Independent Astra xhigh whole-diff review at final head e9a2e009ee4875bdce5ff481714ba99530bec2ba: SHIP, no P0–P2 findings.

Primary review: the actual two-file diff, generated-artifact checksum, clean worktree and pushed exact head were independently inspected; source-policy and exported metadata agree.

Remaining CI reds are outside the changed files: Package dependency lists sorted reports the pre-existing CmuxNextApp import of CmuxNextDictation missing from Package.swift; the release-notary job reports assertions about release workflows. The base release-notary job also fails these workflow checks. Neither Package.swift, the release workflows nor their tests changed in this PR. Exact-head Release compile, native settings-schema tests, export generation, generated drift and risk evidence passed.

Risk: agents can now set/reset the same control-visibility toggle available to the user; privacy, network access, and destructive policy are unchanged.

No capture: this changes only the agent-policy table and its exported metadata; no sidebar rendering, setting default, or visible UI changes.

Agent session: agent session

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e9a2e00: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26840 -f ref=lane/nx-sidebar-hover-agent-policy -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 953bd3b to compare; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Found 11 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp_gtoxlmi/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpxeoe6g2k/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_prepare_runs_on_linux_and_executes_no_mach_o (main.NightlyPooledRoutingTests.t
est_prepare_runs_on_linux_and_executes_no_mach_o)/
test_prepare_runs_on_linux_and_executes_no_mach_o (main.NightlyPooledRoutingTests.t
est_prepare_runs_on_linux_and_executes_no_mach_o)
View Logs
test_the_next_feed_keeps_its_newest_nightly_item_before_it_goes_live (main.Workflow
Tests.test_the_next_feed_keeps_its_newest_nightly_item_before_it_goes_live)/
test_the_next_feed_keeps_its_newest_nightly_item_before_it_goes_live (main.Workflow
Tests.test_the_next_feed_keeps_its_newest_nightly_item_before_it_goes_live)
View Logs

...and 1 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-5me7r4 created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6-astra xhigh, nx-sidebar-hover-policy-review): SHIP at e9a2e00

The independent session reviewed the complete base-to-head diff and found no P0–P2 issues. It confirmed one appearance-only setting entry in the settable policy, no refusal entry, and the matching generated schema row with agent_settable: true and agent_refusal: null.

Primary inspection also confirms the entire diff is exactly those two files, the generated patch matches fleet artifact sha256:4439dcf4487992adc635c1aee8623ea1914ffb8abeee1b8d40457d3ce2da112e, the worktree is clean, and the remote branch matches the reviewed head. Export step dee42f3df70d4c7d45323710 passed all 5 settings-schema tests and 4 managed-preferences tests. Final exact-head suite step fef8942f67931d2b563778c8 is still running; landing waits for that terminal receipt and check reconciliation.

@teamleaderleo teamleaderleo removed the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo
teamleaderleo merged commit 9874141 into feat-cmux-next Oct 28, 2026
183 of 187 checks passed
@teamleaderleo
teamleaderleo deleted the lane/nx-sidebar-hover-agent-policy branch October 28, 2026 12:19
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40688911044 at 52bbe91 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files.
Those jobs last passed at 7f18564. This pull request is one of 3 merged since: #26850, #26817, #26840.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40690021866 at 1e8fb3c failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files.
Those jobs last passed at 7f18564. This pull request is one of 4 merged since: #26850, #26817, #26840, #26852.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40686899679 at 9874141 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at c02ae48. This pull request is one of 1 merged since: #26840.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40692662131 at 4d6ff41 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at c02ae48. This pull request is one of 3 merged since: #26840, #26852, #26622.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This branch had an error being deployed

1 failed and 2 inactive deployments
artifacts — e9a2e009 Deployed Oct 28, 2026 by teamleaderleo via publish to R2 #71719
sentry-dsyms — e9a2e009 Deployed Oct 28, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #71719
ci-routing-agent — e9a2e009 Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #71719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant