Repository navigation
fix(settings): declare sidebar hover controls agent policy - #26840
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 953bd3b to compare; do not merge until green; see lane-rules |
|
Owned by an agent session · session |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
|
Bead |
|
Review (independent Codex gpt-6-astra xhigh, nx-sidebar-hover-policy-review): SHIP at e9a2e00 The independent session reviewed the complete base-to-head diff and found no P0–P2 issues. It confirmed one appearance-only setting entry in the settable policy, no refusal entry, and the matching generated schema row with Primary inspection also confirms the entire diff is exactly those two files, the generated patch matches fleet artifact |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40688911044 at 52bbe91 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40690021866 at 1e8fb3c failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40686899679 at 9874141 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40692662131 at 4d6ff41 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The base test
SettingsSchemaExportTests.everyKeyHasAnExplicitAgentPolicyreportedmissing → ["sidebar.controlsOnHover"]after f004cef added the setting without an agent-policy decision.Allow agents to set this appearance-only setting, matching the existing sidebar visibility controls, and refresh the generated settings export. No sidebar rendering or default changes.
Validation:
prepush-gate.py,git diff --check,pr-overlap, andpr-owner check-pushpassed.dee42f3df70d4c7d45323710ran at source head186bce421956c423c5997a3663f593df7cec01aa, exited 0, and produced artifactsha256:4439dcf4487992adc635c1aee8623ea1914ffb8abeee1b8d40457d3ce2da112e. Its nativeSettingsSchemaExportTestsran 5 tests, includingeveryKeyHasAnExplicitAgentPolicyandexportIsFresh, all passed;ManagedPreferencesManifestTestsran 4 tests and passed.schemas/settings/settings-schema.json, settingsidebar.controlsOnHover.agent_settablefromfalsetotrue; bot-only defaults/docs outputs were dropped.fef8942f67931d2b563778c8, refe9a2e009ee4875bdce5ff481714ba99530bec2ba, withCMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app; it exited 0 on the managed fleet.SettingsSchemaExportTestsran 5 tests, includingeveryKeyHasAnExplicitAgentPolicyandexportIsFresh, all passed. Summary digest:sha256:aa1c5e582ba683e20169b4a25b6084ac8483bfcf3afdd495354228ad42248a64.e9a2e009ee4875bdce5ff481714ba99530bec2ba: SHIP, no P0–P2 findings.Primary review: the actual two-file diff, generated-artifact checksum, clean worktree and pushed exact head were independently inspected; source-policy and exported metadata agree.
Remaining CI reds are outside the changed files:
Package dependency lists sortedreports the pre-existingCmuxNextAppimport ofCmuxNextDictationmissing fromPackage.swift; the release-notary job reports assertions about release workflows. The base release-notary job also fails these workflow checks. NeitherPackage.swift, the release workflows nor their tests changed in this PR. Exact-head Release compile, native settings-schema tests, export generation, generated drift and risk evidence passed.Risk: agents can now set/reset the same control-visibility toggle available to the user; privacy, network access, and destructive policy are unchanged.
No capture: this changes only the agent-policy table and its exported metadata; no sidebar rendering, setting default, or visible UI changes.
Agent session: agent session