Skip to content

cloud open-desktop: a description for action describe and MCP (fixes CloudActionDescriptionTests on base) - #26777

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ib/cloud-open-desktop-description
Oct 28, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ib/cloud-open-desktop-description

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

#23952 added the Cloud action cloudOpenDesktop (cmux cloud open-desktop, palette, CLI, MCP and the machine menu) without an entry in CloudActionDescriptions, so CloudActionDescriptionTests.everyCloudActionHasADescription fails on feat-cmux-next:

✘ Test everyCloudActionHasADescription() recorded an issue at CloudActionDescriptionTests.swift:14:13: Expectation failed: !((text → "").isEmpty → true → true)

(swift test job 122622565351, run 40629499671.)

This adds its description, written from the handler (CloudHandlers.openDesktop): the machine's noVNC page in a browser tab of a new workspace on this Mac, over the Cloud tunnel; refused when the machine has no desktop or address or the browser engine is unavailable; answers at once with no fields. It is the same kind of catalog text fix as the earlier Cloud action ones. No behaviour change: the text is only what cmux action describe and the MCP tool list show.

Risk: low. One catalog string.

No capture: the GUI never shows ActionDescriptor.description; it is agent-facing text for cmux action describe and the MCP tool list, so no screen changes.

Proof

  • Codex review (gpt-6-astra, xhigh): SHIP at 600d608, no findings.
  • Fleet suite runs: see the comment below once they report.

Agent session: agent session

🤖 Generated with Claude Code

…CloudActionDescriptionTests on base)

#23952 added cloudOpenDesktop (cmux cloud open-desktop) without an entry in
CloudActionDescriptions, so everyCloudActionHasADescription fails on
feat-cmux-next. This adds one, from the handler (CloudHandlers.openDesktop).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-cc8bff1c3ddb4ec353c5
@cursor

cursor Bot commented Oct 28, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 600d608: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26777 -f ref=ib/cloud-open-desktop-description -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-41dwvx created for this PR by the cmux coordinator.

@austinywang austinywang mentioned this pull request Oct 28, 2026
@teamleaderleo
teamleaderleo merged commit 6bf1b10 into feat-cmux-next Oct 28, 2026
164 of 174 checks passed
@teamleaderleo
teamleaderleo deleted the ib/cloud-open-desktop-description branch October 28, 2026 09:00
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 600d6088 Deployed Oct 28, 2026 by teamleaderleo via namespace autofix #5200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant