Repository navigation
feat(next): render sent user Markdown and compose message menus - #26660
teamleaderleo wants to merge 19 commits into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Not re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Gallery before/after for
States
Pick other states with a |
|
Bead |
|
Found 10 test failures on Blacksmith runners: Failures
|
4ed7390 to
2bee6c1
Compare
|
Review (subagent claude-opus-5-5 medium): SHIP at 1dbae59 Checked the Swift menu rebuild, the new Follow-ups:
|
|
Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base 1382711 to this head): SHIP at 54fb99c [P2] [follow-up] webviews/src/agent-session/acpmux/conversation/messageMenu.ts:155 - After “Send now” interrupts and continues a turn, the first summary can have |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (next-review patch-id; carried): SHIP at 46a9cf9 The independent SHIP at 54fb99c carries to this head: the PR's own change ( |
|
Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base b7aa4ec to this head): SHIP at 46a9cf9 [P2] [follow-up] webviews/src/agent-session/acpmux/conversation/messageMenu.ts:155 - After a “Send now” continuation, |
|
Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base afde3d7 to this head): SHIP at 128b6ac [P2] [follow-up] webviews/src/agent-session/acpmux/conversation/messageMenu.ts:164 - After a prompt interrupts and continues a turn, |
Keeps base's reply-time menu header (not on selection menus) and the chat part's Open on Right / Go to Chat beside this branch's row and session ids, Pin as chapter and selection actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-627034dbf10a04318c5c
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Status: final independent review, native compile reconciliation and current before/after media publication are owned by the coordinating lane.
Sent user bubbles render blockquotes, lists, inline/fenced code and links through the existing transcript Markdown renderer. Plain prompts retain the literal-text path; Copy and Edit retain the original Markdown source. Bubble spacing, colours and glass stay the same.
Leo: “where is the rendering for this :(” — his own sent quote showed literal
>lines in NEXT nightly1.0.0-nightly.4080221127101(a63986a4). This completes the existing request, “rendering actual quotes when I'm sending the response myself”.The survivor also retains its native transcript menu changes: Copy message, Copy message as Markdown, Quote in Reply, Attach selection as context, Pin as chapter and Fork from here, with Search the Web and Ask About This last. Pin state uses the rail's existing action, and stale session callbacks cannot affect a replacement session. Leo: “I feel like putting it at the very lowest bit makes sense”.
Canonical route stays
chat.quoteReply({markdown})→ComposerHandle.quoteReply(markdown), supplied by #26655. Composer insertion is outside this recovery. Claude desktop's transcript menu andtranscript-markdown-renderingcapture are the named private design references; private captures are never published.Validation
Frozen head:
8e0c5dda55f4d5d0821cf21a4b520c2397145d00; tree:ce59bcabc9eff282605b87b878ff2ada026c639f. Rebased onto9b7d6d9f93c44c90f690ae141a1a02b84777e155. This retained survivor is 14 files, including its 21-locale native menu table; the Markdown recovery adds only the renderer gate and focused fixtures/tests.04a561b1da813132c4e82d296dc417dd3bb4c788has exactly the frozen head's tree.85b76c63b5c9b95ddd1c6bc5c671d5172c2df911PromptText source in the same fixture; after uses the exact frozen tree. Publication is pending, and these browser captures do not claim a native-menu runtime check.Performance
No perf numbers: this changes Markdown rendering correctness, with functional assertions and preserved bubble styles; it makes no measured performance claim.
Prior composer interaction evidence
These existing captures exercise the registered action on combined source at
b95c200fae699529cb2bfda166daa1f07d38af93; they are not evidence for the frozen head's sent-bubble renderer or native menu. Fleet run 40664890704 passed eight light/dark composer interactions, full web check, localization scanners and web lint on that earlier source.Changelog
Changed: sent user messages render Markdown; the transcript context menu exposes explicit copy, quote, context, pin and fork actions.
Agent session: agent session