Repository navigation
Make conversation forking one step across entry points - #26619
Conversation
Default changesThis pull request changes 4 defaults at
Signed off on this commit by Merge receipt: merged as Regenerate the snapshot with |
|
Bead |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 17d64ea; does not block Gallery before/after for
States
Pick other states with a |
|
Owned by an agent session · session |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 80f135a SHIP
Read-only static review; no builds or tests run. Reported CI results were not independently verified. |
|
Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 6195022 BLOCK
Verification limits: reviewed the full exact-head diff and surrounding paths. Could not rerun browser or native tests: Bun, Swift, and webview dependencies are absent. |
# Conflicts: # webviews/src/agent-session/acpmux/conversation/TurnRows.tsx # webviews/src/agent-session/acpmux/conversation/UserBubble.tsx
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 5af5233 SHIP No concrete correctness findings in head Verification limits: read-only full diff and surrounding implementation review; reverse-patch and catalog JSON checks passed. Native/browser tests and app compilation could not run here because Swift, Bun, and web dependencies are unavailable. Pending integrated results remain unverified. |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fork now runs immediately from the message footer, message or empty-space context menu, chat header,
/fork, command palette and ⌥⌘Y. Every entry usesAgentForkDestination.default(currently Right); Option-click and the separate Fork to… item expose the seven existing destinations. A refused host open selects and focuses the fork. Hand off to… has its own menu group and explicitly retains its existing tab placement.The fork request still uses the parent's harness, model, mode and working directory. The single default remains
.rightpending #26582's session placement rule.AgentTabs+Fork.swiftis unchanged, preserving #26093's subagent placement work./forkAfter counts mean one activation of the exposed Fork command, excluding opening the surrounding menu/palette. Before counts are from the approved request, not instrumented timing.
Validation: the default-placement regression fails on the original base with eight expected assertions (receipt
603d4530b51c3e4aea0f6cc1). The original implementation passed six native suites (receipta469aea5b93c51ad0b292eba). Final verification and the repaired crash regression are recorded below.Real-app captures use the same completed fake-harness conversation on base and head. They run through WebKit's native click path because the capture driver's Chromium click did not supply the gesture ticket needed for folder trust. The product's engine default is unchanged. Reference: Claude desktop session overflow menu, using separate command groups; private reference imagery is not attached.
The context-menu test budget changes from 12 to 13 only for agent-chat and terminal-selection menus, accommodating the separately exposed Fork and Fork to… commands; all other menus retain 12.
A real header click created a distinct right-side session and the debug readback reported
composer_focused: trueandfocus: composer. Result capture.Risk: changes default fork placement from a tab to the shared right destination. No new timers, observers or animation loops; the weak-self destination-menu task finishes when its native menu closes. No per-token transcript work added.
Current verification:
5af5233f9cc56c41b2200b6b216550dbbdcd7725passes (receiptc55c15744a991c241575dfd4, 82 seconds). Final integrated web, static and browser checks also pass. Independent Astra review returned SHIP at that exact head.1aa9603a0419e35c2b19348fat exact final head5af5233f9cc56c41b2200b6b216550dbbdcd7725passed all four focused suites: AgentForkMenuTests (1), AgentPaneForkOwnTabTests (5), ForkConversationTests (10), and ActionSurfaceParityTests (12 reported, 2 skipped). Process exited 0. The earlier signal 11 is repaired by merged fix(next): retain Dock policy source through KVO teardown #27385, integrated at this head.The fork request and default destinations were verified through real-app interaction above. The modifier repairs have remote browser regressions; they have not yet been recaptured in the native app. The diff stays below 800 changed lines.
Agent session: agent session