Skip to content

measure: holder-dogfood.sh takes --vdisplay like split-spring.sh - #26584

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
fanout-infra/holder-dogfood-vdisplay
Oct 28, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
fanout-infra/holder-dogfood-vdisplay

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

holder-dogfood.sh now takes --vdisplay=HZ, as split-spring.sh and burst-bench.sh already do.

Why

The STRESS phase needs a 1600 x 1000 pt window. On a 1920 x 1080 host display the Dock leaves about 967 pt, so AppKit clamps the window. Both 2026-10-28 runs on a 1080p measure host failed STRESS that way: the window is [1600, 967] pt, not [1600, 1000]. The same failure in split-spring.sh went away with --vdisplay=120, which placed the window at the full 1600 x 1000.

What changes

  • --vdisplay=HZ compiles scripts/ci/frame-pacing/vdisplay.m and opens a 1920 x 1200 virtual main display at HZ for the run. It is held for at most 2 h, so the helper ends by itself even after a SIGKILL. The script logs the helper's ready line.
  • Each model's dogfood now runs in the background through a fifo to tee, and the script waits for both. A cancelled step (TERM, INT or HUP) therefore stops the dogfood and the helper at once. The log is complete before the JSON report reads it, and a tee failure still fails the step.
  • Without --vdisplay nothing changes except that wait.

Tests

  • bash -n passes.
  • The fifo, wait and trap pattern was checked under /bin/bash 3.2: 20,000 lines all logged with exit status 3 kept, and a TERM during a 30 s child cleaned up at once and exited 143.
  • Codex gpt-6-astra (high) review: SHIP at the head, after three FIX rounds (signal traps, deferred traps during a foreground pipeline, waiting for tee).
  • The fleet rerun at a green ref with --vdisplay=120 follows this merge.

Risk: low. The change is in a measurement script only; no app code.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds a --vdisplay=HZ option to holder-dogfood.sh so the STRESS phase runs on a 1920×1200 virtual display. On a 1920×1080 host the Dock leaves about 967 pt, so AppKit clamps the 1600×1000 pt STRESS window and the run fails; split-spring.sh already solved this with --vdisplay=120.

The dogfood now runs in the background through a fifo to tee, so a cancelled step (TERM, INT, HUP) stops the dogfood and the virtual display at once, and the log is complete before the JSON report reads it. Without --vdisplay, behavior is unchanged except for the extra wait.

Written for commit e28ce87. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 4 commits October 27, 2026 19:34
STRESS needs a 1600 x 1000 pt window; on a 1920 x 1080 host display the Dock
leaves about 967 pt and AppKit clamps it, so the STRESS shape fails.
--vdisplay=HZ opens a 1920 x 1200 virtual main display (vdisplay.m) for the
run and stops it on exit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
…ancel stops it and the display at once

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
@cursor

cursor Bot commented Oct 28, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e28ce87: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26584 -f ref=fanout-infra/holder-dogfood-vdisplay -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-7tlzkg created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit d7cf72e into feat-cmux-next Oct 28, 2026
176 of 182 checks passed
@teamleaderleo
teamleaderleo deleted the fanout-infra/holder-dogfood-vdisplay branch October 28, 2026 03:18
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40626998043 at 0341883 failed: cmux-next generated files.
Those jobs last passed at 46c2c64. This pull request is one of 2 merged since: #26584, #23952.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40626020108 at 0ab915d failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files.
Those jobs last passed at 46c2c64. This pull request is one of 2 merged since: #26584, #23952.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40627558915 at 47b4dbb failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files.
Those jobs last passed at 46c2c64. This pull request is one of 3 merged since: #26584, #23952, #26596.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40628944074 at 18af98c failed: cmux-next generated files.
Those jobs last passed at 46c2c64. This pull request is one of 4 merged since: #26584, #23952, #26596, #26609.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — e28ce87a Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #68833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant