Repository navigation
measure: holder-dogfood.sh takes --vdisplay like split-spring.sh - #26584
Conversation
STRESS needs a 1600 x 1000 pt window; on a 1920 x 1080 host display the Dock leaves about 967 pt and AppKit clamps it, so the STRESS shape fails. --vdisplay=HZ opens a 1920 x 1200 virtual main display (vdisplay.m) for the run and stops it on exit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
…ancel stops it and the display at once Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Bead |
|
Found 4 test failures on Blacksmith runners: Failures
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40626998043 at 0341883 failed: cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40626020108 at 0ab915d failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40627558915 at 47b4dbb failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40628944074 at 18af98c failed: cmux-next generated files. |
|
Shipped in:
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
holder-dogfood.sh now takes
--vdisplay=HZ, assplit-spring.shandburst-bench.shalready do.Why
The STRESS phase needs a 1600 x 1000 pt window. On a 1920 x 1080 host display the Dock leaves about 967 pt, so AppKit clamps the window. Both 2026-10-28 runs on a 1080p measure host failed STRESS that way:
the window is [1600, 967] pt, not [1600, 1000]. The same failure insplit-spring.shwent away with--vdisplay=120, which placed the window at the full 1600 x 1000.What changes
--vdisplay=HZcompilesscripts/ci/frame-pacing/vdisplay.mand opens a 1920 x 1200 virtual main display at HZ for the run. It is held for at most 2 h, so the helper ends by itself even after a SIGKILL. The script logs the helper's ready line.tee, and the script waits for both. A cancelled step (TERM, INT or HUP) therefore stops the dogfood and the helper at once. The log is complete before the JSON report reads it, and ateefailure still fails the step.--vdisplaynothing changes except that wait.Tests
bash -npasses.tee).--vdisplay=120follows this merge.Risk: low. The change is in a measurement script only; no app code.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds a
--vdisplay=HZoption toholder-dogfood.shso the STRESS phase runs on a 1920×1200 virtual display. On a 1920×1080 host the Dock leaves about 967 pt, so AppKit clamps the 1600×1000 pt STRESS window and the run fails;split-spring.shalready solved this with--vdisplay=120.The dogfood now runs in the background through a fifo to
tee, so a cancelled step (TERM, INT, HUP) stops the dogfood and the virtual display at once, and the log is complete before the JSON report reads it. Without--vdisplay, behavior is unchanged except for the extra wait.Written for commit e28ce87. Summary will update on new commits.