Repository navigation
PR4: plain tab plus with separate workspace chooser - #26558
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 400cb08; does not block |
|
Bead |
This comment has been minimized.
This comment has been minimized.
Sidebar-Look: Leo 2026-10-28 "put a chevron optional in the new workspace thing" Agent-Session: https://cmux.com/deeplink/agent?id=aid-a6121fd29acebb75ae0d
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex gpt-6-astra high, next-review): SHIP at 304921f No blocking findings. |
|
Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 5b5cdb8 BLOCK
|
…role An off-window SidebarIconButton reports AXUnknown on the CI minis, so theSidebarWorkspacePlusIsPlainAndItsNeighborOwnsTheChooser failed at its first expectation. It now checks that an AX press runs the + action directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ab1f035a409b977caceb
|
Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at 0d65861 BLOCK
|
…leading reserve Review of 5b5cdb8 and 0d65861 found two gaps in the new workspace chevron: - its VoiceOver label was a hard-coded English string; it is now sidebar.newWorkspace.options, translated for every locale the sidebar's New Workspace string carries; - on a narrow sidebar the chevron (and the Priority button it pushed left) could enter the titlebar's leading reserve, under the toolbar band that takes the clicks there. The chevron is the optional extra (the +'s right-click menu holds the same chooser), so it hides first and the row lays out as it did before the chevron existed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ab1f035a409b977caceb
|
Review (codex-review-box/gpt-6-astra high, lane-place): SHIP at 9870e73 SHIP No blocking findings. Static review and localization validation passed; macOS UI tests could not run because Swift/Xcode are unavailable. |
…ilered sidebar commits check-objc-selectors --probe --write on macOS 27.0.1 records the two super calls SidebarIconButton makes (crash-class rules: probe needed). The sidebar owner note logs 5b5cdb8 and 9870e73, which reached the branch without a Sidebar-Look: trailer (no change to the list's look). Sidebar-Look: no visual change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ab1f035a409b977caceb
|
Review (codex gpt-6-astra high, review-router): SHIP at a094d32 Scope: the follow-up delta 9870e73..a094d32 (selector probe table and sidebar owner note entries); the earlier SHIP covered 9870e73.
Agent session: agent session |
|
Review (codex gpt-6-astra high, review-router): SHIP at a094d32 Scope: the full PR diff, merge base 400cb08 to head a094d32 (the earlier SHIP at this head covered only the 9870e73..a094d32 delta).
Focused fleet runs (
|
|
Shipped in:
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40944977110 at db5340a failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
PR4: plain tab plus and separate new-workspace chooser
Leo (2026-10-28): “what's this? i mean put a chevron optional in the new workspace thing that specifies, i think? WHY WAS THIS NEW TAB BUTTON CHANGED TO BE A DROPDOWN????????????????”
This corrects the control ownership:
Base 7023445 already removed native new-terminal/new-browser creation buttons from every PaneToolbar; this PR keeps that base behavior.
Observed / Not run
git diff --check, prepush static checks, and the full Objective-C selector check passed (1007 superclass calls, 207 runtime keys, zero failures).Package compile passed at current head
304921f1facfe67d68e512d9b5b81e8ef27a3464(job7374b3945cec1223ec454f64, 156 seconds).Swift regression coverage exercises plain pane/screen plus controls, heavier held-plus ink, matching initial sidebar visibility, and keyboard/VoiceOver chooser activation. Fleet step
977ba7ad3aee69e721385f47started, but the bounded observer timed out without a verdict; no red/green runtime claim yet.No capture: the after image is still missing. The current-head capture build exited before its control socket answered (above), and the follow-up fix (5b5cdb8: the + and its chevron stay revealed and lit while their menu is open) changes a state that only exists while an NSMenu is tracking, which the capture fixture cannot hold open.
PaneTabBarControlsTests.theSidebarPlusAndChevronStayRevealedWhileTheirMenuIsOpencovers it instead.The nightly-before capture below succeeded. Current-head build
fdb9648f17f68c680b7a398ecompleted, but its app exited before the control socket answered, so no after image exists yet. Earlier base/head attempts failed at startup too. No private reference images are attached.Risk: the change is limited to creation controls and their activation paths. Workspace rows and stored layout are untouched. No new timer or observer.
Reference matched: Leo’s private 2026-10-28 newtab-plus and project-picker captures (not attached).
Before: Leo's nightly
f83ddd6b204221b1b019e67734cf129e8e431aee. The fixture uses the existingtabs.plusButton=alwayssetting and sidebar hover to reveal all creation controls; it creates two screens and two tabs on the second screen.Agent session: agent session