Repository navigation
composer: keep Fast mode in the picker - #26555
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 59d518f; does not block Gallery before/after for
States
Pick other states with a |
dc4a24a to
a6657c6
Compare
|
Bead |
|
Found 128 test failures on Blacksmith runners: Failures
...and 118 more test failures. View all on Blacksmith: run 40649297503, run 40649297551
|
|
Review (codex gpt-6-astra high, next-review): BLOCK at b75ad04
|
|
Shipped in:
|
…aude included (#31287) * cmux NEXT composer test: a bolt beside the model while Fast mode is on, Claude included (failing) Leo-ask: ask-6071cce53e Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-45ae2b39ea53027d31b2 * cmux NEXT composer: a bolt beside the model while Fast mode is on, every harness Leo 2026-10-23: "even on, I think Claude mode, you just want the lightning bolt to be right beside the model". #24151 drew it for Codex only and #26555 dropped it with the inline toggle; the toggle stays the menu's Fast mode row, the chip only marks the state. red: bun test test/composer-fast-toggle.test.tsx on base: 2 fail; green here: 8 pass. Leo-ask: ask-6071cce53e Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-45ae2b39ea53027d31b2 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
What changed
Leo asked for Fast mode to be tucked into the model picker. The compact picker and full picker now use the harness-reported Fast mode config option for every harness, including Codex. The separate lightning control is gone from chat and New Tab, while the native config id, on/off values, and current default remain unchanged.
Scope
Gallery variants
The composer gallery covers Claude and Codex Fast mode states, off and on, in chat and New Tab. The Codex variant now captures the before/after behavior: the model picker contains the toggle and the composer row has no lightning control.
Before and after
Actual React gallery captures, rendered on
gcp-agent-lane-1with Chromium at the same viewport per pair. Before is feat-cmux-nextc30fa03db4b0f4c3da53d7c52e7af9172a872249; after is the reviewed PR headffb90c3e667e95209dc1150cd2e311c9892ea539. The chat pair usesagent-pane.composer-pickers#model-menuat 640 × 560 CSS px; New Tab usesagent-pane.new-tab#model-picker-openat 760 × 560 CSS px. Both are gallery fixtures, not native fleet screenshots.Performance
No perf numbers: This changes the placement and state of a configuration control; it does not change runtime performance.
Validation
bun test src/agent-session/acpmux/FastModeState.test.ts test/composer-fast-toggle.test.tsx src/agent-session/acpmux/QuickModelMenu.test.tsx src/agent-session/acpmux/EffortPicker.test.tsx(21 pass, 162 expectations)CMUX_BROWSER_TESTS=1 bun test test/gallery-agent-pane-entries.test.ts --test-name-pattern="composer-pickers#fast-mode"(pass)agent-pane.composer#reasoning-codexfailed at the earlier head due to a static-fixture assertion and now passes.agent-pane.composer#file-not-attachedfails on both this head and current base c30fa03. Five nearby model/narrow/headline states also fail identically on that base.vp fmt --check,vp lint,vp check --no-fmt --no-lint,python3 scripts/cmux-next/prepush-gate.py(pass)Review (Astra independent, xhigh): SHIP at ffb90c3.
agent-identity footer
agent session