Repository navigation
Picker: keep Add harness in the harness strip - #26503
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 3f83053; does not block |
|
Found 28 test failures on Blacksmith runners: Failures
...and 18 more test failures. View all on Blacksmith
|
|
Bead |
|
Review (codex gpt-6-astra high, next-review): BLOCK at 1db2878
|
1db2878 to
8179506
Compare
add5126 to
f50777e
Compare
|
Orphaned: no activity for 12 h, and no lane holds a lease on it. The orphan sweep could not merge |
|
Owned by an agent session · took over from an earlier session · session |
…-add-harness # Conflicts: # webviews/test/model-menu-compact.test.tsx
|
Review (codex gpt-6-astra high, review-router): SHIP at 655b347 No blocking findings at this head (base merge plus conflict resolution reviewed with the full diff). Agent session: agent session |
|
Shipped in:
|
…rtcuts, folder profiles and fallback The compact menu's web version (QuickModelMenuFallback) is base's QuickModelMenu as it stands, and the native menu carries base's changes since: each model's effort as a side dropdown (#27948), the Chief's own-model menu, the Account switcher with Cmux under Provider (#28020), Add harness in the harness strip (#26503) and No models for an empty tab (#26962). Review fixes (Sol BLOCK at 124eada): - A digit on an empty search, or on the list, lands its numbered row instead of typeahead. - The full picker lists this folder's profiles natively. - An opening the native host refuses to show falls back to the web popup instead of closing. - Keys start on the list, not the rail, so Return in the search lands the first match. - Edits and picks made at an earlier revision of the open popup still land. - Native rail clicks during a search leave it (Astra BLOCK at 8f4777b). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-766f2935b39ba914eb08
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The picker keeps Add harness… in the existing harness strip. The compact and full pickers now end that strip with a clearly labelled + item; More models contains models only, and the model list no longer has a separate Add harness row.
Leo, word for word:
The + item is available in both the composer chat picker and New Tab picker, with the accessible name “Add harness…”. Existing model selection and harness rows remain unchanged. This is the d follow-up to #26071.
Keyboard behavior: the rail arrows reach the trailing Add action without changing the selected harness. Enter/Space keep native button activation. Returning to a harness restores focus even with a hidden search field. New Tab renders one Add action, and More models is absent when the harness has no extra models.
Validation:
dfdfc55265f4d5caefa8b8148618ee368382fc98(fix(composer): align search fields with menu rows #26589).add512615797846ae25d1f380f8fc5bbe260a1dc.a033e89; all three focused files pass atadd512615797without retries (model-picker-picks,QuickModelMenu,new-tab-add-harness-chip). The full webviews check passes: formatting, lint, typecheck, guards, and generated protocol.0.068107, head0.069632in both themes (the0.001525increase is ~2.2%); this is recorded as a base red and the disclosure source is unchanged.Gallery: new-tab.quick-model-menu/combined, new-tab.quick-model-menu/claude, new-tab.quick-model-menu/claude-more-models, agent-pane.model-picker/quick-menu
Before / after
Synthetic gallery captures from advisory run 40644096979, rendered at base
dfdfc552and the pre-repair visual headc588a33. The follow-up commits only repair keyboard activation and gallery assertions, so these visual states are unchanged at final headadd512615797; the captures contain no private data.The rail action is a
+Add harness item in the head; More models contains models only. The full picker and compact picker preserve the existing menu model list.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Keeps "Add harness…" in the harness rail so both the compact and full pickers end the strip with a clearly labelled
+item instead of a row in the model list.Written for commit 655b347. Summary will update on new commits.
Agent session: agent session