Repository navigation
fix(rust): refresh stale standalone Cargo.lock files (cmux-rd-host, ssh-terminal server) - #26484
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Bead |
|
Found 4 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6-astra high, next-review): SHIP at b90a1f4 No blocking findings. Python syntax and lockfile dependency references are valid. Full tests could not be rerun from the supplied snapshot because the planner script and Cargo manifests are absent. |
|
Owned by an agent session · session |
b90a1f4 to
c854602
Compare
cmux-app-manifest gained sha2 (module-store tree digests), so the sample server's --locked clippy/test could not resolve. Regenerated with cargo metadata; additions only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40638365379 at a3cf5fd failed: cmux-next fast tier (cargo). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Refreshes two standalone Cargo.lock files that no longer matched their path dependencies, so
cargo clippy --locked/cargo test --lockedfailed to resolve:cmux-tui/crates/cmux-rd-host/Cargo.lock, stale since the Rust advisory bump in c08d4b1.samples/apps/ssh-terminal/server/Cargo.lock:cmux-app-manifest(a path dependency) gainedsha2for module-store tree digests. This one only adds packages. It came to light because this PR touches the workspace planner, which schedules every Rust workspace.The workspace planner already follows path dependencies. Its regression coverage now also proves that a manifest-only change to a path dependency schedules every consuming workspace.
Validation:
python3 .github/scripts/test_rust_workspaces.py: 20 tests pass.cmux-rd-hostcargo clippy --locked --all-targets -D warningsandcargo test --lockedpass.ssh-terminal/servercargo clippy --locked --workspace --all-targets -D warningsandcargo test --locked --workspacepass with the regenerated lock.No visible UI change: lockfiles and a planner regression test only.
Agent session: agent session
🤖 Generated with Claude Code