Skip to content

fix(rust): refresh stale standalone Cargo.lock files (cmux-rd-host, ssh-terminal server) - #26484

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
cloud-setup-rdhost-lock
Oct 28, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
cloud-setup-rdhost-lock

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Refreshes two standalone Cargo.lock files that no longer matched their path dependencies, so cargo clippy --locked / cargo test --locked failed to resolve:

  • cmux-tui/crates/cmux-rd-host/Cargo.lock, stale since the Rust advisory bump in c08d4b1.
  • samples/apps/ssh-terminal/server/Cargo.lock: cmux-app-manifest (a path dependency) gained sha2 for module-store tree digests. This one only adds packages. It came to light because this PR touches the workspace planner, which schedules every Rust workspace.

The workspace planner already follows path dependencies. Its regression coverage now also proves that a manifest-only change to a path dependency schedules every consuming workspace.

Validation:

  • python3 .github/scripts/test_rust_workspaces.py: 20 tests pass.
  • Fast checks on Linux: cmux-rd-host cargo clippy --locked --all-targets -D warnings and cargo test --locked pass. ssh-terminal/server cargo clippy --locked --workspace --all-targets -D warnings and cargo test --locked --workspace pass with the regenerated lock.
  • Independent review (gpt-6-astra, high): SHIP.

No visible UI change: lockfiles and a planner regression test only.

Agent session: agent session

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 41b71e0: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26484 -f ref=cloud-setup-rdhost-lock -f platform=macos -f backend_mode=local

@socket-security

socket-security Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​cc@​1.10.09810093100100
Addedcargo/​openh264@​0.9.910010093100100

View full report

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 28, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-q9mb81 created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at b90a1f4

No blocking findings.

Python syntax and lockfile dependency references are valid. Full tests could not be rerun from the supplied snapshot because the planner script and Cargo manifests are absent.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

cmux-app-manifest gained sha2 (module-store tree digests), so the
sample server's --locked clippy/test could not resolve. Regenerated with
cargo metadata; additions only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
@teamleaderleo teamleaderleo changed the title fix(cmux-rd-host): refresh standalone Cargo.lock fix(rust): refresh stale standalone Cargo.lock files (cmux-rd-host, ssh-terminal server) Oct 28, 2026
@teamleaderleo
teamleaderleo merged commit a6434a0 into feat-cmux-next Oct 28, 2026
143 of 153 checks passed
@teamleaderleo
teamleaderleo deleted the cloud-setup-rdhost-lock branch October 28, 2026 05:29
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40638365379 at a3cf5fd failed: cmux-next fast tier (cargo).
Those jobs last passed at 8479514. This pull request is one of 2 merged since: #26484, #24259.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

This branch had an error being deployed

1 failed and 2 inactive deployments
sentry-dsyms — 41b71e08 Deployed Oct 28, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #69686
artifacts — 41b71e08 Deployed Oct 28, 2026 by teamleaderleo via publish to R2 #69686
ci-routing-agent — 41b71e08 Deployed Oct 28, 2026 by teamleaderleo via wait for same-key tree publisher #69686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant