Skip to content

Agent chat: compact, consistent message actions - #26374

Closed
teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
nx-message-actions-1027
Closed

teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
nx-message-actions-1027

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Message controls now share one compact action row: 24px hit targets, 16px glyphs, and no negative margin between Retry and its model chevron. User prompts, assistant footers, received messages and sent messages use the same component. Native pages ask the existing validated harness.symbol image cache for actual SF Symbols; galleries and older hosts use the icon-catalog fallback in the same box.

Leo, 2026-10-27: "why is the copy button and the refresh button so far apart?" and "not ... evenly spaced, compact, unified, concise, simple, well-placed".

The layout follows the compact controls in the Claude Code action-row reference. No new motion or menu timing. Open model menus keep the shared row visible.

Gallery: agent-pane.message-action-row (compact, narrow). Captures use public-safe fixture text and the catalog fallback; they prove geometry, not native SF rasterization.

Before After
Before: uneven message controls After: compact shared message controls
Claude Code referencecmux action rows
Claude Code compact message action-row referencecmux shared compact action rows

Validation: the Chromium regression first failed at 08720fc because Retry's chevron target was 14px rather than 24px. The same command now passes 2 tests / 51 assertions, including keyboard Retry and another-model selection. The SF-symbol cache and existing user-action tests pass 16 tests / 72 assertions. bun run check also passes (format, lint, 2,887-file typecheck and protocol checks). Gallery coverage has exactly the same two failing assertions and finding lists on base and head; the new components are covered. Existing native localization baseline drift makes verify-local.py red in untouched catalogs; this change adds no shipped strings.

Coordination: this leaves the generic floating-copy removal/right-padding repair to #26096 and the PR pills to #26082. Queued/received presentation is nx-chat's separate work. This PR preserves their action callbacks and does not change IncomingMessageCard or QueuedMessageCard.

Status: exact-head Codex xhigh review and CI reconciliation are pending with nx-chat; do not merge before that receipt.

Changelog

Fixed: Message copy, retry and other actions use compact, evenly spaced controls with native SF Symbols.
Agent session: agent session

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 583f651: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26374 -f ref=nx-message-actions-1027 -f platform=macos -f backend_mode=local

Gallery before/after for 583f651: the capture produced no images (run).

red: web / Web status; NEW: green on the base 3e56d06; do not merge until green; see lane-rules
red: web / react-apps-base-check (1); no finished base run on 3e56d06 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (3); no finished base run on 3e56d06 to compare; do not merge until green; see lane-rules
red: web / react-apps-base-check (4); no finished base run on 3e56d06 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 3e56d06 to compare; do not merge until green; see lane-rules

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026
@teamleaderleo

teamleaderleo commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · took over from an earlier session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-9he07y created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Found 98 test failures on Blacksmith runners:

Failures

Test View Logs
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build/
build_only must be a conjunctive exclusion on the helper, signing, and publication jobs
, and must not gate the unsigned app build
View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
src/pages/settings/layout.test.ts/layout.test View Logs
src/pages/settings/layout.test.ts/layout.test View Logs
test/accent-glass-invariants.test.ts/accent-glass-invariants.test View Logs
test/accent-glass-invariants.test.ts/accent-glass-invariants.test View Logs
test/agent-pane-agents-pill.test.ts/agent-pane-agents-pill.test View Logs
test/agent-pane-agents-pill.test.ts/agent-pane-agents-pill.test View Logs
test/agent-pane-mermaid.test.tsx/agent-pane-mermaid.test.tsx View Logs
test/agent-pane-mermaid.test.tsx/agent-pane-mermaid.test.tsx View Logs

...and 88 more test failures. View all on Blacksmith: run 40592339640, run 40592339676

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Orphaned: no activity for 15 h, and no lane holds a lease on it. The orphan sweep could not merge feat-cmux-next in: conflicts in webviews/src/agent-session/acpmux/conversation/TurnRows.tsx. Listed for a lane to resolve.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Codex gpt-6.1-sol, high, via the review router; full diff from merge base 22ca012 to this head): SHIP at 583f651.

No P1/P2 findings.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded by #27252, which landed the shared message footer row (MessageFooterRow: one 24px row for sent, received and reply messages, equal control slots, 16px glyphs, full-slot Retry chevron) that this PR set out to fix; #29124 and #31609 build on it. The SF Symbol icon rendering here was extra to the original ask and, if still wanted, belongs in a small new PR on top of MessageFooterRow.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 583f6518 Deployed Oct 27, 2026 by teamleaderleo via wait for same-key tree publisher #67266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant