Repository navigation
cmux NEXT: keep Bash agent commands in shell rows - #26368
teamleaderleo wants to merge 5 commits into
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 9b23615; does not block Gallery before/after for |
|
Found 17 test failures on Blacksmith runners: Failures
...and 7 more test failures. View all on Blacksmith: run 40720525243, run 40720525089
|
|
Bead |
|
Review (codex gpt-6-astra xhigh, next-review): SHIP at 4d7bb49 No blocking findings. |
|
Owned by an agent session · session |
|
Repair for the independent review BLOCK is in #26627 at Concurrent same-name parent shell/MCP starts now remain plain when child records lack call correlation. The committed regression reproduced 8 failures before repair; the same command now passes 23 tests. The broader focused suite passes 58 tests, web lint and the prepush gate pass. The replacement PR preserves these captures with their original SHAs and documents the conservative queued-MCP behavior. Final independent re-review and merge remain with the root owner; no merge performed. |
|
Orphaned: no activity for 12 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
Review (codex gpt-6-astra high, next-review): SHIP at 98b4910 No blocking findings. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Running
reach review-router 'codex exec …'in Bash currently replaces the command row with a Codex card and infers its model and host from the command. Bash now keeps its normal command row, including its raw command and output. Only an explicit acpmux child-session record can supply a session card's identity; structured subagent tools retain their existing behavior.Leo, 2026-10-27: "we don't want to have that sort of thing going on"
Takes back #25043: command syntax and stdout must not establish harness or session identity. The explicit child-session path from #25062 remains supported, with identity metadata taken only from the session record.
Validation:
cd webviews && bun test test/shell-agent-identity.test.tsfails all six cases at regression commitc65b829f88eddf7f98df737258404a58b102de36and passes all six at4d7bb4943641e44792ba5f0460369c6de1144345. The focused fold, parser and transcript replay suite passes 40 tests. Web checks (including lint, formatting and type checking), the pre-push gate and changed-file gallery coverage pass.Observed / Not run
Observed the production transcript replay retain the execute tool and its output for direct commands,
reachand command arrays, with Codex-looking output unable to create a session. Structured subagent metadata and recorded acpmux child sessions still create cards. The unscoped gallery coverage test reports existing coverage gaps; the six checks scoped to this PR pass.Hosted Chromium capture 40590006683 passed: eight real gallery PNGs cover running/completed states in light/dark at regression commit
c65b829f88eddf7f98df737258404a58b102de36and fixed head4d7bb4943641e44792ba5f0460369c6de1144345. All frames mounted, reported the exact commit, passed SHA256 transfer verification, and were visually inspected. Originals passed the publication helper's OCR privacy check. Native builds, native app dogfood and a live review-router session were not run.Reference:
cmux-design-references/apps/claude/live/transcript-tool-rows-and-task-list.pngandapps/codex/live/transcript-expanded-command-activity.pngfor shell rows;apps/claude/live/transcript-linked-session-card.pngfor a tracked session card. The new gallery story places an ordinary Bash call beside a real recorded child session.Gallery: agent-pane.shell-agent-identity/running, agent-pane.shell-agent-identity/completed
Changelog
Fixed: Bash commands that run another agent keep their normal command rows instead of gaining inferred agent cards.
Agent session: agent session