fix(webviews): keep model picker rail tabs round by teamleaderleo · Pull Request #26288 · manaflow-ai/cmux

teamleaderleo · 2026-10-27T16:42:30Z

The model picker harness rail rendered as rounded squares after #25796 changed its button radius to 6px. Restoring a 50% radius keeps every tab circular, including the selected tab, while preserving the existing equal-size rail layout.

Changelog

Fixed: keep model picker harness rail tabs round.

Verification

Red at e6525bd5f17: CMUX_BROWSER_TESTS=1 bun test test/model-picker-round-rail.test.ts — Chromium failed the existing round-rail assertion for all 14 tabs.
Green at c2c0a356ea9: same command — Chromium passed (1 pass, 0 fail; WebKit unavailable on the test host).
python3 scripts/cmux-next/prepush-gate.py — no new violations.

Observed / Not run

Observed: the focused browser regression passes after the one-line CSS fix, and the independent review shipped the exact head.
Not run: WebKit browser coverage was unavailable locally. The web lint wrapper is also blocked by the base tree's stale generated src/agent-session/acpmux/protocol/generated/methods.ts, unrelated to this CSS-only change.

Agent-Session: c2c0a35

Agent session: agent session

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Restores fully round tabs in the model picker harness rail, which had rendered as rounded squares since #25796 changed the button radius to 6px. Switching border-radius back to 50% keeps every tab circular, including the selected tab, while preserving the existing equal-size rail layout.

^{Written for commit 8abb80f. Summary will update on new commits.}

Agent-Session: https://cmux.com/deeplink/agent?id=aid-c8a948c72de792bbe9ff

cursor · 2026-10-27T16:42:35Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

github-actions · 2026-10-27T16:42:45Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review c2c0a35: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26288 -f ref=nx-ci-react-minimap -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 8abb80feed (run 40556952950 attempt 1): 1 code, 1 unknown.

Job	Verdict	Why
web / react-apps-base-check (1)	code	a web test failed
web / react-apps-check	unknown	no known signature; failed step: `Check webview test shards`

Failures:

seen on other PRs agent-pane-background-tasks.test.ts the summary card lists the chat's background tasks: running ones first, the finished folded: failed (job)
seen on other PRs agent-pane-chat-unavailable.test.ts loading never shows the unavailable text: a slow attach, then a machine still connecting: failed (job)
seen on other PRs agent-pane-chat-unavailable.test.ts a chat whose machine goes offline names it, says when it was last seen, and Reconnect opens it: failed (job)
seen on other PRs agent-pane-hairline-focus.test.ts composer at 1x: focus is the resting hairline a step brighter, no ring: failed (job)
seen on other PRs agent-pane-hairline-focus.test.ts newtab at 1x: focus is the resting hairline a step brighter, no ring: failed (job)
seen on other PRs agent-pane-hairline-focus.test.ts composer at 2x: focus is the resting hairline a step brighter, no ring: failed (job)
seen on other PRs agent-pane-hairline-focus.test.ts newtab at 2x: focus is the resting hairline a step brighter, no ring: failed (job)
seen on other PRs agent-pane-hairline-focus.test.ts under Increase Contrast a focused edge keeps the resting edge, never a dimmer one: failed (job)

Matched log lines

web / react-apps-base-check (1): (fail) the summary card lists the chat's background tasks: running ones first, the finished folded [1031.85ms]

Not re-run automatically: web / react-apps-base-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 221e6b4; do not merge until green; see lane-rules
red: web / react-apps-base-check (1); no finished base run on 221e6b4 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 221e6b4 to compare; do not merge until green; see lane-rules

Gallery before/after for 8abb80f: 16 states rendered, 0 images differ, 1057 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40556952396 -R manaflow-ai/cmux -n gallery-advisory-26288-8abb80feed325d326a549ce9c288bf3691566f70 (then read gallery-review.json)

States

State	Theme	Status	Diff	Picked by
`agent-pane.composer-pickers/closed`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/closed`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/pill-rail`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/pill-rail`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-menu`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-menu`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-more`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-more`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-focus`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-focus`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-press-drag-release`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/model-press-drag-release`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/effort-menu`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/effort-menu`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/effort-focus`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.composer-pickers/effort-focus`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-default`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-default`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-default-effort-menu`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-default-effort-menu`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-update-pending`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-update-pending`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-picked-high`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-button-default-effort/profile-picked-high`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-row`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-row`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-row-open`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-row-open`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-submenu`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-submenu`	Apple System Colors	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-submenu-open`	Apple System Colors Light	unchanged	0%	own `modelPicker.css`
`agent-pane.model-menu-providers/provider-submenu-open`	Apple System Colors	unchanged	0%	own `modelPicker.css`

_{Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.}

blacksmith-sh · 2026-10-27T16:48:54Z

Found 64 test failures on Blacksmith runners:

Failures

Test	View Logs
`nightly.yml must derive the embedded key and sign every appcast through the helper/` `nightly.yml must derive the embedded key and sign every appcast through the helper`	View Logs
`test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test`	View Logs
`test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test`	View Logs
`test/agent-pane-chat-unavailable.test.ts/agent-pane-chat-unavailable.test`	View Logs
`test/agent-pane-chat-unavailable.test.ts/agent-pane-chat-unavailable.test`	View Logs
`test/agent-pane-hairline-focus.test.ts/agent-pane-hairline-focus.test`	View Logs
`test/agent-pane-hairline-focus.test.ts/agent-pane-hairline-focus.test`	View Logs
`test/agent-pane-jump-latest-motion.test.ts/agent-pane-jump-latest-motion.test`	View Logs
`test/agent-pane-jump-latest-motion.test.ts/agent-pane-jump-latest-motion.test`	View Logs
`test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test`	View Logs

...and 54 more test failures. View all on Blacksmith: run 40556952950, run 40556953006

^{Need help on this PR? Tag @codesmith-bot with what you need.}

teamleaderleo · 2026-10-27T16:53:12Z

Bead cx-3ct0ti created for this PR by the cmux coordinator.

teamleaderleo · 2026-10-27T18:00:49Z

Review (codex gpt-6-astra xhigh, next-review): SHIP at c2c0a35

No blocking findings. The change is limited to the tested rail-tab selector, whose equal width and height make border-radius: 50% circular without affecting layout or interaction.

teamleaderleo · 2026-10-28T00:24:53Z

Owned by an agent session · session

teamleaderleo · 2026-10-28T00:25:37Z

Superseded by #26071, which carries the named readable rail; this icon-only 50% radius fix is no longer wanted.

fix(webviews): keep model picker rail tabs round

c2c0a35

Agent-Session: https://cmux.com/deeplink/agent?id=aid-c8a948c72de792bbe9ff

teamleaderleo temporarily deployed to ci-routing-agent October 27, 2026 16:42 — with GitHub Actions Inactive

github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026

teamleaderleo temporarily deployed to ci-routing-agent October 27, 2026 16:53 — with GitHub Actions Inactive

teamleaderleo temporarily deployed to ci-routing-agent October 27, 2026 16:56 — with GitHub Actions Inactive

Merge branch 'feat-cmux-next' into nx-ci-react-minimap

8abb80f

teamleaderleo temporarily deployed to ci-routing-agent October 27, 2026 18:07 — with GitHub Actions Inactive

teamleaderleo closed this Oct 28, 2026

teamleaderleo mentioned this pull request Oct 28, 2026

Fix the composer model picker's harness entries and readability #26071

Merged

Navigation Menu

Repository navigation

fix(webviews): keep model picker rail tabs round - #26288

fix(webviews): keep model picker rail tabs round#26288
teamleaderleo wants to merge 2 commits into
feat-cmux-nextfrom
nx-ci-react-minimap

teamleaderleo commented Oct 27, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cursor Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited by cmux-bot Bot

Loading

Uh oh!

blacksmith-sh Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 28, 2026

Uh oh!

teamleaderleo commented Oct 28, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 27, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Verification

Observed / Not run

Summary by cubic

Uh oh!

cursor Bot commented Oct 27, 2026

Bugbot needs on-demand usage enabled

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited by cmux-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blacksmith-sh Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 28, 2026

Uh oh!

teamleaderleo commented Oct 28, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 27, 2026 •

edited by cubic-dev-ai Bot

Loading

github-actions Bot commented Oct 27, 2026 •

edited by cmux-bot Bot

Loading

blacksmith-sh Bot commented Oct 27, 2026 •

edited

Loading