Repository navigation
acpmux docs: ownerToken on begin, cancel and owned refs - #26063
Merged
Merged
Conversation
#25840 made a forPrompt upload removable only by a cancel carrying its ownerToken, and made upload.owned carry that token instead of true. The contract doc still described the earlier shape. It now says what begin returns, what cancel removes, what owned's value is, and the app's path: begin forPrompt, keep the token natively, leave owned out of prompt refs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 27, 2026 08:47 — with
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
|
Found 1 test failure on Blacksmith runners: Failure
|
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 08:59 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
sentry-dsyms
October 27, 2026 08:59 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 09:03 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 09:05 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 09:07 — with
GitHub Actions
Inactive
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Docs only:
cmux-tui/crates/acpmux/docs/prompt-uploads.mdnow matches what #25840 shipped for upload owner tokens.What #25840 does (
hub/file_uploads.rsbegin/cancel,prompt_uploads.rsowned_refs):file_put_beginwithforPrompt: trueanswers anownerToken.forPromptupload is removed, finished or not, only by afile_put_cancelthat carries that token. Any other upload is removed by cancel only while unfinished.upload.ownedin a prompt ref is the token string; any other value (trueincluded) deletes nothing.The doc still said
owned: trueand "cancel removes a finished upload". This PR fixes those three places and writes down the app's path, which a native implementer asked about:forPrompt: trueand keep theownerTokennatively.ownedout of prompt refs, so a refused prompt deletes nothing and a retry names the same finished uploads.file_put_cancel.No code change. Risk: none at runtime.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.