Skip to content

acpmux docs: ownerToken on begin, cancel and owned refs - #26063

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
hb-acpmux/doc-owned-token
Oct 27, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
hb-acpmux/doc-owned-token

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Docs only: cmux-tui/crates/acpmux/docs/prompt-uploads.md now matches what #25840 shipped for upload owner tokens.

What #25840 does (hub/file_uploads.rs begin/cancel, prompt_uploads.rs owned_refs):

  • file_put_begin with forPrompt: true answers an ownerToken.
  • A forPrompt upload is removed, finished or not, only by a file_put_cancel that carries that token. Any other upload is removed by cancel only while unfinished.
  • upload.owned in a prompt ref is the token string; any other value (true included) deletes nothing.

The doc still said owned: true and "cancel removes a finished upload". This PR fixes those three places and writes down the app's path, which a native implementer asked about:

  1. Begin with forPrompt: true and keep the ownerToken natively.
  2. Leave owned out of prompt refs, so a refused prompt deletes nothing and a retry names the same finished uploads.
  3. Send the token with every file_put_cancel.

No code change. Risk: none at runtime.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

#25840 made a forPrompt upload removable only by a cancel carrying its
ownerToken, and made upload.owned carry that token instead of true. The
contract doc still described the earlier shape. It now says what begin
returns, what cancel removes, what owned's value is, and the app's path:
begin forPrompt, keep the token natively, leave owned out of prompt refs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-1288bbb2b5d2f5c6b66a
@cursor

cursor Bot commented Oct 27, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e5fa384: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26063 -f ref=hb-acpmux/doc-owned-token -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026
@teamleaderleo
teamleaderleo merged commit 3ba0cb5 into feat-cmux-next Oct 27, 2026
138 of 143 checks passed
@teamleaderleo
teamleaderleo deleted the hb-acpmux/doc-owned-token branch October 27, 2026 08:49
@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

3 inactive deployments
artifacts — e5fa384d Deployed Oct 27, 2026 by teamleaderleo via add the Windows daemon to the tree #63313
sentry-dsyms — e5fa384d Deployed Oct 27, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #63313
ci-routing-agent — e5fa384d Deployed Oct 27, 2026 by teamleaderleo via wait for same-key tree publisher #63313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant