Repository navigation
ci(nightly): reuse only a stripped Ghostty helper; a hit skips the strip (fix-forward) - #26000
Merged
Merged
Conversation
#25885 moved the helper strip into build-nightly-ghostty-cli-helper. On a #25930 reuse hit nothing is built, so the strip failed on a missing file, and helpers reused from before #25885 are unstripped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 27, 2026 06:41 — with
GitHub Actions
Inactive
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 27, 2026 06:42 — with
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
|
Bead |
|
Found 1 test failure on Blacksmith runners: Failure
|
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fix-forward for a base break: since #25885 landed, every nightly-next run that gets a #25930 reuse hit fails in
build-nightly-ghostty-cli-helper(run 40460194731:strip: 'nightly-helper/ghostty': No such file).Leo: "BUT WHY DO WE NEED TO REBUILD THE FUCKING GHOSTY HELPER IF IT NEVER CHANGED". The reuse itself worked: the lookup ran on Linux in 9 s and the helper job ran on Linux with no Mac. The failure came only from the new strip step.
Cause
#25885 moved the helper's
strip -S -xfrom prepare-nightly-variant into the helper job. That step runs even on a reuse hit, where nothing was built. Also, any helper reused from before #25885 is unstripped, so skipping the step alone would ship different bytes.Change
ghostty-cli-helper-stripped-build=<sha>marker. Older resolvers printedghostty-cli-helper-build=and are no longer trusted.strip -S -x, whose byte-identity with the old prepare-nightly-variant pass ci(nightly-next): prepare the nightly variant off the Macs, byte-identical #25885 established) both run.tests/test_nightly_ghostty_helper_cache.pyadds stripped/unstripped provenance cases and requires the strip step to be skipped on a hit.Risk
Low, and limited to which earlier helper gets reused. Anything unproven is a miss, and a miss is the #25885 path.
Agent session: agent session
🤖 Generated with Claude Code