Skip to content

ci(nightly): reuse only a stripped Ghostty helper; a hit skips the strip (fix-forward) - #26000

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix-helper-reuse-strip
Oct 27, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix-helper-reuse-strip

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Fix-forward for a base break: since #25885 landed, every nightly-next run that gets a #25930 reuse hit fails in build-nightly-ghostty-cli-helper (run 40460194731: strip: 'nightly-helper/ghostty': No such file).

Leo: "BUT WHY DO WE NEED TO REBUILD THE FUCKING GHOSTY HELPER IF IT NEVER CHANGED". The reuse itself worked: the lookup ran on Linux in 9 s and the helper job ran on Linux with no Mac. The failure came only from the new strip step.

Cause

#25885 moved the helper's strip -S -x from prepare-nightly-variant into the helper job. That step runs even on a reuse hit, where nothing was built. Also, any helper reused from before #25885 is unstripped, so skipping the step alone would ship different bytes.

Change

Risk

Low, and limited to which earlier helper gets reused. Anything unproven is a miss, and a miss is the #25885 path.

Agent session: agent session

🤖 Generated with Claude Code

#25885 moved the helper strip into build-nightly-ghostty-cli-helper. On a
#25930 reuse hit nothing is built, so the strip failed on a missing file,
and helpers reused from before #25885 are unstripped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-85ca59f74f02d81734c3
@cursor

cursor Bot commented Oct 27, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 8c4581c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26000 -f ref=fix-helper-reuse-strip -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-54h2o7 created for this PR by the cmux coordinator.

@github-actions github-actions Bot added the risk:high Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit f30aa1d into feat-cmux-next Oct 27, 2026
135 of 140 checks passed
@teamleaderleo
teamleaderleo deleted the fix-helper-reuse-strip branch October 27, 2026 07:07
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 8c4581c9 Deployed Oct 27, 2026 by teamleaderleo via wait for same-key tree publisher #62794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant