[teamleaderleo]

Problem

API-key detection treated any non-empty environment value as ready. A truncated, whitespace, or control-character value survived onboarding until the first Connect or prompt failed.

Change

Validate environment key shape during provider detection and report malformed values as unknown, so Accounts can direct the person to replace the key before starting a chat. The resolver remains authoritative and still rejects invalid secrets.

Validation

Added provider detection regression coverage for empty, short, and newline-containing values. Swift tests/build run through the project’s macOS CI path.

Before/after: Accounts now shows Unknown for malformed environment credentials instead of Signed in/Key found.

No capture: this changes credential checks only (Settings > Accounts status and Save validation), with no layout or style change.

No capture: the change only picks which existing Accounts status label shows for a malformed environment API key (Unknown instead of Signed in/Key found); it draws no new UI, and the capture scenes run with no provider keys in the environment, so that state cannot be shown there. ProviderDetectionSourcesTests and AccountsActionOutcomeTests cover it.

[teamleaderleo]

Bead cx-947sg created for this PR by the cmux coordinator.

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review ba02d0a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25978 -f ref=lane/ux-credentials-api -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 400cb08; does not block

[blacksmith-sh]

Found 6 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmpb4wvap0c/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpuf8fnf29/summary-fail.json (live):/summary-fail.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Review (codex gpt-6-astra xhigh, next-review): BLOCK at db82aef

• ProviderDetector.swift:54 marks a provider unknown if any environment alias is malformed. Gemini’s resolver uses the first non-empty alias, so a valid GEMINI_API_KEY plus malformed GOOGLE_API_KEY is incorrectly shown as unknown and prompts for replacement. Validate only the effective first key.

[teamleaderleo]

Orphaned: no activity for 12 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged feat-cmux-next in at ecace50. A later pass queues it for the merge hub if it is reviewed, small and red only on base reds.

[teamleaderleo]

Review (codex gpt-6-astra high, review-router): BLOCK at ecace50

VERDICT: BLOCK

1. Packages/macOS/CmuxNext/Sources/CmuxNextCodeRouter/Detection/ProviderDetector.swift:54 — Any malformed Gemini alias forces .unknown, even when the higher-priority GEMINI_API_KEY is valid and the resolver would use it. Accounts incorrectly requests replacement credentials.

2. Packages/macOS/CmuxNext/Sources/CmuxNextCodeRouter/Detection/ProviderDetector.swift:54 — Generic validation accepts a printable 16-character ANTHROPIC_API_KEY without the required sk-ant- prefix. Accounts reports .signedIn, then Connect immediately fails invalidFormat.

Agent session: agent session

[teamleaderleo]

Owned by an agent session · took over from an earlier session · session

[teamleaderleo]

Review (codex gpt-6-astra high, review-router): SHIP at ba02d0a

No findings. Earlier blockers fixed: only the key Connect sends is judged (a malformed GOOGLE_API_KEY no longer hides a valid GEMINI_API_KEY); detection and Connect share one format rule (an Anthropic key without sk-ant- reads unknown); Save refuses a malformed key. ProviderDetectionSourcesTests and AccountsActionOutcomeTests pass on a fleet Mac at this head.

VERDICT: SHIP

Agent session: agent session

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4093446036501 (6c1a5ab8bf)
• cmux NEXT nightly 1.0.0-nightly.4093534569301 (9ccc194b46)
• cmux NEXT nightly 1.0.0-nightly.4093630103101 (58286343a8)
• cmux NEXT nightly 1.0.0-nightly.4094037008001 (fcfd1d87dd)