Skip to content

ci(cmux-next): the REF capture names a Swift driver by its module, not its target - #25903

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
darling-capture-module
Oct 27, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
darling-capture-module

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

DEV daily run 40446615480 at 9198239 is the first capture after #25866, and it came out incomplete with "missing": ["cmux-next"] (1 of 134 modules). The frontend lines for that module are in the log. The SwiftDriver task line names the target (SwiftDriver cmux-next normal arm64 ... (in target 'cmux-next')), but frontend lines are matched by -module-name, and the app target compiles as -module-name cmux. Every package target has the same target and module name, so only the app goes unmatched, and every DEV capture would come out incomplete. The Linux whole-app proof needs a complete one.

  • drivers_and_lines takes a driver's module from the -module-name of the builtin-SwiftDriver line under its task, and falls back to the target name.
  • The log file is now closed after reading; it caused a ResourceWarning in the tests.

Tests

python3 tests/test_cmux_next_hybrid_ref_capture.py. The first commit changes the fixture's app driver to the real shape (target cmux-next, module cmux). That is red at de3d1aa, with ['cmux-next'] missing, as in the real run. The second commit turns it green: three runs in a row, also under -W error::ResourceWarning.

Observed / Not run

Ran: the test file (red, then green) and prepush-gate. I also ran the old and new matcher on the 40446615480 compile job's log. The old one finds cmux-next missing and the new one finds the app module cmux, with no target name in the list. The Actions job log also reports two package modules as missing under both matchers, because a byte-order mark keeps its timestamp prefix on their lines. The capture reads the raw xcodebuild log, which has no prefix, and the real run listed only cmux-next.
Not run: a capture with this change. The next dispatched DEV daily produces it.

Changelog

none

🤖 Generated with Claude Code

Agent session: agent session


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

teamleaderleo and others added 2 commits October 26, 2026 21:16
…th module cmux, as in the real log

Red at de3d1aa: the capture reports missing ['cmux-next'], as DEV run
40446615480 did, though its frontend lines are there under -module-name cmux.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a1351026211d556f5a03
…t its target

DEV run 40446615480 (9198239) captured INCOMPLETE with missing ['cmux-next']:
the SwiftDriver task line names the target (cmux-next) and the frontend lines
the module (-module-name cmux), so the app never matched and every DEV capture
would be incomplete. A driver is now the -module-name of its builtin-SwiftDriver
line (the target when it has none). On that run's log, 1 missing becomes 0.
The log is also closed after reading (a ResourceWarning in the tests).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a1351026211d556f5a03
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 306d312: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25903 -f ref=darling-capture-module -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo
teamleaderleo merged commit 53a3662 into feat-cmux-next Oct 27, 2026
149 of 163 checks passed
@teamleaderleo
teamleaderleo deleted the darling-capture-module branch October 27, 2026 04:22
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-1ip10 created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

teamleaderleo added a commit that referenced this pull request Oct 27, 2026
…s nightly-steps scripts

Takes #25903 (a SwiftDriver task's module is its builtin-SwiftDriver line's
-module-name: the app target is not its module) and base's nightly.yml size
work (#25879). The three REF capture run blocks move to
scripts/ci/nightly-steps/hybrid-ref-{decide,start,finish}.sh, so this PR adds
about 6 KB to nightly.yml instead of 12; the tests read them back in place
(tests/nightly_workflow_text.py). The nightly decide step's have lookup joins
the DEV one in the GITHUB_TOKEN polling allowlist (30 s in all).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f6b9335f650995bf635b
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 306d3127 Deployed Oct 27, 2026 by teamleaderleo via wait for same-key tree publisher #62152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant