Repository navigation
ci(cmux-next): the REF capture names a Swift driver by its module, not its target - #25903
Merged
Merged
Conversation
…th module cmux, as in the real log Red at de3d1aa: the capture reports missing ['cmux-next'], as DEV run 40446615480 did, though its frontend lines are there under -module-name cmux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a1351026211d556f5a03
…t its target DEV run 40446615480 (9198239) captured INCOMPLETE with missing ['cmux-next']: the SwiftDriver task line names the target (cmux-next) and the frontend lines the module (-module-name cmux), so the app never matched and every DEV capture would be incomplete. A driver is now the -module-name of its builtin-SwiftDriver line (the target when it has none). On that run's log, 1 missing becomes 0. The log is also closed after reading (a ResourceWarning in the tests). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a1351026211d556f5a03
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 27, 2026 04:18 — with
GitHub Actions
Inactive
Collaborator
Author
|
Bead |
|
Found 1 test failure on Blacksmith runners: Failure
|
teamleaderleo
added a commit
that referenced
this pull request
Oct 27, 2026
…s nightly-steps scripts Takes #25903 (a SwiftDriver task's module is its builtin-SwiftDriver line's -module-name: the app target is not its module) and base's nightly.yml size work (#25879). The three REF capture run blocks move to scripts/ci/nightly-steps/hybrid-ref-{decide,start,finish}.sh, so this PR adds about 6 KB to nightly.yml instead of 12; the tests read them back in place (tests/nightly_workflow_text.py). The nightly decide step's have lookup joins the DEV one in the GITHUB_TOKEN polling allowlist (30 s in all). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f6b9335f650995bf635b
This was referenced Oct 27, 2026
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
DEV daily run 40446615480 at 9198239 is the first capture after #25866, and it came out incomplete with
"missing": ["cmux-next"](1 of 134 modules). The frontend lines for that module are in the log. The SwiftDriver task line names the target (SwiftDriver cmux-next normal arm64 ... (in target 'cmux-next')), but frontend lines are matched by-module-name, and the app target compiles as-module-name cmux. Every package target has the same target and module name, so only the app goes unmatched, and every DEV capture would come out incomplete. The Linux whole-app proof needs a complete one.drivers_and_linestakes a driver's module from the-module-nameof thebuiltin-SwiftDriverline under its task, and falls back to the target name.Tests
python3 tests/test_cmux_next_hybrid_ref_capture.py. The first commit changes the fixture's app driver to the real shape (targetcmux-next, modulecmux). That is red at de3d1aa, with['cmux-next']missing, as in the real run. The second commit turns it green: three runs in a row, also under-W error::ResourceWarning.Observed / Not run
Ran: the test file (red, then green) and prepush-gate. I also ran the old and new matcher on the 40446615480 compile job's log. The old one finds
cmux-nextmissing and the new one finds the app modulecmux, with no target name in the list. The Actions job log also reports two package modules as missing under both matchers, because a byte-order mark keeps its timestamp prefix on their lines. The capture reads the raw xcodebuild log, which has no prefix, and the real run listed onlycmux-next.Not run: a capture with this change. The next dispatched DEV daily produces it.
Changelog
none
🤖 Generated with Claude Code
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.