[teamleaderleo]

HOLD: held for dogfooding (structural sidebar change: a drag into the sidebar from Home). Do not land on a SHIP until the dogfood hold is lifted.

Leo, 2026-10-21 (his exact words):

• "WHERE IS CHIEF IN THE SIDEBAR WHERE IS CHIEF AS OPTIONAL GUI CAN YOU TALK TO CHIEF"
• "IT ALREADY IS AFCCESSIBLE IN F***ING HOME"
• "IAM SAYHING TOFIGN OPTIONALLY MOVE IT BACK AND FORTH ON THE FING SIDEBAR"
• "IT KINDA IS A FING SIDEBAR ROW... BUT IT'S NOT ON BY DEFAULT YOU CAN JUST DRAG IN A CHIEF AND HAVE IT FING BE DISPLAYED MOVED AROUND THE QUICK ACCESS THING OF IT LIKE A SPECIAL WORKSPACE"

Leo-ask: ask-02828fbad5
Leo-ask: ask-c2df0efe0c
Leo-ask: ask-97431a8bca
Leo-ask: ask-05fd281019

Part 1 of 2 carried over from #23933 (which conflicted with 3,309 base commits and failed base's new pre-push gates). Part 2 is the drag out and the pending Chief: #25420. This PR is stacked on #25420 (its base branch): its review found that drag-in alone could add a second Chief (placement read only the top band, and a Chief added before the daemon answered counted as unplaced), which #25420 fixes with document-wide placement and the pending Chief. The Chief item stays off by default; Home is unchanged.

Sidebar owner: the sidebar-owner agent (a590). plans/cmux-next/sidebar-owner.md gets a "Chief item" target row and a log line in the same commit (Sidebar-Look: trailers on both commits).

What changes

• Drag in from Home. Drag the Chief's row or pinned tile sideways out of Home's conversation list and it becomes a drag into a window's sidebar. Over the sidebar the list shows its drop outline; releasing there adds the Chief item (sidebar.item.add {chief}, the top rows, as Add to Sidebar). A Chief already placed is not added again. Other conversations keep Home's own pin drag.
• It keeps its look anywhere. Moved into a group, Pinned or a machine list, the Chief's row keeps its picture, status and badge (SidebarItemListRowView takes the item's SidebarItemInfo; the bridge describes listed built-ins), and a status or unread change patches the drawn row.
• Unread dot. The Chief item shows the blue dot exactly when Home dots its conversation (unread messages or Mark as Unread, never muted), unless a badge counts subagents that need you.

How the drag session is built (the gate findings on #23933's ChiefDragSession)

• ChiefDragIn lives in CmuxNextAgentLanes (no new CmuxNextApp file). Home's page owns one instance; no static active singleton. While a drag runs, its monitor holds the instance and lets go when the drag ends, so closing Home's page mid-drag leaves no monitor or ghost behind.
• One local event monitor handles moves, the release, Escape, a lost release (the next press) and the app going inactive (its applicationDeactivated appKitDefined event, as TooltipPresenter does). No NotificationCenter observer, no MainActor.assumeIsolated.
• The App gives it a Host (LinkDragSession.chiefDragOut, next to the window lookup it uses): the sidebar under a screen point, whether another drag runs, and the drop. TopHomePageView gains one call and does not grow (god-file ceiling).
• The Chief item's App host is one function, SidebarSectionHandlers.chiefHost. The App binds it and the unread tests follow it, so dropping the unread binding fails them.
• CmuxNextAgentLanes now depends on CmuxNextTabs for LinkDragGhost.
• App growth: existing App files only (LinkDragSession, SidebarSectionHandlers, SidebarBridge+Sections). The gate warns; it refuses nothing.

Codex review rounds on this PR: BLOCK at aa1ebe3, e310d9a, 1550a52 and c13e1f1; SHIP at f5fafea (receipts below). Their placement and pending-add findings were code #25420 fixes, so this PR is now stacked on #25420. Their drag-lifetime, unread-test, file-size and listed-row color findings are fixed here (a listed Chief draws the sidebar's status colors and Home's blue unread dot). Two findings were answered without code, and the reviewer accepted both: an app switch mid-drag cancels (the list's contract since 2026-10-20), and the cached placement is current before the next event.

Overlap (pr-overlap): #24371 (pinned workspaces as rows) touches SidebarItemListRowView, SidebarDocListing, SidebarDocProjection and SidebarSectionHandlers for a different change; #24513 (group rail) is merged.

Screenshots

A real app capture (cmux-ci capture, Blacksmith macOS). Home's Chief row is dragged sideways over the sidebar with debug.mouse and held there, not released.

	Light	Dark
Before (#25420's head 1491f61: Home's own pin drag, nothing reaches the sidebar)
After (this PR, built at 4f7b2dd, whose code matches the head: the Chief's pill over the sidebar, which shows its drop outline)

Known nit, not fixed here: the shared LinkDragGhost pill truncates "Chief" to "C…f" in this capture. Its width comes from the label's intrinsic width; that sizing is shared with link drags. It goes in a follow-up.

Changelog

Added: drag the Chief from Home into the sidebar; placed anywhere, it keeps its picture, status and unread dot.

Observed / Not run

• Pre-push gate at the head: no new violations (app-size warnings only).
• Fleet steps (cmux-ci, package-test-lane): red at each test commit, green for the six Chief suites and app compile at the head. Details in the comments below.

Agent session: agent session

🤖 Generated with Claude Code

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 3095471: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25418 -f ref=chief-sidebar-3/drag-in -f platform=macos -f backend_mode=local

Default changes

No defaults change at 3095471eebf1.

[teamleaderleo]

Owned by an agent session · session

[teamleaderleo]

Owned by an agent session · session

[teamleaderleo]

Bead cx-v538t created for this PR by the cmux coordinator.

[teamleaderleo]

high-signal review link / link is red on 16 of 18 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

[teamleaderleo]

Fleet evidence for #25418:

• Red at the test commit d9641be (step chief-drag-in-red-d9641be7a7f7): the test build fails as expected. ChiefDragIn, listedBuiltIns, isUnread and the listed row's info do not exist yet.
• First green attempt at 2755f1a (step 70b4fabb40f8d4a2b73d8c7a) failed to build: two test files lacked import CmuxNextAgentActivity (AgentLaneStore). Fixed in aa1ebe3.
• Green at aa1ebe3 (step ecfb1654debb77670ebddc2d, aws-m4pro-6). All 7 suites passed: ChiefDragInTests, ChiefListedRowTests, ChiefSidebarUnreadTests, ChiefSidebarItemTests, HomeUnreadIndicatorTests, MouseDownSelectsTests, SidebarLookContractTests.
• App compile at 2755f1a passed (cmux-ci compile-check --app, job 9500a6a083c71bf80ac5f21c). aa1ebe3 changes only test imports.
• Captures: the fleet build for cmux-ci capture failed on the Linux pool before compiling (webviews needs bun 1.4.4 or newer ... is bun 1.4.2), at base and at the head alike. That is fleet infra, not this PR. I'll retry.

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[teamleaderleo]

Review (codex gpt-6-astra xhigh): BLOCK at aa1ebe3

1. SidebarModel+TopItems.swift:16-21 derives Chief placement only from top-level layout.firstItem. A Chief placed inside a group or machine list is therefore reported as unplaced. ChiefDragIn.swift:108 then sends another sidebar.item.add, creating a duplicate or refusal when the user drags that listed Chief again.

2. Optimistic item changes are invisible to the placement projection. SidebarDocStore.swift:244-249 builds the projection from confirmed records, and SidebarDocProjection.swift:125-139 drops rows whose item record has not echoed yet. Before an item.add echo arrives, another drag sees isPlaced == false and sends a second add; pending removals have the same race. Pending item updates are also rejected by SidebarDocStore+LayoutOps.swift:139-140.

3. Legacy top-band Chief drags can still strand the sidebar. In the non-document-list path, SidebarRegionView.swift:337-353 installs only tile-local drag callbacks, while SidebarRegionView+Drag.swift:108-125 has no global pointer-end monitor. Dragging a Chief sideways and releasing over another window or desktop never calls finishDrag, leaving the row hidden/stuck. This is the cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 legacy release defect.

4. ChiefDragIn.swift:43-57 installs an NSEvent local monitor, but cleanup exists only in finish (:101-109) and there is no deinitializer fallback. If the Home page/window is destroyed during an active drag, the monitor remains registered and the drag ghost is not closed.

5. ChiefSidebarUnreadTests.swift:42-44 does not prove the muted case: when muted == true, it waits for chief.status.unread to become true, times out, then asserts false. The test passes even if the unread binding is removed entirely.

Checked

• Listed Chief row status/unread patching: fixed by SidebarRowIndex.patchItemInfo and the live-row test.
• Old stale autoscroll finding: the current shared handoff cancels the source pin drag before transfer; the old SidebarListView+DragOut path is absent.
• Wrong unread source and mark propagation: fixed through HomeSidebarSource.unreadConversations and onMarksChanged.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 placement and optimistic-echo findings: still present as findings 1–2.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 legacy top-band release and monitor-lifetime findings: still present as findings 3–4.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 test-binding concern: production binding is present, but the muted test remains non-probative as finding 5.

[teamleaderleo]

Review (codex gpt-6-astra xhigh): BLOCK at e310d9a

1. The unread regression tests still bypass the production binding. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/ChiefSidebarUnreadTests.swift:29 constructs its own host with the correct unread closure. It never invokes SidebarSectionHandlers.bind. Removing the production unread argument at SidebarSectionHandlers.swift:42, or restoring the old row-unread closure, breaks the sidebar’s Mark-as-Unread behavior while these tests remain green. The prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 binding-test finding remains unresolved.

2. The revised muted test fails when its persisted trigger mark already exists. Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/ChiefSidebarUnreadTests.swift:46 sets "other" unread to force observation after changing unobserved debugRows. That mark uses UserDefaults.standard and is never cleared. On a subsequent run, makeSidebarSource() reloads it, and setMarkedUnread(true, "other") returns without mutation. The observer therefore retains unread == true, and the test times out despite correct production behavior. Isolate and restore the fixture’s marks, and guarantee an actual observed transition.

3. The Home-page addition still violates the enforced file-size ceiling. Packages/macOS/CmuxNext/Sources/CmuxNextApp/TopPages/TopHomePageView.swift:114 grows the file from 528 to 542 lines. scripts/cmux-next/check-no-godfiles.sh permits inherited excess only when the file does not grow; its ceiling remains 480 lines with 20% slack. This change fails that rule. Move the wiring into a focused file. The corresponding prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 finding remains unresolved for this file.

Checked

• Previous aa1ebe30 findings 1–3: document-wide placement, optimistic Chief projection/action resolution, and legacy-band release handling are fixed in the stacked tree.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 listed-row refresh and stale-autoscroll findings: fixed through targeted reconfiguration and stopping autoscroll outside.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 tile release coordinates, cross-window releases, legacy removal, and legacy monitor lifetime: fixes cover both document and older-band paths.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 pending removal, duplicate adds, stale pending fields, overbroad built-in projection, and refused-removal recovery: addressed by synchronous placement checks, stable Chief identity, intent-keyed pending records, and withholding label edits until confirmation.
• cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 unread-source/mark-propagation defect: production binding is corrected; badge precedence is correct. Its binding-test gap remains finding 1.
• Previous owner-loss finding: strong retention survives owner destruction; handled endings clear ownership, remove the monitor, and close the ghost. No additional concrete lifetime defect identified statically.
• Previous muted false-positive finding: the true-to-false assertion fixes it, but introduces finding 2.
• Prior oversized AppServices.swift and SidebarListView+Drag.swift are unchanged by this PR; Home-page growth remains finding 3.
• Supplied diff matches the exact base/head; git diff --check passes. No added forbidden concurrency/observer/singleton/animation calls found. No macOS build or runtime tests run.

[teamleaderleo]

Review (codex gpt-6-astra xhigh): BLOCK at c13e1f1

1. SidebarListView+PointerEnd.swift:27-29 and SidebarRegionView+PointerEnd.swift:13-21: app deactivation still fails the drag-out contract. Start dragging a placed Chief outside the sidebar, hold the button, then switch apps with Cmd-Tab (or another activation interruption) and release elsewhere. The document path’s pointerFocusLost() cancels without finishDragOut; the legacy band has no deactivation cleanup, so its reorder, hidden tile, and release monitor remain until another in-app event. The Chief is therefore left placed or the drag remains alive.

2. Packages/macOS/CmuxNext/Sources/CmuxNextAgentLanes/ChiefDragIn.swift:110: the completion guard uses cached chief.isPlaced rather than the synchronous document projection. Remove the Chief, then immediately drag it from Home back into a sidebar before followTopItems observes the mirror’s removal. chief.isPlaced can still be true, so finish returns without calling host.drop() and the Chief remains removed. If the cache updates first, SidebarLayoutService.document can still contain the old confirmed item and SidebarLayoutPlanner.add returns no operation. This is the pending-removal ordering race from cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933.

Checked

• Listed Chief live-row refresh: fixed with patchItemInfo, row indexing, observation, and coverage.
• Stale autoscroll, document-wide placement, tile release coordinates, pending-Chief resolution, duplicate adds, Chief-only optimistic filtering, pending-edit gating, and refused-removal replay recovery: fixed; pending-removal drag ordering remains finding 2.
• Cross-window release handling and legacy monitor teardown: fixed while the app remains active; deactivation remains finding 1.
• Home unread and Mark-as-Unread propagation, including the production binding test and muted fixture isolation: fixed.
• Listed Chief status colors and unread-dot color: fixed and tested.
• Prior god-file ratchet: fixed/unchanged in the stacked tree; Home wiring was extracted without net growth.
• Exact hashes and git diff --check verified. No macOS Swift build/tests were available in this environment.

---

Response (no code change for either; the PR is rebased onto #25420's head c401d69, new head f5fafea):

• 1: an app switch while the button is held is not a release beside the sidebar, so the drag ends with nothing removed. That is the list's contract on base since Leo's 2026-10-20 report (pointerFocusLost: "the window or the app loses focus with the button still down ... the gesture ends"); this PR keeps it, and the Chief staying placed is the safe outcome (Remove from Sidebar still takes it off). The older band needs no deactivation hook: under the mouse grab you accepted in cmux NEXT sidebar: drag the Chief out to remove it; a Chief just added draws before its echo (2/2 of #23933) #25420's round 5, its tile still gets the mouse-up after a Cmd-Tab, and a lost one ends at the next press (endStaleDrag).
• 2: not reachable. chief.isPlaced and layout.document follow the store through main-actor observation (followTopItems's ObservationStream, SidebarDocMachines.follow's shown), whose jobs run on the main queue before the run loop dispatches the next event. A drag in from Home takes a mouse-down, drags and a mouse-up, each its own event, after the remove's own event: both are current by the release. The add action also checks placement synchronously on the drawn document (SidebarDocStore.current?.placesItem).

[teamleaderleo]

Fleet evidence at f5fafea (rebased onto #25420 c401d69, no change of its own): all 8 Chief suites pass (ChiefDragIn, ChiefListedRow, ChiefSidebarUnread, ChiefSidebarItem, ChiefPendingRemove, ChiefSidebarPlacement, ChiefTileDragOut, ChiefListedDragOut), step 2783295ed880ffe8cc0b14c6; app compile check passed (cmux-ci compile-check --app).

[teamleaderleo]

Review (codex gpt-6-astra xhigh): SHIP at f5fafea

No blocking findings.

Checked

• Exact 22-file diff against c401d69 matches pr.diff; git diff --check passes.
• Prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 listed-row refresh, status colors and unread-dot color: fixed, with targeted reconfiguration and live-row assertions.
• Prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 document-wide placement, optimistic placement, pending-item action resolution and duplicate adds: fixed in the stacked tree.
• Prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 stale pending fields, dropped edits, overbroad built-in projection and refused-removal recovery: addressed by Chief-only pending records, withholding edits until confirmation, and intent-keyed settlement. Rechecked reload settlement, answered revisions and restored ancestor groups.
• Prior cmux NEXT sidebar: drag the Chief in from Home, move it anywhere, drag it out to remove it #23933 stale autoscroll, tile release coordinates, legacy-band removal, cross-window releases and monitor lifetime: fixed. Both tile paths forward release coordinates; legacy teardown removes its monitor.
• Prior unread-source, Mark-as-Unread and binding-test findings: fixed. Tests exercise the production host factory, require the muted true-to-false transition, and reset persisted trigger marks. Badge precedence is preserved.
• Prior file-size findings: Home remains 528 lines; the earlier oversized AppServices and drag files do not grow here.
• Round-4 arguments accepted: app deactivation cancels the document-list gesture by its existing contract; the legacy tile retains its release callback. I found no concrete event/job sequence establishing the claimed remove-then-drag cache failure. Gesture-owned ChiefDragIn retention ends through release, Escape, deactivation or the next press.
• No new blocking main-thread calls, DispatchQueue.main.async, NotificationCenter observers, stateful singletons or ungated animations found.

Static review only; macOS builds, tests and screenshots were not run.

[teamleaderleo]

Review (codex gpt-6-astra high): SHIP at 7c2b1b3

1. No merge-introduced defects found.

Checked:

• All four hand resolutions preserve both sides’ intent; documentation rows remain intact.
• Chief host binding survives; remote-machine chats remain unbound.
• Preview-feature filtering and listed-built-in observation coexist correctly.
• Listed-row patches and needs-you refresh both run.
• All named cleanly merged files and affected Sources/Tests callers remain compatible with the new base.
• git diff --check passes.

Static review only; no builds or tests run.

[teamleaderleo]

Review (codex gpt-6-astra high): SHIP at 82d5905

1. No merge-induced correctness defect found.

Checked:

• Both parent diffs and supplied remerge.diff; no hand resolution.
• Overlapping code: Package.swift, TopHomePageView.swift, SidebarListView+Layout.swift, and SidebarView+Observation.swift.
• Home drag handoff, sidebar hit testing, drop action, cancellation, and duplicate-placement guard remain connected.
• SidebarSectionHandlers.chiefHost, unread observation, listed-item info, and status/badge patching remain compatible with the new base.
• Relevant Sources and Tests callers of changed APIs; the required CmuxNextTabs dependency survives the merge.
• Static review only; no builds or tests run.

[teamleaderleo]

Orphaned: no activity for 17 h, and no lane holds a lease on it. The orphan sweep could not merge feat-cmux-next in: conflicts in Packages/macOS/CmuxNext/Sources/CmuxNextApp/SidebarSections/SidebarSectionHandlers.swift, plans/cmux-next/sidebar-owner.md. Listed for a lane to resolve.