Repository navigation
cmux NEXT: keep Priority dragged chats in place - #25231
teamleaderleo wants to merge 7 commits into
Conversation
…ile the others rank Red on base: the Priority view has no drag (a row's press only opens the chat) and the ranking has no placement, so an idle chat always sinks below the unread ones (Leo 2026-10-21). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba7-3152-78b2-bfdf-bb6eb0d5a053&host=cosmic-gray
Leo 2026-10-21: "the click and drag doesn't quite work for moving guys up... some sort of basic baked-in priority view thing sends your chat down since you're idle whereas upper ones are unread". A Priority row now drags past the sidebar's drag threshold (a click still opens the chat). The drop records the chat's place in the Priority marks (AgentPriorityMarks.placed, saved with the other marks); the ranking puts placed chats back at their places and ranks the rest around them, so an idle chat the person moved up no longer sinks below unread ones. A placed idle chat stays past the idle horizon like a pinned one. The Priority view, its tiers and every default stay as they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba7-3152-78b2-bfdf-bb6eb0d5a053&host=cosmic-gray Sidebar-Look: no visual change Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a1754c-46d3-7d00-943d-9ccb740653c6&host=gcp-codex-lane-5
|
Found 9 test failures on Blacksmith runners: Failures
|
|
|
|
Bead |
|
|
|
Closing this split PR per stale-PR reconciliation. Its work is superseded by the remaining split replacements; no merge is requested here. |
|
Orphaned: no activity for 15 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Review (codex gpt-6-astra xhigh, next-review): SHIP at be50989 No blocking findings. |
|
|
|
Review (codex gpt-6-astra xhigh, next-review): BLOCK at f0a2e45
|
|
Superseded by #28075, a carry of this PR that fixes its exact-head BLOCK: in the Priority row, presses on the title and preview were routed to the row. The carry adds a regression assertion for that. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
This is replacement piece 1 for #24177, limited to the core held-place drag fix and its regression coverage.
Fixes #24177
The Priority drag persists the dropped order through subsequent ranking updates, using the existing marks persistence path. The tests cover a dragged row keeping its place while other rows rank around it, including the no-op and persistence-facing action assertions.
Validation:
python3 scripts/cmux-next/prepush-gate.pypassed at46a01209c7025.git diff --checkpassed.Agent session: big-red
Need help on this PR? Tag
@codesmith-botwith what you need.