Repository navigation
web lane base reds: the cmux-next docs references, the docs-search fixture, and acpmux's bundled catalog - #25180
Conversation
…(base red) `web/tests/next-docs.test.ts` is red on `feat-cmux-next`: the CLI and MCP reference last matched the action catalog at cf81808, and the catalog has moved many times since (`remote.openRemote`, `sidebar.item.toggleArchive` and others), while the settings reference misses `agentPane.display.environment.placement`. Nothing regenerates them on a base push, so the `CI / web / Web tests` shards fail on every PR that pulls that lane in, and `web/tests/docs-search-cache.test.ts` fails with them. Written by `bun web/scripts/export-next-docs.ts`, the generator the test's own `expect(buildCliReference(...)).toEqual(...)` compares against. No hand edits. ### Observed / Not run Observed: at `origin/feat-cmux-next`, the generator rewrites both files to these bytes, so both assertions' inputs were stale. Not run: the web Bun suite itself (no `bun install` for `web/` on this host); CI's web lane runs it on this PR. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a174e4-3868-7f51-8f3d-21b34ad270b2&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Owned by chief-fix-4 on huge-blue · session |
|
Found 8 test failures on Blacksmith runners: Failures
|
|
Bead |
`cmux-next no new generated files` errors on a PR that edits a tracked generated file no "committed" generator and no baseline line covers, and both next-docs references are exactly that: git tracks them (cf81808) and generated-files.json has no entry for `bun web/scripts/export-next-docs.ts`. So the regeneration this PR is, which is the only way to make web/tests/next-docs.test.ts green, cannot pass that guard without the lines. The baseline is defined as "the generated files git still tracks that no committed generator covers", and the base tracks both, so this is the guard's own door for them; its other two (a new committed export in generated_outputs.py, a widened committed generator) are refused on purpose, because outputs may only move out of git. The cutover that gitignores these and generates them with the docs removes both lines again. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a174e4-3868-7f51-8f3d-21b34ad270b2&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…r imports (base red) `web/tests/docs-search-cache.test.ts` is red on `feat-cmux-next`: its fixture symlinks `app`, `i18n`, `messages` and `node_modules` into a temp `web/` and runs `tools/build-docs-search.mjs` there, but cf81808 gave that generator three imports under `../data/next-docs/` (the generated CLI and settings references and `pages`). The fixture cannot resolve them, so every build in the test dies with "Cannot find module '../data/next-docs/cli-reference.generated.json'" before any assertion runs, which is the `CI / web / Web tests (2/4)` and `(4/4)` red on every PR that pulls the web lane in. `data` joins the symlinked directories. It is read-only in the fixture, like the other four; nothing in the test writes under it. ### Observed / Not run Observed: the import list in web/tools/build-docs-search.mjs:15-17 against the fixture's symlink list at web/tests/docs-search-cache.test.ts:55, and the CI log's module-resolution failure naming exactly that path. Not run: the test itself (no `bun install` for `web/` on this Linux host, and the test needs pagefind from node_modules); CI's web lane runs it on this PR. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a174e4-3868-7f51-8f3d-21b34ad270b2&host=huge-blue
|
|
`web/tests/model-catalog.test.ts` "the checked-in catalog > acpmux bundles the same catalog" is red on `feat-cmux-next`: it asserts the two files are byte-identical, and #24631 added `inlineFast: true` to the nine OpenAI models in `web/data/model-catalog/snapshot.json` without the bundled copy. That is the `CI / web / Web tests (4/4)` red on every PR that pulls the web lane in. `web/tools/refresh-model-catalog-snapshot.ts` writes one body to both paths, so the snapshot is the source of truth and the bundled copy is its copy; this is `cp web/data/model-catalog/snapshot.json cmux-tui/crates/acpmux/catalog/models-v1.json`, nothing else. The only difference was those nine `inlineFast` flags, and `inlineFast` is read by the composer's model picker in `webviews/`, not by acpmux, which serves the bytes: offline and first-run acpmux now offers the same inline Fast toggle as the live feed, which is what #24631 intended. ### Observed / Not run Observed: `cmp` on the two files now reports no difference; the structural diff before this commit was exactly nine `"inlineFast": true` lines under the `openai` provider's models. Not run: the web Bun suite (no `bun install` for `web/` on this host); CI's web lane runs it on this PR. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a174e4-3868-7f51-8f3d-21b34ad270b2&host=huge-blue
…li-reference-fresh
The base merge added the setting; the generated reference follows the schema. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-24ce2bb1cc47fb95fa20
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
|
|
Review (GPT-6.1-sol): SHIP at 4af43a0 Independent review (Codex,
|
…engine-row Generated-file conflicts resolved, not hand-merged: - scripts/ci/generated-files-baseline.txt: base's version. #25180 landed both next-docs baseline lines, so this branch's own line is redundant. - Localizable.xcstrings: base's file with this branch's six chiefEngine keys spliced in as text, so every other byte matches base (792 insertions, 0 deletions). No key changed on both sides. - web/data/next-docs/settings-reference.generated.json: regenerated by web/scripts/export-next-docs.ts from the merged schema (count 493). - schemas/settings-export/settings-schema.sources.sha256: left at this branch's stamp; the fleet settings export rewrites it next. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-24ce2bb1cc47fb95fa20
…engine-row One generated-file conflict, not hand-merged: the settings source stamp (schemas/settings-export/settings-schema.sources.sha256) is left at this branch's value; the fleet settings export rewrites it in the next commit. The two web/data/next-docs references are regenerated by web/scripts/export-next-docs.ts from the merged schema (count 495). Picks up #23945 and #25180. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-24ce2bb1cc47fb95fa20
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Three reds of the
CI / web / Web testslane are red onfeat-cmux-next, so the lanefails on every PR that pulls it in. Each is one commit here.
1. The two cmux-next docs references are stale (
web/tests/next-docs.test.ts).web/data/next-docs/cli-reference.generated.jsonlast matched the action catalog atcf81808; the test's own diff names
remote.openRemote,sidebar.item.toggleArchiveand more (603 → 607 MCP tools, 685 → 689 verbs). The settings reference missed
agentPane.display.environment.placement. Both rewritten by their own generator,bun web/scripts/export-next-docs.ts— the samebuildCliReference/buildSettingsReferencethe test asserts against. No hand edits.2. The docs-search fixture cannot resolve the generator's imports
(
web/tests/docs-search-cache.test.ts). It symlinksapp,i18n,messagesandnode_modulesinto a tempweb/and runstools/build-docs-search.mjsthere, butcf81808 gave that generator three
../data/next-docs/imports, so every build inthe test died on module resolution before any assertion ran.
datajoins the symlinks.3. acpmux's bundled model catalog is not the snapshot
(
web/tests/model-catalog.test.ts, "acpmux bundles the same catalog"). #24631 addedinlineFast: trueto the nine OpenAI models inweb/data/model-catalog/snapshot.jsonwithout the bundled copy, and the test asserts byte-identity.
web/tools/refresh-model-catalog-snapshot.tswrites one body to both paths, so this isa
cpfrom the snapshot.inlineFastis read by the composer's model picker inwebviews/, not by acpmux, which serves the bytes: offline and first-run acpmux nowoffers the same inline Fast toggle as the live feed.
4.
scripts/ci/generated-files-baseline.txtgains the two next-docs references, becausecmux-next no new generated fileserrors on a PR that edits a tracked generated file no"committed" generator covers — which is what a regeneration is. The baseline is defined
as exactly that set and the base tracks both files; the guard's other doors (a new
committed export, a widened committed generator) are refused on purpose. The cutover that
gitignores them removes the lines again.
Changelog
none
Observed / Not run
Observed: at
origin/feat-cmux-nextthe docs generator rewrites both references toexactly these bytes;
cmpon the two catalog files now reports no difference; theimport list in
web/tools/build-docs-search.mjs:15-17against the fixture's symlinklist;
python3 scripts/ci/generated_files_guard.py checkgoes from two errors to noneand
tests/test_generated_files_guard.pypasses (20 tests);prepush-gate.pyreportsno new violations.
Not run: the web Bun suite itself (this Linux host has no
bun installforweb/, andthe docs-search test needs pagefind from
node_modules); CI's web lane runs all three onthis PR. Reds 2 and 3 are each confirmed as pre-existing by the shard logs of an
earlier head of this PR, which touched only generated JSON.
Owner note:
cmux-tui/crates/acpmux/catalog/models-v1.jsonis PL-acpmux's area(guardrails
ownerwarning). The change is a byte copy from the file the refresh tooldeclares as its source; no acpmux source changes.
Overlap: #23984 also regenerates
settings-reference.generated.json(it adds a setting).Generated files take either side on a conflict and the base autofix regenerates them.
Agent session: huge-blue