Repository navigation
cmux NEXT scrollbars: the last SwiftUI scroll views take the thin scroller; two AppKit cards follow the system - #25051
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e61cd8d to compare; do not merge until green; see lane-rules Tour of The path-selected recorder failed for core-after, core-before; see the run artifact and failed manifests. Path-selected interactions
Core UI (before): FAILED — 16 ok, 3 failed, 1 unavailable
Failed steps: 5. Split right Screenshots (12)1. Launch
Failed steps: 5. Split right Screenshots (12)1. Launch Tours are data in |
|
Owned by claude-sr2/base-red-checks on cosmic-gray · session |
|
Found 85 test failures on Blacksmith runners: Failures
...and 75 more test failures. View all on Blacksmith: run 40154415785, run 40154415837, run 40154415885
|
|
Bead |
…n scroller; two AppKit cards follow the system SCROLLBARS-THIN ratchet debt from check-scrollbars.sh on the tip: - .thinScrollers() on the content of the SwiftUI ScrollViews in HomeGroupInfoView (members, add contacts), ChiefMemoryInspectorView (lines, detail), BrowserDownloadsPopup, VaultListView and WorkspaceTodoPageView. - ExtensionsMenuView and SidebarPullRequestCard no longer force scrollerStyle = .overlay: SystemScrollers.follow sets the same overlay, auto-hiding style (vertical only, so no ThinScroller swap) and keeps it after a "Show scroll bars" change, as the other browser panels do. - BackgroundActivity.gallery.css drops its custom scrollbar-color. The ReportsBasket views are left to the AppKit port of those files (#25031). Sidebar-Look: no visual change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1708f-432e-7f23-a9e8-11c5945da2f6&host=cosmic-gray
e9e563e to
caa5183
Compare
|
Shipped in:
|
































![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
This clears the "Scrollbars thin, one style" ratchet debt (
scripts/cmux-next/check-scrollbars.sh, a warn-only base red in "cmux-next checks"), SCROLLBARS-THIN..thinScrollers()is added to the content of each ScrollView that lacked it:HomeGroupInfoView(members, add contacts)ChiefMemoryInspectorView(lines, detail)BrowserDownloadsPopupVaultListViewWorkspaceTodoPageView, which now imports CmuxNextDesignExtensionsMenuViewandSidebarPullRequestCardno longer forcescrollerStyle = .overlay. Both now callSystemScrollers.follow, as the other browser panels do. It sets the same overlay, auto-hiding style (vertical only, so there is no ThinScroller swap) and keeps that style after a "Show scroll bars" change. The commit carriesSidebar-Look: no visual changefor the sidebar card.BackgroundActivity.gallery.cssdrops its customscrollbar-color.ReportsBasketViewandReportsBasketDetailare left to cmux NEXT feed: the Labs reports basket is AppKit (No new SwiftUI) #25031, which ports them to AppKit.AgentCLIIntentLedgerList(false positive is fixed in the checker in fix(cmux-next checks): pre-push gate fixture, manifest reader, Browser waivers, scrollbar List false positive (base reds) #25032.On the tip,
check-scrollbars.shdrops from 14 hits to those 3.Compile:
cmux-ci compile-check --apppassed at e9e563e (job 4be662e85a3c9f6433af75ea). The final head only changesfollowThintofollow.No capture: every surface here uses the overlay scroller, which is hidden at rest; before and after stills are the same.
Screenshots: none attached. Every surface here uses the overlay scroller, which is hidden at rest, so before and after stills are the same. None of the capture states (
cmux-ci capture --list-states) opens these surfaces. What changes is that these scrollers now follow the shared thin style while scrolling and under "Show scroll bars: Always".Risk: low. The changes are view modifiers and scroller setup, with no data or layout logic. The
.thinScrollers()probe is a background view that takes no hits.🤖 Generated with Claude Code
Agent session: cosmic-gray