Repository navigation
cmux-next settings: New Tab clock, stopwatch, greeting and quote get an agent policy and strings (base red) - #25009
Conversation
… get an agent policy and strings SettingsSchemaExportTests failed on base: the four tabs.newTabWidgets keys had no agent policy and their titles and help were missing from Localizable.xcstrings, so the PR autofix could not regenerate the settings exports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16f9b-2fcb-7c72-b06e-af8fce00adcb&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Tour of The path-selected recorder failed for core-after, core-before; see the run artifact and failed manifests. Path-selected interactions
core-before: the media could not be published (refused 1 file(s) that show private names: 25009/60f1601b/next-core-before/shots/07-new-terminal-tab.png (fleet Mac mini name, personal machine or account name, fleet shell prompt). Nothing was upload)core-after: the media could not be published (refused 1 file(s) that show private names: 25009/60f1601b/next-core-after/shots/07-new-terminal-tab.png (fleet Mac mini name, personal machine or account name, fleet shell prompt). Nothing was uploade)Tours are data in |
|
Owned by claude-sr2/subsession-card on cosmic-gray · session |
|
Found 21 test failures on Blacksmith runners: Failures
...and 11 more test failures. View all on Blacksmith: run 40152488233, run 40152488249
|
|
Bead |
…tifact, run 40148480180) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16f9b-2fcb-7c72-b06e-af8fce00adcb&host=cosmic-gray
Default changesThis pull request changes 7 defaults at
Needs a review. It passes with an independent review receipt on this commit: a comment or review whose first line is Merge receipt: merged as Regenerate the snapshot with |
…port-red/newtab-widget-policy # Conflicts: # schemas/settings-export/settings-schema.sources.sha256
…autofix artifact, run 40151563857) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16f9b-2fcb-7c72-b06e-af8fce00adcb&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
fe482b4 added Settings › Server, whose only card (ServerCard) draws from the host lists' `server`. Once the settings exports carried the category (#25009's regeneration), pages.settings made its server and server-customized variants, and both fail gallery health: the shared fixture host has no `server`, so the category draws no card and the page's wait for one never holds. The fixture host now reports one running server, as the app's host does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1708f-432e-7f23-a9e8-11c5945da2f6&host=cosmic-gray
|
Shipped in:
|
…ers (#25068) fe482b4 added Settings › Server, whose only card (ServerCard) draws from the host lists' `server`. Once the settings exports carried the category (#25009's regeneration), pages.settings made its server and server-customized variants, and both fail gallery health: the shared fixture host has no `server`, so the category draws no card and the page's wait for one never holds. The fixture host now reports one running server, as the app's host does. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1708f-432e-7f23-a9e8-11c5945da2f6&host=cosmic-gray Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red fix. On
feat-cmux-next,SettingsSchemaExportTestsfails since #24631 added four New Tab widget keys (tabs.newTabWidgets.clock,.timer,.warmGreeting,.quote):everyKeyHasAnExplicitAgentPolicy(): "no agent policy for: tabs.newTabWidgets.clock, .quote, .timer, .warmGreeting"exportIsFresh(): "keys not in Localizable.xcstrings: settings.tabs.newTabWidgets.clock, .clock.help, …"Because of this the PR autofix can't regenerate the settings exports or their source stamp, so every PR that touches
CmuxNextSettings/goes red on "cmux-next guards / defaults-snapshot: The settings exports match their sources" (for example #25002; autofix run https://github.com/manaflow-ai/cmux/actions/runs/40146368970).Change
SettingsSchema+AgentPolicy.swift: the four keys joinagentSettableTablenext to their sibling looks-only widget toggles (greeting,projects,actions,chats,styleDots,machines). None of them reach the network: the quote is bundled, and the clock, stopwatch and greeting are local. (weatherandweatherCitystay refused as.network.)Localizable.xcstrings: titles and.helpfor the four keys in all 21 locales the file uses. The English matches the Swift fallbacks exactly, and the wording follows the sibling widget strings. Most of the diff (about 1050 lines) is this JSON: 8 keys times 21 locales.pr-autofix-patchartifact, never written by hand.Risk: low. An agent (MCP
settings_set) can now turn these four looks-only widgets on or off, as it already can for the other widget toggles. Nothing changes for the person.Tests:
SettingsSchemaExportTests(everyKeyHasAnExplicitAgentPolicy,exportIsFresh) run in CI's "action exports (Mac)" job.No capture: settings metadata only (agent policy and strings), no UI change.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.