Skip to content

cmux-next settings: New Tab clock, stopwatch, greeting and quote get an agent policy and strings (base red) - #25009

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
settings-export-red/newtab-widget-policy
Oct 25, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
settings-export-red/newtab-widget-policy

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Base red fix. On feat-cmux-next, SettingsSchemaExportTests fails since #24631 added four New Tab widget keys (tabs.newTabWidgets.clock, .timer, .warmGreeting, .quote):

  • everyKeyHasAnExplicitAgentPolicy(): "no agent policy for: tabs.newTabWidgets.clock, .quote, .timer, .warmGreeting"
  • exportIsFresh(): "keys not in Localizable.xcstrings: settings.tabs.newTabWidgets.clock, .clock.help, …"

Because of this the PR autofix can't regenerate the settings exports or their source stamp, so every PR that touches CmuxNextSettings/ goes red on "cmux-next guards / defaults-snapshot: The settings exports match their sources" (for example #25002; autofix run https://github.com/manaflow-ai/cmux/actions/runs/40146368970).

Change

  • SettingsSchema+AgentPolicy.swift: the four keys join agentSettableTable next to their sibling looks-only widget toggles (greeting, projects, actions, chats, styleDots, machines). None of them reach the network: the quote is bundled, and the clock, stopwatch and greeting are local. (weather and weatherCity stay refused as .network.)
  • Localizable.xcstrings: titles and .help for the four keys in all 21 locales the file uses. The English matches the Swift fallbacks exactly, and the wording follows the sibling widget strings. Most of the diff (about 1050 lines) is this JSON: 8 keys times 21 locales.
  • The regenerated exports and stamp come from the PR autofix's pr-autofix-patch artifact, never written by hand.

Risk: low. An agent (MCP settings_set) can now turn these four looks-only widgets on or off, as it already can for the other widget toggles. Nothing changes for the person.

Tests: SettingsSchemaExportTests (everyKeyHasAnExplicitAgentPolicy, exportIsFresh) run in CI's "action exports (Mac)" job.

No capture: settings metadata only (agent policy and strings), no UI change.

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

… get an agent policy and strings

SettingsSchemaExportTests failed on base: the four tabs.newTabWidgets keys had no
agent policy and their titles and help were missing from Localizable.xcstrings, so
the PR autofix could not regenerate the settings exports.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16f9b-2fcb-7c72-b06e-af8fce00adcb&host=cosmic-gray
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 60f1601: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25009 -f ref=settings-export-red/newtab-widget-policy -f platform=macos -f backend_mode=local

web and size checks: green

Tour of 60f1601b88 (run)

The path-selected recorder failed for core-after, core-before; see the run artifact and failed manifests.

Path-selected interactions

Interaction Changed paths
core Packages/macOS/CmuxNext/Sources/CmuxNextSettings/Localizable.xcstrings
Packages/macOS/CmuxNext/Sources/CmuxNextSettings/Schema/SettingsSchema\+AgentPolicy.swift

core-before: the media could not be published (refused 1 file(s) that show private names: 25009/60f1601b/next-core-before/shots/07-new-terminal-tab.png (fleet Mac mini name, personal machine or account name, fleet shell prompt). Nothing was upload)

core-after: the media could not be published (refused 1 file(s) that show private names: 25009/60f1601b/next-core-after/shots/07-new-terminal-tab.png (fleet Mac mini name, personal machine or account name, fleet shell prompt). Nothing was uploade)

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by claude-sr2/subsession-card on cosmic-gray · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 25, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Found 21 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpu_2c872i/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpuvw2hmu2/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
bundle-cmux-tui.sh failed (/tmp/tmp.2wJruX8qhb/new/cmux-tui) View Logs
bundle-cmux-tui.sh failed (/tmp/tmp.2wJruX8qhb/new/cmux-tui) View Logs
bundle-cmux-tui.sh failed (tree, /tmp/tmp.HfnpfFFjZ4/build/one/cmux-tui) View Logs
bundle-cmux-tui.sh failed (tree, /tmp/tmp.HfnpfFFjZ4/build/one/cmux-tui) View Logs

...and 11 more test failures. View all on Blacksmith: run 40152488233, run 40152488249

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-xgupa created for this PR by the cmux coordinator.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Default changes

This pull request changes 7 defaults at 60f1601b8825 (what everyone gets without configuring anything):

  • setting.diff.layout: "unified" -> "auto"
  • setting.diff.showBulkActions: (none) -> true
  • setting.layout.scrollModifier: (none) -> "command"
  • setting.tabs.newTabWidgets.clock: (none) -> false (a new setting, off by default: passes on its own)
  • setting.tabs.newTabWidgets.quote: (none) -> false (a new setting, off by default: passes on its own)
  • setting.tabs.newTabWidgets.timer: (none) -> false (a new setting, off by default: passes on its own)
  • setting.tabs.newTabWidgets.warmGreeting: (none) -> false (a new setting, off by default: passes on its own)

Needs a review. It passes with an independent review receipt on this commit: a comment or review whose first line is Review (<reviewer>): SHIP at 60f1601b88255dc0df63dde6e234c75c36fcb7ad, from a member, not a self-review (the newest verdict naming the head decides; a later BLOCK beats an earlier SHIP), or with an approving review on this commit from @lawrencecchen or @austinywang (the call owners in .github/defaults-call-owners.json, never the author). A receipt posted as a review re-runs this check; after a plain comment, re-run it. The needs a call label alone does not pass, and a new push needs a new receipt.

Merge receipt: merged as 0beb3fcfd62b with these defaults changed, WITHOUT a SHIP receipt or an approving call owner review on its head.

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

…port-red/newtab-widget-policy

# Conflicts:
#	schemas/settings-export/settings-schema.sources.sha256
@cursor

cursor Bot commented Oct 25, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo
teamleaderleo merged commit 0beb3fc into feat-cmux-next Oct 25, 2026
153 of 162 checks passed
@teamleaderleo
teamleaderleo deleted the settings-export-red/newtab-widget-policy branch October 25, 2026 02:18
teamleaderleo added a commit that referenced this pull request Oct 25, 2026
fe482b4 added Settings › Server, whose only card (ServerCard) draws from the host lists' `server`.
Once the settings exports carried the category (#25009's regeneration), pages.settings made its
server and server-customized variants, and both fail gallery health: the shared fixture host has no
`server`, so the category draws no card and the page's wait for one never holds. The fixture host
now reports one running server, as the app's host does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1708f-432e-7f23-a9e8-11c5945da2f6&host=cosmic-gray
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

teamleaderleo added a commit that referenced this pull request Oct 25, 2026
…ers (#25068)

fe482b4 added Settings › Server, whose only card (ServerCard) draws from the host lists' `server`.
Once the settings exports carried the category (#25009's regeneration), pages.settings made its
server and server-customized variants, and both fail gallery health: the shared fixture host has no
`server`, so the category draws no card and the page's wait for one never holds. The fixture host
now reports one running server, as the app's host does.


Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1708f-432e-7f23-a9e8-11c5945da2f6&host=cosmic-gray

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

4 inactive deployments
artifacts — 60f1601b Deployed Oct 25, 2026 by teamleaderleo via add the Windows daemon to the tree #51542
sentry-dsyms — 60f1601b Deployed Oct 25, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #51542
ci-routing-agent — 60f1601b Deployed Oct 25, 2026 by github-actions[bot] via cmux-next macOS placement #34248
cmux-tui-merge-tree — 60f1601b Deployed Oct 25, 2026 by teamleaderleo via publish the merge tree #5641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant