Skip to content

fix(next): sidebar section menu keeps 12 top-level rows (Inspect Element under Options) - #24995

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
menu-parity-red
Oct 25, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
menu-parity-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the base red that hides signal: ActionSurfaceParityTests.everyMenuKeepsAShortTopLevel fails with .sidebarSection has 13 top-level rows (limit 12). It fails inside the generated-files job before regeneration, so CI's autofix never commits regenerated exports, and PRs that need them (for example #24923) stay red.

Cause: #24707 (0bf7675, "add palette and context-menu UI inspector entry points") gave the sidebar section's right-click menu a top-level Inspect Element row. That made 13 top-level rows. #24758 already moved the same row into Tools ▸ on the agent chat menu for the same reason, but missed this menu.

Change: on the sidebar section menu, Inspect Element moves into the existing Options ▸ folder, which already has Space Scope and Max Rows. A Tools ▸ folder holding only this row would break the test's 2-rows-per-folder rule. tab.showResources already sits in Options ▸ from the inspect group, so this follows an existing pattern. No action is removed: it stays reachable from Options ▸, the palette, the keyboard and cmux agent toggle-ui-pointer. Every other menu keeps its Inspect Element row where it was. The test is unchanged. No motion changes.

Risk: low. One placement moves one level down in one right-click menu. Exports (plans/cmux-next/action-surfaces.json, actions.md) are regenerated by the PR autofix.

Menu, before → after (sidebar section header, right-click; rows from the catalog / plans/cmux-next/actions.md):

  • Before (13 top-level rows): New Section… · New Workspace in Section · Add to Sidebar… | Rename Section · Appearance ▸ · Options ▸ (Space Scope, Max Rows) | Collapse/Expand Section | Move ▸ | Inspect Element | Hide Section | Close All Workspaces in Section · Hide App | Remove Section
  • After (12 top-level rows): the same, except Inspect Element is the last row of Options ▸ (Space Scope, Max Rows, Inspect Element).

Screenshots: not captured. cmux-ci capture only snapshots the main window, so it leaves out a native right-click menu, and nx-remote --needs gui --app-from-fleet (the path scripts/cmux-next/context-menu-shots.py uses) was refused on cmux-lawrence-2 and mac26 ("the host did not answer"). A section-menu shot script is ready for when a GUI host takes --app-from-fleet.

Proof: cmux-ci run --script scripts/ci/package-test-lane.sh --arg=suite ActionSurfaceParityTests,ArchiveSurfacesTests on the fleet (result below).

Agent session: cosmic-gray

🤖 Generated with Claude Code

…ent under Options)

The Labs UI inspector placement from #24707 made the sidebar section's
right-click menu 13 top-level rows, failing everyMenuKeepsAShortTopLevel
in the generated-files job before its regeneration step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1700d-4a8a-7153-9cc3-2e1d2c48cc89&host=cosmic-gray
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review c84d360: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24995 -f ref=menu-parity-red -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b46b10e to compare; do not merge until green; see lane-rules

Tour of c84d360771 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by claude-sr2/menu-parity-red on cosmic-gray · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 24, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Found 14 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp2qa7hoi7/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpunrqh0c0/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes (main.PreP
ushGateTests.test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes)/
test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes (main.PreP
ushGateTests.test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes)
View Logs
test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes (main.PreP
ushGateTests.test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes)/
test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes (main.PreP
ushGateTests.test_a_branch_that_merges_feat_cmux_next_in_is_judged_on_its_own_changes)
View Logs
test_a_merge_cannot_use_an_upstream_removal_to_pay_for_the_branch_s_own_debt (main.
PrePushGateTests.test_a_merge_cannot_use_an_upstream_removal_to_pay_for_the_branch_s_ow
n_debt)/
test_a_merge_cannot_use_an_upstream_removal_to_pay_for_the_branch_s_own_debt (main.
PrePushGateTests.test_a_merge_cannot_use_an_upstream_removal_to_pay_for_the_branch_s_ow
n_debt)
View Logs

...and 4 more test failures. View all on Blacksmith: run 40146671492, run 40146671552

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-226jk created for this PR by the cmux coordinator.

@cursor

cursor Bot commented Oct 25, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

…nt under Options)

From CI's regeneration (cmux-next PR autofix run 40145360049, action-exports artifact).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1700d-4a8a-7153-9cc3-2e1d2c48cc89&host=cosmic-gray
@teamleaderleo
teamleaderleo temporarily deployed to cmux-tui-merge-tree October 25, 2026 00:26 — with GitHub Actions Inactive
@teamleaderleo
teamleaderleo merged commit bd8d770 into feat-cmux-next Oct 25, 2026
192 of 201 checks passed
@teamleaderleo
teamleaderleo deleted the menu-parity-red branch October 25, 2026 00:55
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

4 inactive deployments
artifacts — c84d3607 Deployed Oct 25, 2026 by teamleaderleo via add the Windows daemon to the tree #51329
ci-routing-agent — c84d3607 Deployed Oct 25, 2026 by github-actions[bot] via cmux-next macOS placement #34122
sentry-dsyms — c84d3607 Deployed Oct 25, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #51329
cmux-tui-merge-tree — c84d3607 Deployed Oct 25, 2026 by teamleaderleo via publish the merge tree #5622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant