Repository navigation
fix(next): sidebar section menu keeps 12 top-level rows (Inspect Element under Options) - #24995
Conversation
…ent under Options) The Labs UI inspector placement from #24707 made the sidebar section's right-click menu 13 top-level rows, failing everyMenuKeepsAShortTopLevel in the generated-files job before its regeneration step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1700d-4a8a-7153-9cc3-2e1d2c48cc89&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b46b10e to compare; do not merge until green; see lane-rules Tour of |
|
Owned by claude-sr2/menu-parity-red on cosmic-gray · session |
|
Found 14 test failures on Blacksmith runners: Failures
...and 4 more test failures. View all on Blacksmith: run 40146671492, run 40146671552
|
|
Bead |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…nt under Options) From CI's regeneration (cmux-next PR autofix run 40145360049, action-exports artifact). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1700d-4a8a-7153-9cc3-2e1d2c48cc89&host=cosmic-gray
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes the base red that hides signal:
ActionSurfaceParityTests.everyMenuKeepsAShortTopLevelfails with.sidebarSection has 13 top-level rows(limit 12). It fails inside the generated-files job before regeneration, so CI's autofix never commits regenerated exports, and PRs that need them (for example #24923) stay red.Cause: #24707 (0bf7675, "add palette and context-menu UI inspector entry points") gave the sidebar section's right-click menu a top-level Inspect Element row. That made 13 top-level rows. #24758 already moved the same row into Tools ▸ on the agent chat menu for the same reason, but missed this menu.
Change: on the sidebar section menu, Inspect Element moves into the existing Options ▸ folder, which already has Space Scope and Max Rows. A Tools ▸ folder holding only this row would break the test's 2-rows-per-folder rule.
tab.showResourcesalready sits in Options ▸ from the inspect group, so this follows an existing pattern. No action is removed: it stays reachable from Options ▸, the palette, the keyboard andcmux agent toggle-ui-pointer. Every other menu keeps its Inspect Element row where it was. The test is unchanged. No motion changes.Risk: low. One placement moves one level down in one right-click menu. Exports (
plans/cmux-next/action-surfaces.json,actions.md) are regenerated by the PR autofix.Menu, before → after (sidebar section header, right-click; rows from the catalog /
plans/cmux-next/actions.md):Screenshots: not captured.
cmux-ci captureonly snapshots the main window, so it leaves out a native right-click menu, andnx-remote --needs gui --app-from-fleet(the pathscripts/cmux-next/context-menu-shots.pyuses) was refused on cmux-lawrence-2 and mac26 ("the host did not answer"). A section-menu shot script is ready for when a GUI host takes--app-from-fleet.Proof:
cmux-ci run --script scripts/ci/package-test-lane.sh --arg=suite ActionSurfaceParityTests,ArchiveSurfacesTestson the fleet (result below).Agent session: cosmic-gray
🤖 Generated with Claude Code