Repository navigation
cmux NEXT: support inline /btw side questions - #24876
teamleaderleo wants to merge 5 commits into
Conversation
|
Found 82 test failures on Blacksmith runners: Failures
...and 72 more test failures. View all on Blacksmith: run 40246442704, run 40246442677
|
|
Bead |
dfae208 to
ba2b749
Compare
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; NEW: green on the base c85530a; do not merge until green; see lane-rules Tour of Gallery before/after for
States
Pick other states with a |
ba2b749 to
5b55871
Compare
|
Independent xhigh review receipt: delegated Codex session review_btw_final inspected exact head 5b55871 against base cf59385 and returned SHIP with no P0-P3 findings. It verified the recursive side-session guard, inline read policy, native side_question path, fallback cleanup, transcript anchoring, localization, and focused tests. |
teamleaderleo
left a comment
There was a problem hiding this comment.
Independent xhigh review receipt from delegated Codex session review_btw_final: exact head 5b558714a269ac9143e1e1ce70402a3b44ce48d9 against base cf59385454b7187747e750ac207feffb7ec12a7c is SHIP with no P0-P3 findings. It verified the recursive side-session guard, inline ApproveReads/DenyAll policy, native side_question path, fallback cleanup, transcript anchoring, localization, and focused tests.
Leo 2026-10-24: "we need to support /btw". Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16c64-58ea-75e2-975b-be6884023f13&host=big-red
…s (red) Off: the palette has no Ask a Side Question…. On: it is offered in a focused agent chat, turning the toggle off hides it live, and running it sends the chat's page the sideQuestion command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a1756c-d04d-7a81-90cb-79d1dd1c763d&host=gcp-codex-lane-1
|
Owned by nx-chat on big-red · session |
Restores the palette action (agentPane.sideQuestion) behind the sideSessions context bit that ActionRegistry.publishSideSessions keeps in step with Debug Settings' Side sessions (/btw), with its 21-locale strings and the regenerated action exports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5b55871 to
b314e23
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Orphaned: no activity for 14 h, and no lane holds a lease on it. The orphan sweep could not merge |
|
Review (codex gpt-6-astra xhigh, next-review): BLOCK at b314e23
Tests could not be run from the supplied partial snapshot. |
|
Superseded by #26108, which carries the inline /btw side-question implementation. Closing this stale conflicting branch so the replacement can land. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
What changed
Leo, 2026-10-24: “we need to support /btw”.
This adds inline
/btwfor every harness:side_questioncontrol request through the running stream-json process./btwin slash completion, preserves legacy split side-chat callers, and keeps attachment drafts intact.Fixes #24872
Validation
bun test test/btw-notes.test.ts test/cmux-command-btw.test.ts test/header-state-side-sessions.test.ts— 7 passed.bun run gallery:build; Chromium gallery matrix at exact head5b558714a269ac9143e1e1ce70402a3b44ce48d9: before, answered light/dark, pending, failed, Arabic, and dismissible states mounted with no overflow or errors (play status pass/warn only).scripts/web-lint.sh --base cf59385454b7187747e750ac207feffb7ec12a7c --new-only— passed; inherited base findings reported by the helper.python3 scripts/cmux-next/prepush-gate.py --base cf59385454b7187747e750ac207feffb7ec12a7c --head 5b558714a269ac9143e1e1ce70402a3b44ce48d9— no new violations.cargo fmt --all -- --check,git diff --check, and Swift syntax verification passed.8443c02a7d023125); no cargo-test green claim.The full web check still reports existing base design-token/layer/text-focus/type findings; the new-only lint gate confirms this change adds none.
pr-overlapreported five hot-file overlaps (#24335, #24272, #24293, #24223, #24468), all unrelated translator/inspector features; no/btwimplementation overlap was found.agent-identity footer
Agent session: big-red
Gallery evidence
Exact-head Chromium gallery captures from
agent-pane.btw-aside(5b558714a269ac9143e1e1ce70402a3b44ce48d9):Before / after (dark):
Light theme after: