Repository navigation
fix(next palette): keep query focused after Cmd-P - #24814
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base e0bb2a8; does not block Tour of The path-selected recorder failed for core-after, core-before; see the run artifact and failed manifests. Path-selected interactions
Core UI (before): FAILED — 16 ok, 3 failed, 1 unavailable
Failed steps: 5. Split right Screenshots (12)1. Launch
Failed steps: 5. Split right Screenshots (7)1. Launch Tours are data in |
|
Found 12 test failures on Blacksmith runners: Failures
...and 2 more test failures. View all on Blacksmith: run 40075725231, run 40075725046
|
|
Bead |
7d88ba0 to
e2a2345
Compare
e2a2345 to
9bbf92a
Compare
|
Review (independent Codex xhigh): SHIP at Session receipt: Test coverage note: |
6707812 to
e9e5ca5
Compare
e9e5ca5 to
58cd2a8
Compare
|
Review (independent Codex xhigh): SHIP at Session receipt: The regression test now covers attach -> replacement -> detach responder ownership. No native build/test was run by the reviewer; fleet/CI remains the native verification path. |
|
Ready-to-land handoff at exact head
The |
|
reviewed 58cd2a8; c112d24 adds only a base update. Verification: |
|
Shipped in:
|



























![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes #4303
The palette's detached panel can attach its content before it becomes key. The query field now registers itself as the panel's
initialFirstResponder, clears the previous window registration when detached, and the panel re-focuses the field from itsbecomeKeyseam after the key-window handoff. Cmd-P and Cmd-Shift-P therefore keep subsequent typing in the palette query.Tests:
python3 scripts/cmux-next/prepush-gate.py(pass: no new violations)e9e5ca5675c4d426d80557fe7ccb41c6a0703e25.Changelog: Cmd-P and Cmd-Shift-P now focus the palette query field reliably during detached panel key-window handoff.
No capture: behavior-only responder handoff; there is no visual-state change, and PaletteFocusTests covers attach, replacement, and detach responder ownership. The native key-window handoff remains fleet/CI verified.
Base:
fabbd7139acdc4413a35532898f416a10291f0b4Head:
58cd2a8d52b6130acc31cae9fb525de709122805Agent session: big-red