Repository navigation
fix(acpmux): surface outbound queue gaps (#21000) - #24811
Conversation
Fixes #21000 An output queue that fills must leave a replay signal while preserving response capacity. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16c6c-0725-73b2-8d5e-1e50d0cd8545&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on eac20cf to compare; do not merge until green; see lane-rules |
|
Found 12 test failures on Blacksmith runners: Failures
...and 2 more test failures. View all on Blacksmith: run 40085833211, run 40085833162
|
|
Bead |
|
Review note: |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes #21000
The bounded outbound queue now reserves capacity for an RPC response and a recovery marker. When notification delivery is rejected by queue pressure, ACPMUX emits
_acpmux/laggedwithreason: output_queue_fulland a cumulative dropped count so clients can replay from their cursor. Inventory-watch notifications follow the same reserve policy.Changelog
Verification
python3 scripts/cmux-next/prepush-gate.py— passed on4849c970882c9dd7b2cefc4b9e359152e7541a95.cargo fmt --manifest-path cmux-tui/Cargo.toml --all -- --check— passed.Agent session: huge-blue
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes outbound queue backpressure in ACPMUX so slow clients get a replay signal instead of silently dropped notifications, while always reserving capacity for RPC responses.
_acpmux/laggedrecovery marker so notifications can't crowd out replies._acpmux/laggedwithreason: output_queue_fulland a cumulative dropped count when notifications are dropped; oversized notifications reportreason: message_too_large.Written for commit 3c72e64. Summary will update on new commits.