Skip to content

fix(next): clean up UI inspector from nonisolated deinit - #24719

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
codex/ui-inspector-deinit
Oct 24, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
codex/ui-inspector-deinit

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

#24707 introduced the UI inspector's @MainActor cleanup, and the next Release compile exposed Swift 6.2 errors in its deinit. This forward fix makes deinit nonisolated and performs AppKit monitor/notification removal only under MainActor.assumeIsolated on the main thread, matching the existing package pattern. It is required to get a Release compile green at the current tip after Aziz's WebRTC notice fix 83cb35f5b2b.

Validation:

  • Release compile failure reproduced on run 40055959790 (UIInspectorController.swift:44-45).
  • Nonisolated deinit follows existing MainActor.assumeIsolated cleanup pattern.
  • git diff --check.

agent-identity footer
Agent session: huge-blue


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the Release compile error in the UI inspector's deinit: cleanup is now nonisolated and only removes AppKit monitors/observers when already on the main thread, matching the existing MainActor.assumeIsolated pattern. The Release build previously failed at UIInspectorController.swift:44-45 under Swift 6.2.

CI

  • Adds an advisory warning step that flags missing or unmapped bundled binaries in Release builds; the signed nightly check remains authoritative.

Written for commit 60eb15a. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 60eb15a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24719 -f ref=codex/ui-inspector-deinit -f platform=macos -f backend_mode=local

red: cmux-next crash ratchet; NEW: green on the base 51897ba; do not merge until green; see lane-rules

Tour of 60eb15a2ef (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 24, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 24, 2026

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/
test_base_passes (main.NoticesPairTests.test_base_passes)
View Logs
test_bundled_webrtc_framework_passes_with_the_committed_map_and_notices (main.Check
BundleNoticesTest.test_bundled_webrtc_framework_passes_with_the_committed_map_and_notic
es)/
test_bundled_webrtc_framework_passes_with_the_committed_map_and_notices (main.Check
BundleNoticesTest.test_bundled_webrtc_framework_passes_with_the_committed_map_and_notic
es)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at 60eb15a

@teamleaderleo
teamleaderleo merged commit 274ef5c into feat-cmux-next Oct 24, 2026
119 of 137 checks passed
@teamleaderleo
teamleaderleo deleted the codex/ui-inspector-deinit branch October 24, 2026 03:08

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 60eb15a2 Deployed Oct 24, 2026 by teamleaderleo via namespace autofix #2275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant