Repository navigation
fix(next): clean up UI inspector from nonisolated deinit - #24719
Merged
Merged
Conversation
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 24, 2026 03:04 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next crash ratchet; NEW: green on the base 51897ba; do not merge until green; see lane-rules Tour of |
|
Found 3 test failures on Blacksmith runners: Failures
|
Collaborator
Author
|
Review (subagent, correctness first): SHIP at 60eb15a |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
#24707 introduced the UI inspector's
@MainActorcleanup, and the next Release compile exposed Swift 6.2 errors in its deinit. This forward fix makes deinit nonisolated and performs AppKit monitor/notification removal only underMainActor.assumeIsolatedon the main thread, matching the existing package pattern. It is required to get a Release compile green at the current tip after Aziz's WebRTC notice fix83cb35f5b2b.Validation:
MainActor.assumeIsolatedcleanup pattern.git diff --check.agent-identity footer
Agent session: huge-blue
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the Release compile error in the UI inspector's deinit: cleanup is now
nonisolatedand only removes AppKit monitors/observers when already on the main thread, matching the existingMainActor.assumeIsolatedpattern. The Release build previously failed atUIInspectorController.swift:44-45under Swift 6.2.CI
Written for commit 60eb15a. Summary will update on new commits.