Repository navigation
fix(cmux-next): PageScriptPipeline compiles again (no covariant Self in a default argument) - #24687
azooz2003-bit wants to merge 1 commit into
Conversation
…in a default argument) #24617 made the init's default render closure call Self.render, which the swift.org toolchain rejects: "covariant 'Self' type cannot be referenced from a default argument expression" (PageScriptPipeline.swift:90). Name the type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 83e719d to compare; do not merge until green; see lane-rules |
|
Review (subagent, correctness first): SHIP at 9eec130 Checked: the class is |
|
Found 14 test failures on Blacksmith runners: Failures
...and 4 more test failures. View all on Blacksmith: run 40045593339, run 40045593449
|
|
Bead |
|
Superseded by #24690, which landed the same fix on feat-cmux-next at 00:41Z. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
The base
feat-cmux-nextdoes not compile since #24617 (4abd404): the build fleet's app compile fails atPackages/macOS/CmuxNext/Sources/CmuxNextPages/PageScriptPipeline.swift:90withcovariant 'Self' type cannot be referenced from a default argument expression. The defaultrenderclosure ofPageScriptPipeline.initcalledSelf.render; it now names the type,PageScriptPipeline.render. The class isfinal, so it is the same static function and behavior does not change.This red shows up as "its own red: cmux-next app compile" on every PR that merges the base, for example #24598.
Testing
cmux-ci compile-check --ref 7455b41377f3f8400681683a7a88f1dd0a28b205 --app(base tip): failed, the error above (job 4036cb717f3df749867d6175).cmux-ci compile-check --ref 9eec1304257976e13577ef1e4280c4d17492ea71 --app(this head): passed (job 00dd50bc7b86c6881942d3e9).scripts/cmux-next/prepush-gate.py: no new violations.Observed / Not run
Observed: the two fleet compile-checks above. Not run: tests (a compile fix;
PageScriptPipelineTestsexercises the default at line 49 and runs in CI).No capture: compile fix, no UI change.
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
feat-cmux-nextapp compile by replacing a covariantSelfreference in the defaultrenderargument ofPageScriptPipeline.init. Since the class isfinal, naming the type explicitly (PageScriptPipeline.render) is identical in behavior but no longer rejected by the toolchain. No test or behavior changes.Written for commit 9eec130. Summary will update on new commits.