Repository navigation
cmux NEXT composer: restore project icons after an empty host answer - #24623
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on be5d73b to compare; do not merge until green; see lane-rules Tour of |
|
Found 35 test failures on Blacksmith runners: Failures
...and 25 more test failures. View all on Blacksmith: run 40047927307, run 40047927349, run 40047927488
|
|
Bead |
cd568a3 to
b825a70
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Keep the existing project favicon and language heuristics intact while avoiding a permanent generic-folder cache when the host answers before icon capability is ready. Add regression coverage for a later icon answer. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16a89-20f0-7ff2-8bb0-ec0bb3ae3a5e&host=big-red
Accept more than ten attachments in the shared composer and New Tab intake, including saved links and restored chips. Keep per-file and byte limits intact and replace the old refusal assertions with acceptance coverage. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16a89-20f0-7ff2-8bb0-ec0bb3ae3a5e&host=big-red
Keep the existing project.icon heuristic visible in the current project trigger, not only in menu rows. Remote projects still avoid local icon reads. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16a89-20f0-7ff2-8bb0-ec0bb3ae3a5e&host=big-red
b825a70 to
c63216b
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
teamleaderleo
left a comment
There was a problem hiding this comment.
SHIP — exact head c63216b.
Independent Codex review confirms the project icon retry and ProjectBadge chip/menu paths are clean, including the #21244 custom icon family and #24194 base behavior. No P1/P2/P3 findings. Fleet compile receipt b4cd8c989e0c1e03706862cb completed app compile with an explicit passed result.
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
The project picker could permanently settle on the generic folder when its first
project.iconanswer was empty while the host capability was still warming. Empty answers now stay uncached, so reopening the project picker asks again and displays the returned project favicon or language mark in both project menu rows and the current project trigger in the composer/new-tab location chip.Leo described the current regression as: “project icons are CURRENTLY generic rather than the reading heuristics thing we did before”. The existing
project.iconheuristic remains the source of truth; this fix only prevents an empty first answer from masking it and ensures the current chip uses the same badge as the menu. Remote projects still avoid local icon reads.Validation
git diff --checkProjectBadgeregression coverage for an empty answer followed by a real icon.@base-ui/utils/useIsoLayoutEffectdependency.Changelog
Fixed project picker rows and composer project chips so a later project icon answer replaces the generic folder.
agent-identity footer
Agent session: big-red
Gallery: agent-pane.composer-context/folder-favicons, agent-pane.composer-context/closed